Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F4BE249FF for ; Mon, 27 May 2024 11:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716808410; cv=none; b=pM8ZHFz5VaIDMFPlAUb+pCIeZ5somDhG2u6VUtcrqtbNAsgK+MITlKzVu187KtXUuV0Cq1yvHR6+6kjaCufIF4aTX22DVcFx+Ai+t5LFT+P5nx2LCMTE4VE8IX/OhEKNorEukj5JyIIgzIxHdtiiA+7kl+gsEFIPNxu8RuR2cHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716808410; c=relaxed/simple; bh=TefB1iPMas+LQhrdgfZ+wAMbZb8Zxd6PrJsRCfarqkk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uA7C2kfQuKalscV+B2mpwK/zzK6hHL44Zr/iitPU712ut6QrxF3ZXA9Jd3sPXv8YVV5B3d/u8yA8Xnmo5e4S3/4LDFgWqWNEqh7cKaNkIBYUu5/kh/LNZVsQb2vH/BnCVhKyC1MFl38s66cn7nmMQTtjpj09vn8KxVqjEpURnP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=C6VLZzTk; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=+TMofbwc; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=C6VLZzTk; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=+TMofbwc; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="C6VLZzTk"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="+TMofbwc"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="C6VLZzTk"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="+TMofbwc" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 502CD21E24; Mon, 27 May 2024 11:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716808407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D+Hi7paguIDzbUsMdUhggiomMPRKfog6A+RJL5KVIFI=; b=C6VLZzTkN+Avrh4C8iuHkEGPcLQwrvJECdLxKadUGrTU+IU804kK/yFj4ZR3DUX8k/1yND kyGLvUPrXW9Tp7nqCHZhnb8MNhrw1cYiU7tVOMLQDu7HbEPk3NBqpIHGNu/HwhSuDAiLrb WBJ5rA0wNMxM1yMhArxOk1EPmIEutr0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716808407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D+Hi7paguIDzbUsMdUhggiomMPRKfog6A+RJL5KVIFI=; b=+TMofbwcU+sEiB3+xwqflZGELPIq0lEcfRXlUJmWffmumUAZ9SnZDyMd6Nh9fG4apB+L2r 1NRUwkXTAu4aWCAg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=C6VLZzTk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+TMofbwc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1716808407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D+Hi7paguIDzbUsMdUhggiomMPRKfog6A+RJL5KVIFI=; b=C6VLZzTkN+Avrh4C8iuHkEGPcLQwrvJECdLxKadUGrTU+IU804kK/yFj4ZR3DUX8k/1yND kyGLvUPrXW9Tp7nqCHZhnb8MNhrw1cYiU7tVOMLQDu7HbEPk3NBqpIHGNu/HwhSuDAiLrb WBJ5rA0wNMxM1yMhArxOk1EPmIEutr0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1716808407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D+Hi7paguIDzbUsMdUhggiomMPRKfog6A+RJL5KVIFI=; b=+TMofbwcU+sEiB3+xwqflZGELPIq0lEcfRXlUJmWffmumUAZ9SnZDyMd6Nh9fG4apB+L2r 1NRUwkXTAu4aWCAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 432E013A6B; Mon, 27 May 2024 11:13:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WGpiENdqVGbIHwAAD6G6ig (envelope-from ); Mon, 27 May 2024 11:13:27 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id D0E78A07D0; Mon, 27 May 2024 13:13:22 +0200 (CEST) Date: Mon, 27 May 2024 13:13:22 +0200 From: Jan Kara To: Luis Chamberlain Cc: mgorman@suse.de, jack@suse.cz, vbabka@suse.cz, dave@stgolabs.net, ziy@nvidia.com, yuzhao@google.com, jhubbard@nvidia.com, ryan.roberts@arm.com, kdevops@lists.linux.dev, p.raghav@samsung.com, da.gomez@samsung.com, gost.dev@samsung.com Subject: Re: [mmtests PATCH v3 1/2] bin/install-depends: call ldconfig Message-ID: <20240527111322.xpxdklzpvd4gnuaw@quack3> References: <20240524215113.2373668-1-mcgrof@kernel.org> <20240524215113.2373668-2-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240524215113.2373668-2-mcgrof@kernel.org> X-Spam-Level: X-Spamd-Result: default: False [-3.84 / 50.00]; BAYES_HAM(-2.83)[99.27%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[13]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:email] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 502CD21E24 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Score: -3.84 On Fri 24-05-24 14:51:11, Luis Chamberlain wrote: > Some packages may have bugs and forgot to run ldconfig, work around > these bugs by ensuring we call ldconfig after installation *all* > required packages, we do this just once for a set of packages. > > Signed-off-by: Luis Chamberlain Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > bin/install-depends | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/bin/install-depends b/bin/install-depends > index e0052f274027..a7cfaa49977b 100755 > --- a/bin/install-depends > +++ b/bin/install-depends > @@ -254,6 +254,11 @@ foreach my $package (@ARGV) { > print "Installed $package\n"; > } > > +if (system("ldconfig") != 0) { > + print "ERROR: ldconfig failed\n"; > + exit(-1); > +} > + > if ($ENV{"MMTESTS_SESSION_ID"} ne "") { > close(SESSION); > } > -- > 2.43.0 > -- Jan Kara SUSE Labs, CR