Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1sBt3S-00076M-SX for mharc-qemu-trivial@gnu.org; Tue, 28 May 2024 05:23:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBt3Q-00075s-O9 for qemu-trivial@nongnu.org; Tue, 28 May 2024 05:23:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBt3P-00047E-86 for qemu-trivial@nongnu.org; Tue, 28 May 2024 05:23:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716888213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GiIG3EFPZ0dBuuM8Q/iUmKqxSxvg75nmSJ1FT+F9AGU=; b=cARBdFTsTVmBOE/5SAyT7Q3MgmR/QqfiKZrNZQV6GGLuWnxXIkmigtjqNi0Q190ikh3/Es WldDOIta0m0aOtoS8zWjJaarrbSI48OzpE81GI74nPIeUiFxsFySn1/7U30/HH2q98bgGD ky7/YYXOuMI2DgPV1sunGjfzPwQQH+A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-ddRKSFeeNvyrn3VDk6xskw-1; Tue, 28 May 2024 05:23:32 -0400 X-MC-Unique: ddRKSFeeNvyrn3VDk6xskw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-354f28306dfso468151f8f.0 for ; Tue, 28 May 2024 02:23:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716888211; x=1717493011; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GiIG3EFPZ0dBuuM8Q/iUmKqxSxvg75nmSJ1FT+F9AGU=; b=UaT9KGBxy/swwVYE7eiPiwES41UL/qWhqj0nE1k9rdp5V4fFiEv/9DVP/p9ZCtt7/N pgCqegFYG5W0DRNFeJ69YjgFDx1yLNFxYQOg6T18THDfAZQ8xTgJnPSA0jgaDBkFf/Zf VSPKYmsrQYpyRke5eZXPeH1MSuNEF/fbcgsFR60M+no3apJmzY3exhmPgyIHTPv8Ry3f GpPHyOq3bkekEFSjcDdUxDA01IYtZJoarasVt3D7rhaCYxQTmAgV1cVOVK+Evr/UfDMI 8w6UAPMix+FQt6SrBJ7i/VXfxC2SxwtEX2F75uIlrLDTd82MUXbIECjlHeFCGqeFe5cL Tmfg== X-Forwarded-Encrypted: i=1; AJvYcCVQQ01A3MLgIoKU41jTEtP+YGgGFQXFRJ03JXMEfqTgIAjkhdxw5uxLEkNx1fdsBr4IuILUpn76C2/wd0wY9Jk/MM1NLOL3zA== X-Gm-Message-State: AOJu0YyHu6F1+xHSJYv9BuARJLjrs/xEw3Ul/iNMnDAJGcs8RV8uhwdQ 8SGGkA4tdaIPL+mz4h0vOgkFQbMk5IyG1YHjGvvD6xgVAcbu6VN8OZf4wTU8kpzf8Qs0USBBU+y fVSPzC5MjctXdQCuOLWNPbZpJIA0odNBuOxfHO3Dl5pEYmAVhSLXYUis= X-Received: by 2002:a05:600c:54cc:b0:419:f630:57c2 with SMTP id 5b1f17b1804b1-421089f98d1mr89363025e9.37.1716888210992; Tue, 28 May 2024 02:23:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPlszxcSL842gGYVO5cN2F4JY8z8RF3aRn4CMl2XzfMw5gxlI5PzYGovCP7YNkPOim6kLEwg== X-Received: by 2002:a05:600c:54cc:b0:419:f630:57c2 with SMTP id 5b1f17b1804b1-421089f98d1mr89362855e9.37.1716888210608; Tue, 28 May 2024 02:23:30 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4210897bc02sm135851425e9.22.2024.05.28.02.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 02:23:30 -0700 (PDT) Date: Tue, 28 May 2024 11:23:27 +0200 From: Igor Mammedov To: Zide Chen Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com, thuth@redhat.com, cfontana@suse.de, xiaoyao.li@intel.com, qemu-trivial@nongnu.org Subject: Re: [PATCH V2 0/3] improve -overcommit cpu-pm=on|off Message-ID: <20240528112327.634e95a6@imammedo.users.ipa.redhat.com> In-Reply-To: <20240524200017.150339-1-zide.chen@intel.com> References: <20240524200017.150339-1-zide.chen@intel.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2024 09:23:36 -0000 On Fri, 24 May 2024 13:00:14 -0700 Zide Chen wrote: > Currently, if running "-overcommit cpu-pm=on" on hosts that don't > have MWAIT support, the MWAIT/MONITOR feature is advertised to the > guest and executing MWAIT/MONITOR on the guest triggers #UD. this is missing proper description how do you trigger issue with reproducer and detailed description why guest sees MWAIT when it's not supported by host. > > V2: > - [PATCH 1]: took Thomas' suggestion for more generic fix > - [PATCH 2/3]: no changes > > Zide Chen (3): > vl: Allow multiple -overcommit commands > target/i386: call cpu_exec_realizefn before x86_cpu_filter_features > target/i386: Move host_cpu_enable_cpu_pm into kvm_cpu_realizefn() > > system/vl.c | 4 ++-- > target/i386/cpu.c | 24 ++++++++++++------------ > target/i386/host-cpu.c | 12 ------------ > target/i386/kvm/kvm-cpu.c | 12 +++++++++--- > 4 files changed, 23 insertions(+), 29 deletions(-) >