Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6E2C25B75 for ; Wed, 29 May 2024 16:28:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 030EF6B009E; Wed, 29 May 2024 12:28:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F21C76B00A1; Wed, 29 May 2024 12:28:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE9036B00A3; Wed, 29 May 2024 12:28:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C1F776B009E for ; Wed, 29 May 2024 12:28:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6EF56160B4C for ; Wed, 29 May 2024 16:28:38 +0000 (UTC) X-FDA: 82171966716.20.A7FA5B6 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf05.hostedemail.com (Postfix) with ESMTP id 6F843100021 for ; Wed, 29 May 2024 16:28:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=O6WgHKwS; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717000116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4GIfIw3KCXCoHxAMLpFiJP52LLmu4oqzmem7rmugy9Q=; b=Ot+eHx+1a8h7iJuvmDHEV/PgVrZeRilou0ml4J7n28ZvalEeApsTSe30clEb7UXh+JBkPO /uq80GfKxWKsWk/OGerqY8KRObrM+RRRq5UxbYbw+KlI4+O/HH/gQJU5oTrMAo5K+yGXNt hKlEn4+Kl1qxMkF2+q0Ajx1SBEGnaE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717000116; a=rsa-sha256; cv=none; b=cDCumXfqiqKV++UYF5Pz1BWWgrQbMbOC/v1f+og8JJS/taO+ChjenFjLC09qYzL2QnPP8R OgJs3SRGsLw4a5C12G2281WrVURD94OQ86/HmR3kvzZFCopTn4i0piKpB564FdgK1oJzqR l1piA+qdv4cJW56Cvn7yjYiDpZ1eEw8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=O6WgHKwS; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6ada6a476c2so2508626d6.2 for ; Wed, 29 May 2024 09:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1717000115; x=1717604915; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4GIfIw3KCXCoHxAMLpFiJP52LLmu4oqzmem7rmugy9Q=; b=O6WgHKwSjSQ9Wz2avwbycjklXyPCRso9ZncNv3wYjFv7OmBm1UVZIyYAykG4VOSr4X sFc5mUWMgznFo00Q/AT9LHOEoqjUz61YaOsoaYflD5kcE2io9BQ4GLEZXSyjyRbKWqst mtiFYdPUVo0BaGAfZ1b5OdGlfnxdCYnhPPZ3/lh5HyiH/pIFG1EPmthJCPLDm1METV1g YYumCl5epQLnQCf3XhIz8DJ4N6XygLnF9w+5+ZMwiTyxcBIK7WeIfL/CDs+73EnLIrFu J1XlU0/aQulA9Dqm32Ti2vwUrwYE8J7Enx0UluSzE34DQo+sLFKeBZLfPg1rox0kRY0M 0Zwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717000115; x=1717604915; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4GIfIw3KCXCoHxAMLpFiJP52LLmu4oqzmem7rmugy9Q=; b=nhXgZC34JTj/l7c6AL19MPiXG3WvuwDVGTJmf5T6LZ0XexCXJWRKKDopcBeJTw/vlB wATnh7W4EXXxAQS8wVlnf65/nMWYqqzSblzrQ1qfX6rhP2anvTotChXI5WAwqG2Jq5uV E36/6r5sApaluWCUsubyJNHNdU9A61t8+2N13O1X1cWQJXcwlIDpQcIdW/WI75r35bM+ ogP8m6v/xV89SEBfLe2cVLcQa+OjUApjASmSpzsCD47gjlUT9+XveJusbDxLuSn/Pdoe F3ri+abf63XhepGS7BNI6K/Eul4n62yU65lfoPR/E6MMKhn/TMJ7orXzCHtgQiM+B0oI /DdQ== X-Forwarded-Encrypted: i=1; AJvYcCUfeCC/JT+iC0DlUu0mu0xKFtW4P6gl7SVyEAWFmrT/wc2ULlbvV9lMtv45O9+scWS//B8y2Y/lxT4G6kGtLil41Ug= X-Gm-Message-State: AOJu0Yw/GYKc3fy1y20VSrwyjt2+hWYiAdhLrPg6eUFG+zUa18QTKw2R SzS4a5JLraNaExbKniwyRCTRLJ+3OdENs1jRkIZlWHRoMKpSCE8dOqoM0ipoGKhquUXcFT1BYdH Q X-Google-Smtp-Source: AGHT+IEAjK21OEZ9wUIwPjUiZJjyjNW7RF5oCO4O0v7fB5uBhoS7Fhz1oLlPEKG6YFAAxOrCSAZ17g== X-Received: by 2002:a05:6214:3a82:b0:6ab:8bb0:4f0b with SMTP id 6a1803df08f44-6abcd0b582bmr187102316d6.38.1717000115296; Wed, 29 May 2024 09:28:35 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ad9e066715sm10351416d6.55.2024.05.29.09.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 09:28:34 -0700 (PDT) Date: Wed, 29 May 2024 12:28:30 -0400 From: Johannes Weiner To: Christoph Hellwig Cc: Andy Shevchenko , Baolin Wang , linux-mm@kvack.org Subject: Re: page type is 3, passed migratetype is 1 (nr=512) Message-ID: <20240529162830.GA1049743@cmpxchg.org> References: <20240528164756.GA2820@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528164756.GA2820@cmpxchg.org> X-Rspam-User: X-Stat-Signature: e9o6gkndw5osnmcq6jcsb6qx43kg63he X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6F843100021 X-HE-Tag: 1717000116-957331 X-HE-Meta: U2FsdGVkX1+CGj3QC/3tbxHfkb6AIBIV78xijIFTGqfuVmSFbRie1P30JKjVYkOEpiWz36GxgxmoP0OifTgND26Gv4J8cPHpXcy1IncZA/22j2J4BLA6IlqDSnOOtBawpqaXDfC6zYXWoaqSiRzXrZkE4wG5Yme5zNoBv0nCAkIPIq7OfdY8It1mmfQGv/nR4E9sW/kvA6I5RigczJiHnAbarCvoWkT+BT7GDL+zdEjntY0q52y0JFEQnvb5/qMZ2RTEl5lGXV2DtozYveBZOvxlqMpN3FDGWG1Uj1qZKRzzx3Y6ZFvaUhiTiTkFArlTVNQtOw9eHt9jSOTVka8fltSkEsXMThFz6GCymUkDkjPaXrnPlvBo+03JapqqLwNSFzGXg0pUxRFHP84+rdfsAhkZ7fCOKji0Sa5bnlweE329lsz4ZqotfQiMHzQX+cAiEPdEafv0i5LOhAWmNZdr4gTucn+fVhVuRotHVvU3iaZ81QoTBFnstjfXAvOvtQq/14Y758TYw5mW/JrIlKR+ytG1mpwSddwrJsGhd/yVtg05F+bRIlAxxMhicaW20bsWStLc6WO36cjHPKgSbeUnOrNsbCYxDbGtVEB4XZJH+5CQTU0MNs5ul6TbRpY17h6sfd8Jf7Nq2IY0FVzGy+UXSw/DDnYDYAs5SekcrEivmzX1/Pi4ZeSxIm0K1QFidldBv2972HrNog8xDy4Rnba7TQKhpnWkU3cTetAS6ClPxvqcLpbnHv9lU1svb1ZlrUbxZtUCQ+Xtc8aDyh0s1WjmUUbeUg5QtiZVyD/mw7Rl3sKKiIU17DKeI+itFNlC5yBy5/AxDLuEjKq/SiZrw5EOoolxNmbF4ZqOr8XEtAe1rQt9vlhkSC39MXGLFj4GfQpH74yOZfCG63iBoXgLD3mRd9DtPCKzs/7hZumpQGvrLNopzRkFejUq7xIKxPFFLFteK5GZKJzD+RiD3fp+hBI uOYlrZSZ OaZmjB3N4QLf/i9AYM/0vuBDgdV0/8PSW5T9fvQwRmPMo6UwBfSqUStlM2ASE4TC7aOQ81GikFsoCeiGw6x+/Vu4EcKzhbI9pwrCtVwiowmicCb61PoqG82vW1ZIDb1/lpLHi2YCsHRZF6IENCgtMLZLNJxNe/A4dEkfB8HGVExPAiqI0c0m+vhSTCxv7/yfYCyzhtDDZLzyYDbM1TjvwF8QH84vaX/EwfBot+wzfZTxT3DJoNwCdGKEr4x6nihf1T29XyepQOBikKwqNZlBwbsHUBG1YX9jbXYiB7ko+EmGToa1lONyCnApQnl892SDfpIMF9EWbmAEDXI/S/ftjWmSFtAM1oJk8/RISX48KmCOW9hKUa6XH4y15Qc3VI+32VBFgLxhcyTSKeBC5vF/l7AIizyOM54Lqh9GLfX9yanEWOJf/eyDfjA/HGOMAM0v6FA5OfmK1D2i+55Ax5TremurhygkJp+fSgT8TqN9GYeWzYBw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for the config, I was able to reproduce it with. On Tue, May 28, 2024 at 12:48:05PM -0400, Johannes Weiner wrote: > Ah, but there DOES seem to be an issue with how we reserve > highatomics: reserving and unreserving happens one pageblock at a > time, but MAX_ORDER is usually bigger. If we rmqueue() an order-10 > request, reserve_highatomic_block() will only convert the first > order-9 block in it; the tail will remain the original type, which > will produce a buddy of mixed type blocks upon freeing. > > This doesn't fully explain the warning here. We'd expect to see it the > other way round - passing an assumed type of 3 (HIGHATOMIC) for the > remainder that is actually 1 (MOVABLE). But the pageblock-based > reservations look fishy. I'll cook up a patch to make this > range-based. It might just fix it in a way I'm not seeing just yet. tl;dr: With some debugging printks, I was able to see the issue. Should be a straight-forward fix. No order-10 allocations are necessary. Instead, smaller allocations grab blocks for the highatomic pool. Unreserving is lazy, so as those allocations get freed, they have a chance to merge together. Two adjacent highatomic blocks can merge (MAX_ORDER > pageblock_order). On unreserve, we now have an order-10 highatomic buddy, but only clear the type on the first order-9 pageblock. A subsequent alloc + expand will warn about this type inconsistency. [ 411.188518] UNRESERVE: pfn=26000 order=10 [ 411.188739] ------------[ cut here ]------------ [ 411.188881] 26200: page type is 3, passed migratetype is 1 (nr=512) [ 411.189097] WARNING: CPU: 1 PID: 10152 at mm/page_alloc.c:645 expand+0x1c8/0x1f0 I have a draft patch to make the highatomic reservations update all blocks inside the range, not just the first one. I'll send it out as soon as I have tested it properly. Thanks