Received: by 2002:a17:505:2d08:b0:1be7:c013:c773 with SMTP id xy8csp598992njc; Mon, 24 Jun 2024 23:59:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWdI/ltaQsK19IFYa/d366ARoEIMdpZiOlh9R41Vl9N4nkX7kBHqthmm07xTvqQHzL9A9eE2J8mkHZNLVJl+emPHCTSIikg X-Google-Smtp-Source: AGHT+IF8Nu8SwX7I3Ih3Fi07LSaZxk8airGqx9jl7mG5nmRCZugVQsvrf/rum906SP/zWpFD/G0h X-Received: by 2002:a0c:ac4c:0:b0:6b5:101d:201 with SMTP id 6a1803df08f44-6b53bbd2640mr71963716d6.39.1719298769688; Mon, 24 Jun 2024 23:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1719298769; cv=none; d=google.com; s=arc-20160816; b=ga+INmcfo7FJ0lDUGNJdd8lo3V3FZVNyguoTe3//820jyvkdtnmsbFbYvalWURsSuP PVJ5b53drZn5mT8yaRrLAZkSb9jtNyS/gz+b6KTf/kMNilYnuAsIEw0M2VEnh3ph0IgX kId0CIyBE4oCCFnuDN8x+dV7qIyccplz7P9i8mfEsbypP8Esy+xmufao2+7o05w+j0sD TgeY1QZ1lQkbwX8a1DuVxUfhwAzko82eulHaX2oMilTY40tVGYMnmDHAZOt5TwIFBxHI bfFyM4COzA3NOc0OYLYpJ5GWGU12Ch3m2szdErHOVsjXgVbR5s0G7sBRjCjeHKbYtBxO V5sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=B20vDn+y9X1k1NJBIFC+mmYFczc3oyCRES/8ggOE9QQ=; fh=kyMSqG9PykyTgTE4kbSSDlDxQBIdOnAflmYaysdpJC4=; b=lz9hO8/cYwRk7U8lOQO9HFDcWvStRsPJpoxStxv5537hNNXyQt5AUicQADCbw0wcpw f0dyBcf3FGvkF5SjJnIh3mDB9vueIa1iEwH7gPqy6kgwRxC5+vFP3ER9qMXZWxsovKpI ikMq3Lum1RFrLDrvI1RadBYz4taCH3Mh6g2Sqc3DvEcj8VUyrf2MwieKkgRl3GIR2QaO wzPwQ8oYZOZRNLhoPo7w/v0+VjQ/zElvtku9p1qTsdcWrBDtLtu0jgF6+LQTw8mFeN+I qz0mA0jh5BNI1rs1POEpodzuzo0qLHyViNdNbWIx7F9JDWJ19zZsZAlUBlzu8riVDAmE I4DA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="g/iUwGsb"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6b5295df072si89003256d6.432.2024.06.24.23.59.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jun 2024 23:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="g/iUwGsb"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sM08v-0006uC-Rl; Tue, 25 Jun 2024 02:59:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM08t-0006tQ-U3 for qemu-arm@nongnu.org; Tue, 25 Jun 2024 02:59:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM08s-0005lZ-2i for qemu-arm@nongnu.org; Tue, 25 Jun 2024 02:59:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719298740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B20vDn+y9X1k1NJBIFC+mmYFczc3oyCRES/8ggOE9QQ=; b=g/iUwGsbsNngkdje/YkpmuJ4rEbpUXVx57JVS3PJzdgr7zZkPMH1y5UzQYEx8pYsFAcnZD h2yCf7BZy0dMCiVjYO96ctxuDqvxEGuijW/wb+7zSn2yOCmM+JdPGFWFN88Ba72hlm6eP7 MVniQMdpboK4h/64OydS1aD/mNiIvJk= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-OLL8hd-fPFWytE2fRww-qA-1; Tue, 25 Jun 2024 02:58:54 -0400 X-MC-Unique: OLL8hd-fPFWytE2fRww-qA-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 661A919560AF; Tue, 25 Jun 2024 06:58:50 +0000 (UTC) Received: from corto.redhat.com (unknown [10.39.192.49]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0A10F3000229; Tue, 25 Jun 2024 06:58:41 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Peter Maydell , Joel Stanley , Andrew Jeffery , Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH] aspeed/sdmc: Check RAM size value at realize time Date: Tue, 25 Jun 2024 08:58:39 +0200 Message-ID: <20240625065839.485034-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.207, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: 275eRf1+rYax The RAM size of the SDMC device is validated for the SoC and set when the Aspeed machines are initialized and then later used by several SoC implementations. However, the SDMC model never checks that the RAM size has been actually set before being used. Do that at realize. Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_sdmc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index 94eed9264d09..ebf139cb5c91 100644 --- a/hw/misc/aspeed_sdmc.c +++ b/hw/misc/aspeed_sdmc.c @@ -271,6 +271,12 @@ static void aspeed_sdmc_realize(DeviceState *dev, Error **errp) AspeedSDMCClass *asc = ASPEED_SDMC_GET_CLASS(s); assert(asc->max_ram_size < 4 * GiB || asc->is_bus64bit); + + if (!s->ram_size) { + error_setg(errp, "RAM size is not set"); + return; + } + s->max_ram_size = asc->max_ram_size; memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_sdmc_ops, s, -- 2.45.2