Date: Wed, 26 Jun 2024 11:18:03 +0200 (CEST) Message-Id: <202406260918.45Q9I3TG008514@...2054...> From: Gert Doering In-Reply-To: <20240623200551.20092-1-gert@...1296...> References: <20240623200551.20092-1-gert@...1296...> Subject: [Openvpn-devel] [PATCH applied] Re: Http-proxy: fix bug preventing proxy credentials caching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Gianmarco De Gregori Cc: openvpn-devel@lists.sourceforge.net The original ACK came from Frank, I'm just ACKing the change v8 -> v10 (rebased, and add (void) to function declaration / prototypes where missing). I do not have a test setup to properly test this right now - I do have proxies, but they do not need auth, and especially the "cache on reconnect" needs a different client-side driving framework to verify client behaviour (volunteers for a t_client.sh-alike using the management interface?). But I am told that Frank and Gianmarco have tested this very extensively, and it does not break any of the things I *can* test (basic auth-user-pass and token). So in it goes :-) Your patch has been applied to the master and release/2.6 branch (bugfix). commit 3cfd6f961d5c92bec283ac3616e1633b4e16760c (master) commit ad0c2c078ea505436b19255ebfbc8365044c5953 (release/2.6) Author: Gianmarco De Gregori Date: Sun Jun 23 22:05:51 2024 +0200 Http-proxy: fix bug preventing proxy credentials caching Signed-off-by: Gianmarco De Gregori Acked-by: Gert Doering Acked-by: Frank Lichtenheld Message-Id: <20240623200551.20092-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28835.html Signed-off-by: Gert Doering -- kind regards, Gert Doering