Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55171C3DA4B for ; Fri, 12 Jul 2024 13:50:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSGfF-0004Hq-NU; Fri, 12 Jul 2024 09:50:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSGfE-0004CN-5y for qemu-riscv@nongnu.org; Fri, 12 Jul 2024 09:50:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSGfB-0003tz-6i for qemu-riscv@nongnu.org; Fri, 12 Jul 2024 09:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720792214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2kASNGbjq4n1d366GA32wJBEptT8F+YLA6Xvkmju/VM=; b=cqVnVvMZohkaqbqvBjO9/uqHl0g9nZGimNGsdQCorU7eDX5O3+lsnxF4x/mXtm64eOvUjX F26KB22cNJj2NnxCza01GgDyM/ISNoT0d8U+wkLLntFTrMBjOhBnSuAMjj+6gfo32kCjrC ubkEOtxDRtZUmf+7KHyhD0ROfDDTLjM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-JVYV0ogGNN24tVM6zfIexw-1; Fri, 12 Jul 2024 09:50:13 -0400 X-MC-Unique: JVYV0ogGNN24tVM6zfIexw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4264dc624a5so12373725e9.1 for ; Fri, 12 Jul 2024 06:50:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720792212; x=1721397012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ePkYmH/GJd4VuY3X5+BwKbbiNtXv+geAVMk56SLD1Q=; b=IW8aetBhuE+RurGWOuduWx4Iipm4/QEPVPNBEHEyuFHF5rvko0fi+fHunr9UXFMzH5 8wvVEOBykbxImZXtLqQYHQEQVdg1UNQDsa08VffsIpQFHlp9aHOq2Gt1ZT9rR9Hgk2eH yPRhi4k7WjJC7Uc6ITHMGokfh/c+qpaZWNSXie8bB4VsNPYIYA9M/ynWj7tMYxqFt/Y6 oQhTSXb/sLLIyy8iHqNbQIq6C0Rb8n0+ZiXJd1KKzsgYu+mhmRQrL6g5NGScXEHHePA9 vHAoMb+bCjEbYtiev1ehofo7GJVRXdxCwotRyljMzz+V0B7T7kzX+1/ukv2WPBhxRTK9 9vgA== X-Forwarded-Encrypted: i=1; AJvYcCUSiQgInxgKVpXwMxTH/Xu7q5QpchCYpbFSzzkGB1exb3/hLDQlWOCETbP1KrJHp9PRKGwa65NdWRUpGKhq5WZecZDsW3Q= X-Gm-Message-State: AOJu0YwKJRy5qh9lEjV/QC/ThmVtD6RrNMtpQ1fpslh4Dgg4oIG7svRp 7F+uiv1EqRaGNmzXAX9BQ1/N59kk5ItoY0FhUdrcxOaPbRC0084PP6GRBLgCf0MR0fQG5Fs1aRI M2qusKcY35gMm9C/Kku6r+X+gdP2AEhBzYTAA0qbPWpW/gR05jm3J X-Received: by 2002:a05:600c:428a:b0:426:6153:5318 with SMTP id 5b1f17b1804b1-426707e209emr71747445e9.19.1720792212149; Fri, 12 Jul 2024 06:50:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1OpAB2y3WZP9iSqV1rj32OZr6AbH2cqLalnj9oWHaSTIBaGJUZtCISUQYJHYVUbpIAt8XQA== X-Received: by 2002:a05:600c:428a:b0:426:6153:5318 with SMTP id 5b1f17b1804b1-426707e209emr71747325e9.19.1720792211760; Fri, 12 Jul 2024 06:50:11 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-426725597bdsm83977055e9.0.2024.07.12.06.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 06:50:11 -0700 (PDT) Date: Fri, 12 Jul 2024 15:50:10 +0200 From: Igor Mammedov To: "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" Cc: Sunil V L , qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , "Michael S . Tsirkin" , Ani Sinha Subject: Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates Message-ID: <20240712155010.3756bb82@imammedo.users.ipa.redhat.com> In-Reply-To: References: <20240708114741.3499585-1-sunilvl@ventanamicro.com> <20240712144319.233c19a7@imammedo.users.ipa.redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.138, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Fri, 12 Jul 2024 13:51:04 +0100 Daniel P. Berrang=C3=A9 wrote: > On Fri, Jul 12, 2024 at 02:43:19PM +0200, Igor Mammedov wrote: > > On Mon, 8 Jul 2024 17:17:32 +0530 > > Sunil V L wrote: > > =20 > > > This series adds few updates to RISC-V ACPI namespace for virt platfo= rm. > > > Additionally, it has patches to enable ACPI table testing for RISC-V. > > >=20 > > > 1) PCI Link devices need to be created outside the scope of the PCI r= oot > > > complex to ensure correct probe ordering by the OS. This matches the > > > example given in ACPI spec as well. > > >=20 > > > 2) Add PLIC and APLIC as platform devices as well to ensure probing > > > order as per BRS spec [1] requirement. > > >=20 > > > 3) BRS spec requires RISC-V to use new ACPI ID for the generic UART. = So, > > > update the HID of the UART. > > >=20 > > > 4) Enabled ACPI tables tests for RISC-V which were originally part of > > > [2] but couldn't get merged due to updates required in the expected A= ML > > > files. I think combining those patches with this series makes it easi= er > > > to merge since expected AML files are updated. > > >=20 > > > [1] - https://github.com/riscv-non-isa/riscv-brs > > > [2] - https://lists.gnu.org/archive/html/qemu-devel/2024-06/msg04734.= html =20 > >=20 > > btw: CI is not happy about series, see: > > https://gitlab.com/imammedo/qemu/-/pipelines/1371119552 > > also 'cross-i686-tci' job routinely timeouts on bios-tables-test > > but we still keep adding more tests to it. > > We should either bump timeout to account for slowness or > > disable bios-tables-test for that job. =20 >=20 > Asumming the test is functionally correct, and not hanging, then bumping > the timeout is the right answer. You can do this in the meson.build > file I think test is fine, since once in a while it passes (I guess it depends o= n runner host/load) Overal job timeout is 1h, but that's not what fails. What I see is, the test aborts after 10min timeout. it's likely we hit boot_sector_test()/acpi_find_rsdp_address_uefi() timeout= . That's what we should try to bump. PS: I've just started the job with 5min bump, lets see if it is enough. > We should never disable tests only in CI, because non-CI users > are just as likely to hit timeouts. >=20 >=20 > With regards, > Daniel