Date: Wed, 17 Jul 2024 22:01:08 +0200 (CEST) Message-Id: <202407172001.46HK18DF089250@...2054...> From: Gert Doering In-Reply-To: <20240710140623.172829-1-frank@...2641...> References: <20240710140623.172829-1-frank@...2641...> Subject: [Openvpn-devel] [PATCH applied] Re: Allow trailing \r and \n in control channel message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Arne Schwabe Cc: openvpn-devel@lists.sourceforge.net Stared at code, reviewed, and fed to my test case where the server replies with "AUTH_FAIL,you stink\r\n" - which wasn't working with the previous code (and was overlooked during testing), now works. 2024-07-17 20:54:32 AUTH: Received control message: AUTH_FAILED,you stink Also, unit tests, yay :-) Your patch has been applied to the master and release/2.6 branch (backport will be applied to 2.5). commit be31325e1dfdffbb152374985c2ae7b6644e3519 (master) commit 343573990135023d855d151fcd9248e5c26d9f8b (release/2.6) Author: Arne Schwabe Date: Wed Jul 10 16:06:23 2024 +0200 Allow trailing \r and \n in control channel message Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240710140623.172829-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28910.html Signed-off-by: Gert Doering -- kind regards, Gert Doering