Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00306C52D7F for ; Tue, 13 Aug 2024 05:09:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CE5E488966; Tue, 13 Aug 2024 07:09:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 8B479887B9; Mon, 12 Aug 2024 18:00:07 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 388FD8811C for ; Mon, 12 Aug 2024 18:00:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CA3EFEC; Mon, 12 Aug 2024 09:00:30 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB06D3F40C; Mon, 12 Aug 2024 08:59:58 -0700 (PDT) Date: Mon, 12 Aug 2024 16:59:52 +0100 From: Andre Przywara To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , Jagan Teki , AKASHI Takahiro , Alper Nebi Yasak , Andrew Davis , Andy Shevchenko , Bin Meng , Bryan Brattlof , Caleb Connolly , =?UTF-8?B?Q3PDs2vDoXM=?= Bence , Eddie James , Hans de Goede , Heinrich Schuchardt , Ilias Apalodimas , Janne Grunau , Jernej Skrabec , Jesse Taube , Joe Hershberger , Julien Masson , "Leon M. Busch-George" , Maksim Kiselev , Marek Vasut , Marek Vasut , Mattijs Korpershoek , Michael Walle , Michal Simek , Mikhail Kalashnikov , Peter Robinson , Rasmus Villemoes , Rayagonda Kokatanur , Sam Edwards , Samuel Holland , Stefan Roese , Sumit Garg , Venkatesh Yadav Abbarapu Subject: Re: [PATCH 0/6] bootstd: sunxi: Migrate to standard boot Message-ID: <20240812165952.7d0da18d@donnerap.manchester.arm.com> In-Reply-To: <20240807205032.3745680-1-sjg@chromium.org> References: <20240807205032.3745680-1-sjg@chromium.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 13 Aug 2024 07:09:50 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, 7 Aug 2024 14:50:26 -0600 Simon Glass wrote: Hey Simon, > This series attempts to migrate all sunxi boards to use standard boot, > along with a text environment. Ah, many thanks for that! I figured that we need a bootmeth for FEL, but never got around to have a closer look. On a coarse glance, this looks roughly OK, and doing a super quick boot test on one board, it seems to still work(TM), though the priority of the FEL boot is not right? And I guess ditching the old kernel support might be a bit controversial. I think this is about the vendor kernels, which some people still rely on? I will have a closer look this week and give you a review, just wanted to acknowledge the series and thank you for your efforts. Cheers, Andre > Simon Glass (6): > sunxi: Drop BOOTCMD_SUNXI_COMPAT > sunxi: Add a bootmeth for FEL > sunxi: Move to bootstd > sunxi: Drop old distro boot variables > env: Provide a work-around for unquoting fdtfile > sunxi: Move to text environment > > Makefile | 1 + > arch/arm/Kconfig | 2 +- > arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 10 - > arch/arm/mach-sunxi/Kconfig | 12 - > arch/arm/mach-sunxi/dram_sun4i.c | 4 - > board/sunxi/sunxi.env | 138 ++++++++++ > boot/Kconfig | 14 ++ > boot/Makefile | 1 + > boot/bootmeth_fel.c | 81 ++++++ > configs/icnova-a20-swac_defconfig | 1 - > doc/usage/environment.rst | 12 + > include/configs/sunxi-common.h | 238 ------------------ > 12 files changed, 248 insertions(+), 266 deletions(-) > create mode 100644 board/sunxi/sunxi.env > create mode 100644 boot/bootmeth_fel.c >