Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA051AD9D6 for ; Wed, 14 Aug 2024 13:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723643890; cv=none; b=fobgNSLVz9au+cBgSpk7dhI/FYsb5wUGgnlk2xONeuik+/SPOP9Z7Iua2FhDkRKNL6am35FSf4CrgEFoq4BpqtCRugtQ4GAL61mNIHcgrf/LAUo2KC1gX/HXE4YsKNyRDa6g7/ttrxiwTEzeL9yrzSAXeK0HaGbvrFO6iqE3jCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723643890; c=relaxed/simple; bh=kSJFC2VmE7KmnBPMWvclousP1yPJR/j1GOsDlAg7+Vo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rlhrkyzk75LWRcpsoWZpTMFkRmC2yDC/CJj5NLFak0/GUg0IzaK2/rToTEizRVxATbaOaPxfbxfR+BrsOMxJAPvfTwmfmQHpBHFYStxfVjk/mdSmQEU7Zkg9lZBxjKF5gNCZJykUM5+yYZ7rr8Tb+W70kjgh/SeevIbawV0Tca0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=lZg084vS; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lZg084vS" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B30CC66F; Wed, 14 Aug 2024 15:57:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1723643829; bh=kSJFC2VmE7KmnBPMWvclousP1yPJR/j1GOsDlAg7+Vo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lZg084vS/YZKTGhrZGKqmUsco/kTKYmxRyAsezoT183EMt7ous2+c7ZnVjKXosdAc vw7BElmoJqAlTcAbsDJnqG3eOEjdo9uiW3aKTTWcWL90aV5cgDvTzd3cKRrL2xD4vi 6u/c0voJg4HVXk+KYEcAidYZxrYDny3Y5Dx43ZD4= Date: Wed, 14 Aug 2024 16:57:42 +0300 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [GIT PULL FOR v6.12] rkisp1 extensible parameters format Message-ID: <20240814135742.GA3299@pendragon.ideasonboard.com> References: <20240812230545.GA2358@pendragon.ideasonboard.com> <70262640-21eb-452a-a24d-783b4bcd8d54@xs4all.nl> <20240814131915.GB26073@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240814131915.GB26073@pendragon.ideasonboard.com> On Wed, Aug 14, 2024 at 04:19:15PM +0300, Laurent Pinchart wrote: > On Wed, Aug 14, 2024 at 12:02:39PM +0200, Hans Verkuil wrote: > > On 13/08/2024 01:05, Laurent Pinchart wrote: > > > Hi Hans, Mauro, > > > > commit 5ef3fcc8e42b43523498c7b0ede19a47fbdf8353 (media: rkisp1: Implement extensible params support) > > failed to push because the commit log contains a local changelog: > > > > ... > > Implement parameter buffer validation for the extensible format at > > .buf_prepare() time. > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Laurent Pinchart > > Reviewed-by: Jacopo Mondi > > Reviewed-by: Paul Elder > > Tested-by: Kieran Bingham > > Acked-by: Sakari Ailus > > Signed-off-by: Laurent Pinchart > > --- > > Changes since v10: > > > > - Use %zu to print size_t arguments > > > > I can either just take these patches (i.e. I don't merge them), and manually remove > > this before committing, or you need to update your tree yourself. > > > > If you decide to do the latter, then please add my: > > > > Reviewed-by: Hans Verkuil > > > > to patches 2 and 3 (uAPI changes). > > Oooops. I'll resend now. I wonder how I didn't notice that. Pull request resent, and local scripts updated to make sure this won't happen again. > > > > > > The following changes since commit c80bfa4f9e0ebfce6ac909488d412347acbcb4f9: > > > > > > media: ti: cal: use 'time_left' variable with wait_event_timeout() (2024-08-09 07:56:39 +0200) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/next-media-rkisp1-20240813 > > > > > > for you to fetch changes up to 32be6029c1c1e8c628077403b2096e9d9085f6c8: > > > > > > media: rkisp1: Add support for the companding block (2024-08-12 13:36:50 +0300) > > > > > > ---------------------------------------------------------------- > > > Extensible parameters support for the rkisp1 driver > > > > > > ---------------------------------------------------------------- > > > Jacopo Mondi (7): > > > media: uapi: rkisp1-config: Add extensible params format > > > media: uapi: videodev2: Add V4L2_META_FMT_RK_ISP1_EXT_PARAMS > > > media: rkisp1: Add struct rkisp1_params_buffer > > > media: rkisp1: Copy the parameters buffer > > > media: rkisp1: Cache the currently active format > > > media: rkisp1: Implement extensible params support > > > media: rkisp1: Implement s_fmt/try_fmt > > > > > > Laurent Pinchart (2): > > > media: rkisp1: Add helper function to swap colour channels > > > media: rkisp1: Add features mask to extensible block handlers > > > > > > Ondrej Jirman (1): > > > media: rkisp1: Adapt to different SoCs having different size limits > > > > > > Paul Elder (3): > > > media: rkisp1: Add register definitions for the companding block > > > media: rkisp1: Add feature flags for BLS and compand > > > media: rkisp1: Add support for the companding block > > > > > > Documentation/admin-guide/media/rkisp1.rst | 11 +- > > > .../userspace-api/media/v4l/metafmt-rkisp1.rst | 57 +- > > > .../media/platform/rockchip/rkisp1/rkisp1-common.c | 14 + > > > .../media/platform/rockchip/rkisp1/rkisp1-common.h | 49 +- > > > .../media/platform/rockchip/rkisp1/rkisp1-csi.c | 5 +- > > > .../media/platform/rockchip/rkisp1/rkisp1-dev.c | 15 +- > > > .../media/platform/rockchip/rkisp1/rkisp1-isp.c | 9 +- > > > .../media/platform/rockchip/rkisp1/rkisp1-params.c | 1037 ++++++++++++++++++-- > > > .../media/platform/rockchip/rkisp1/rkisp1-regs.h | 23 + > > > .../platform/rockchip/rkisp1/rkisp1-resizer.c | 4 +- > > > .../media/platform/rockchip/rkisp1/rkisp1-stats.c | 51 +- > > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > > include/uapi/linux/rkisp1-config.h | 578 +++++++++++ > > > include/uapi/linux/videodev2.h | 1 + > > > 14 files changed, 1689 insertions(+), 166 deletions(-) -- Regards, Laurent Pinchart