Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97422CA0EED for ; Fri, 30 Aug 2024 08:28:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3603040AFB; Fri, 30 Aug 2024 08:28:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id H9tlFYnv0NG8; Fri, 30 Aug 2024 08:28:56 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0D3A2410F3 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 0D3A2410F3; Fri, 30 Aug 2024 08:28:56 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id E32051BF844 for ; Fri, 30 Aug 2024 08:28:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DE2E1611F1 for ; Fri, 30 Aug 2024 08:28:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id YWhTNaRIRRxr for ; Fri, 30 Aug 2024 08:28:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.178.240; helo=mslow1.mail.gandi.net; envelope-from=peko@48ers.dk; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 730B060797 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 730B060797 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by smtp3.osuosl.org (Postfix) with ESMTPS id 730B060797 for ; Fri, 30 Aug 2024 08:28:51 +0000 (UTC) Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 19814C89C2 for ; Fri, 30 Aug 2024 08:27:38 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2F1C7C0002; Fri, 30 Aug 2024 08:27:30 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1sjwyg-007x5q-1g; Fri, 30 Aug 2024 10:27:30 +0200 From: Peter Korsgaard To: buildroot@buildroot.org Date: Fri, 30 Aug 2024 10:26:49 +0200 Message-Id: <20240830082650.1895430-1-peter@korsgaard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-GND-Sasl: peter@korsgaard.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Subject: [Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Commit 6889056f1eb4 (support/scripts/genimage.sh: support creating a bmap image) added unconditional gzip compression of the genimage outputs if bmap-tools is enabled, which is problematic for a number of reasons: - The gzip invocation is not reproducable (E.G. does not use -n) - The original file is removed, dropping the sparse info - It hardcodes policy, E.G. bmap supports a number of different compression algorithms / compression may not be desired for all images / different compression levels may be desired So drop the compression step. If desired, compression can be done with a post-image script. Signed-off-by: Peter Korsgaard --- support/scripts/genimage.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/support/scripts/genimage.sh b/support/scripts/genimage.sh index b479ec9e0b..df224241ab 100755 --- a/support/scripts/genimage.sh +++ b/support/scripts/genimage.sh @@ -54,6 +54,5 @@ if grep -Eq "^BR2_PACKAGE_HOST_BMAP_TOOLS=y$" "${BR2_CONFIG}"; then continue fi bmaptool create "${image_path}" -o "${image_path}.bmap" - gzip -c "${image_path}" > "${image_path}.gz" done < <(grep '^image ' "${GENIMAGE_CFG}" | cut -d ' ' -f 2) fi -- 2.39.2 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot