Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C631C6882 for ; Tue, 19 Nov 2024 10:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732011569; cv=none; b=fHMw3+xrjFD/kn4cCTnv9CwNI+ruXEBGjYTxWpT55v6iU/7jXgqZMa7OhmP+gEONRGgpx5ekDKM5BN+YLqS94u7gtdP9deg0Nzw46CQASr7jKU/QuTKPREwK5mk9dpECI7MoySGg9Vcb3otOtO11BVeQ812llcSvVADQrHkj98E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732011569; c=relaxed/simple; bh=KS/BSXKwODiNlM345SD1MVSJzHQruZ4MhHPY3AhQs7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kh2U4ZkkDj7OxO1lYI95/aHpULGeDdoZ4wFNgQQn0YUnyJWC9CImzr2QBOczBunhmISJsvApeICgR3YlMRzz/Xa4itgKu2/xIwuhbdOrKoFgOciHDfPD2YFUBnE9rgrdNy7tP/sxgk2VlxxLPgiB7BUwVDPiEJq5EOEBUwOR0Ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OIBfAaje; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OIBfAaje" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2feeb1e8edfso39290681fa.1 for ; Tue, 19 Nov 2024 02:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732011565; x=1732616365; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3IFIJoTYk6YKRTRNHwxftMTYmZfYo4cB7iVfLaoFmHE=; b=OIBfAajeBatC68AovSig3MlhoLJKqHBO4w+dx008k3levuIculoZ/Qp0X37uQQLVvu CLhTDPYKCdl4IVFe/8HBn9RG/ob1A281Km6lIV4uKNfOgYF6ada53kuEL5VcXVyN65jU BFEZC0/SL9Qti/XnNRVI9YiMYHzJQTJCLgIxJgJ5o/3meDhoGRJhakMJ3Mqm/Tu0yRlF fMf0FyGVoQT8FKHSrokZ/y7tzkqgcI9Z5p0sypbYXZ93Hx6z5dTPW+sN5kbZI+85z+6H fU3AeoA/YUuAEvdH5pGqiRnJycyGRWkKdfF1D3X+SUYvWG+rnDUUeffS3VJIfK3Tim+p 3eyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732011565; x=1732616365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3IFIJoTYk6YKRTRNHwxftMTYmZfYo4cB7iVfLaoFmHE=; b=Sh41LGQmqmn4oYWGFGTPh0hDiop6O68iULYRJ8sRkDVkJHRvMU9JQA+e67M/WuyzLq 3FAac5pRUoKqWr654Le02b0fVuX0P83h4CJ1FybzIqKx0S5MLLpMgJysKxhlgJPk8OgM YCYOcGXGvLDL0GvxKrGTNWFhIHSm4yodTIs/93QKL0EzyHe70dEqCXbXcadXUJ2qzaR5 kpouU+LMCQAMwlVVWn4WwiA/IJ5yX0bdA/IaTsWV7URtlvzG2CokjU4dCDAE01wn9BaL o1u2mbmHtMdFHE7sI/y/IzfQ8uFCVUZkFI8ErZ5YxleNHG6ivD0yXA6pRspOLDbk/IHY 3V4w== X-Forwarded-Encrypted: i=1; AJvYcCU+wVpkwEiuo0WwUYpE9FNTuIMCI8xwEqLQC3gBkad4dTUlQY4hh6EgeAkKhdhyiMpMVmcnY9w=@lists.linux.dev X-Gm-Message-State: AOJu0YxG6EtbDb3chV1LLwJG8JxWGT2uwY5iq7k032g9ZQjEl3u7WMeI eRA12YmR5v0jfmwQdugn5IlSt/V5WV4NXkf5juqMe6WNJrCYTdfl X-Google-Smtp-Source: AGHT+IHnkAmZBG6E9wO/q7BJvCC5UomYmpRer3uAt1HmEjIcUorcDjARLDEPuztshHFwg7HC5D+dGA== X-Received: by 2002:a05:6512:32c9:b0:52e:fa5f:b6a7 with SMTP id 2adb3069b0e04-53dab29e907mr9290473e87.13.1732011565255; Tue, 19 Nov 2024 02:19:25 -0800 (PST) Received: from corebook.localdomain (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl. [2001:1c00:20d:1300:1b1c:4449:176a:89ea]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20e081574sm634875566b.179.2024.11.19.02.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 02:19:24 -0800 (PST) From: Eric Woudstra To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Pablo Neira Ayuso , Jozsef Kadlecsik , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Matthias Brugger , AngeloGioacchino Del Regno , David Ahern , Sebastian Andrzej Siewior , Lorenzo Bianconi , Joe Damato , Alexander Lobakin , Vladimir Oltean , "Frank Wunderlich" , Daniel Golle Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Eric Woudstra Subject: [PATCH RFC v2 net-next 05/14] bridge: br_fill_forward_path add port to port Date: Tue, 19 Nov 2024 11:18:57 +0100 Message-ID: <20241119101906.862680-6-ericwouds@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241119101906.862680-1-ericwouds@gmail.com> References: <20241119101906.862680-1-ericwouds@gmail.com> Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If handed a bridge port, use the bridge master to fill the forward path. Signed-off-by: Eric Woudstra --- net/bridge/br_device.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 0ab4613aa07a..c7646afc8b96 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -383,16 +383,25 @@ static int br_del_slave(struct net_device *dev, struct net_device *slave_dev) static int br_fill_forward_path(struct net_device_path_ctx *ctx, struct net_device_path *path) { + struct net_bridge_port *src, *dst; struct net_bridge_fdb_entry *f; - struct net_bridge_port *dst; struct net_bridge *br; - if (netif_is_bridge_port(ctx->dev)) - return -1; + if (netif_is_bridge_port(ctx->dev)) { + struct net_device *br_dev; + + br_dev = netdev_master_upper_dev_get_rcu((struct net_device *)ctx->dev); + if (!br_dev) + return -1; - br = netdev_priv(ctx->dev); + src = br_port_get_rcu(ctx->dev); + br = netdev_priv(br_dev); + } else { + src = NULL; + br = netdev_priv(ctx->dev); + } - br_vlan_fill_forward_path_pvid(br, ctx, path); + br_vlan_fill_forward_path_pvid(br, src, ctx, path); f = br_fdb_find_rcu(br, ctx->daddr, path->bridge.vlan_id); if (!f) -- 2.45.2