Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D3D2D6E2DE for ; Wed, 20 Nov 2024 09:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=BXjGol7kpG8D2fvIcEFqh4TGvl F+5uSR4xfhIdkyo1DJBvMTjgJqoLqaQK5ikN/N2mSb79pOfbCd86Y5A627dky0UC7kJf1MtN1ddz+ 65ctT90SX1OcOcOB5BqkzYUdOZD0zi5kgspbD3WZ80x3gC9/itmYwwLtQXUqndD/SzkWKoEhUg/zL He001STFF1NkKaRqwKD43mzXLZmzVLrdar5FMOpzBUMA7xgxCdcSA/hHKxlOoBw3K+p0IiDpsTvvw KTeaahj73QF7RU9iXSxQ67jHF4/WRCHkaumSPtg8RQirSV3qgu6mbsvGDpRax7ecx/Vb1AXU++Yda Q5651ptQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tDggq-0000000Er8T-0s4W; Wed, 20 Nov 2024 09:08:00 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tDgg8-0000000Er2V-3Yz5 for linux-nvme@lists.infradead.org; Wed, 20 Nov 2024 09:07:18 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AB38668D8D; Wed, 20 Nov 2024 10:07:12 +0100 (CET) Date: Wed, 20 Nov 2024 10:07:12 +0100 From: Christoph Hellwig To: Guixin Liu Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH v2 2/2] nvme: tuning pr code by using defined structs and macros Message-ID: <20241120090712.GB16607@lst.de> References: <20241120071008.106933-1-kanie@linux.alibaba.com> <20241120071008.106933-3-kanie@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241120071008.106933-3-kanie@linux.alibaba.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241120_010717_021316_97B64A66 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Looks good: Reviewed-by: Christoph Hellwig