Received: by 2002:a17:505:a0c:b0:1be9:327d:8ee3 with SMTP id cg12csp771138njb; Fri, 6 Dec 2024 03:24:26 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWkzlcqre2uRIsA3prdMiRVIxAuMqU/4mFAicOuO5bJP7IXrZxJXrgxZT6sYaCh4SfteZdMALQ0fmISbw==@linaro.org X-Google-Smtp-Source: AGHT+IG4104WKD5Fmt1hCV6/cCK9Ro0IS1zsRXypWcADMZIDecyEqGtHfEjlIY7UsVznLPe5x8oc X-Received: by 2002:a05:620a:40c8:b0:7b1:4547:4910 with SMTP id af79cd13be357-7b6bcad4ef6mr390767885a.20.1733484266693; Fri, 06 Dec 2024 03:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733484266; cv=none; d=google.com; s=arc-20240605; b=lgjwc/srX17Rq6+I0lVJf/drVzxPsT4NEwCO4JDRta89J8ivfDmtJ8/feJ5otEOY6m l/ALQDJsVmEBhpBW6yH9PyuQxs6QhKorX/gfLkPExd2s1JKzB+qQ71EomZb39Dafe7pV je403VP5w/vac7GpHi67sT1UP4yK8x4xIBXI8jX3NptRmgjFnpf7eUqLdDNXZjn++mpn 9rQxRZNtlHegX928sjAglEWeVUdZV+dHM/oMAWczMpkfMofRzayhLjzG13/P+vPf1HmS cn9EglZQ1g1t5L2vYlLI9tRf4dP8vmZukDmondA2wS7BhapKcl9UbbO3GvQRnXK82OC3 df2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=CwDEa/NM4JWEHnIyr/wEI1Tuog1STukmc+A4+IQhB28=; fh=ou9WwAWkFbBDtrYluijzdFLlSJKncehGww8dMC2w/x0=; b=Bq1SlxQmLVqm18xXm3GGAXKwXx+PVel5392UPV+U/mmWE1yFKNT3mPQOk4GjsBfGp0 oZUm1eOX7bldOV5EERbQol044bgD3QZnQqWR3ieHIi0kbzjQ1oGqE83hD3Puhf49U2YI xi+apeTB4Z0RS5xpkwGoajDo9YwioPFNEXUh5tf4tNSoeVgoDdGG7I+Lr1YAnvrzasrC 6LjGMBvsbhXcELmXeDVpL2Vd7dnSd/4ZnUuZ5mouDfSlV19dQzXUiiUEwrfqwkefIgJK d9X0FjFydjWcMMXdI2cOT+4odrBRgxTjgvuT1LjTdPjVfvettyWLD1Hzrtefb1055SuX DBWA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="RrQBHF/D"; spf=pass (google.com: domain of cohuck@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=cohuck@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.129.124]) by mx.google.com with ESMTPS id 6a1803df08f44-6d8f0faa9fesi4941786d6.395.2024.12.06.03.24.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 03:24:26 -0800 (PST) Received-SPF: pass (google.com: domain of cohuck@redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="RrQBHF/D"; spf=pass (google.com: domain of cohuck@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=cohuck@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733484266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwDEa/NM4JWEHnIyr/wEI1Tuog1STukmc+A4+IQhB28=; b=RrQBHF/DBCdXht0UJfdcAIWUFHh/chDfgLwR4MCYUggibc8ddGepgGPOcQy/q4ssyjYtY0 W5WHlZqL5G9MAFEuLlB8IGuC7Yryt8BuQhY2/xIBtV+UtU5J/L9fJGmP/zWy+vaNe3McBZ gZ8Eb39h4eQ9IJGmpvvKyHwK/KOz+lc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-tGUj8UmNOsyMloaSm7kzhQ-1; Fri, 06 Dec 2024 06:24:23 -0500 X-MC-Unique: tGUj8UmNOsyMloaSm7kzhQ-1 X-Mimecast-MFC-AGG-ID: tGUj8UmNOsyMloaSm7kzhQ Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3C2FA19560A7; Fri, 6 Dec 2024 11:24:21 +0000 (UTC) Received: from gondolin.str.redhat.com (dhcp-192-244.str.redhat.com [10.33.192.244]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F361319560A2; Fri, 6 Dec 2024 11:24:15 +0000 (UTC) From: Cornelia Huck To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, peter.maydell@linaro.org, richard.henderson@linaro.org, alex.bennee@linaro.org, maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com, shameerali.kolothum.thodi@huawei.com, armbru@redhat.com, berrange@redhat.com, abologna@redhat.com, jdenemar@redhat.com Cc: shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org, pbonzini@redhat.com, Cornelia Huck Subject: [PATCH RFCv2 19/20] arm-qmp-cmds: introspection for ID register props Date: Fri, 6 Dec 2024 12:22:12 +0100 Message-ID: <20241206112213.88394-20-cohuck@redhat.com> In-Reply-To: <20241206112213.88394-1-cohuck@redhat.com> References: <20241206112213.88394-1-cohuck@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-TUID: 3jAKRzE7wOpk Implement the capability to query available ID register values by adding SYSREG_* options and values to the cpu model expansion for the host model, if available. Excerpt: (QEMU) query-cpu-model-expansion type=full model={"name":"host"} {"return": {"model": {"name": "host", "props": {"SYSREG_ID_AA64PFR0_EL1_EL3": 1224979098931106066, "SYSREG_ID_AA64ISAR2_EL1_CLRBHB": 0, ../.. So this allows the upper stack to detect available writable ID regs and the "host passthrough model" values. [CH: moved SYSREG_* values to host model] Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- TODO: Add the moment there is no way to test changing a given ID reg field value. ie: (QEMU) query-cpu-model-expansion type=full model={"name":"host", "prop":{"SYSREG_ID_AA64ISAR0_EL1_DP":0x13}} --- target/arm/arm-qmp-cmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/target/arm/arm-qmp-cmds.c b/target/arm/arm-qmp-cmds.c index 3cc8cc738bb0..44d7bf4c80ce 100644 --- a/target/arm/arm-qmp-cmds.c +++ b/target/arm/arm-qmp-cmds.c @@ -21,6 +21,7 @@ */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/boards.h" #include "kvm_arm.h" #include "qapi/error.h" @@ -209,6 +210,24 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type, } } + /* If writable ID regs are supported, add them as well */ + if (ARM_CPU(obj)->writable_id_regs == WRITABLE_ID_REGS_AVAIL) { + ObjectProperty *prop; + ObjectPropertyIterator iter; + + object_property_iter_init(&iter, obj); + + while ((prop = object_property_iter_next(&iter))) { + QObject *value; + + if (!g_str_has_prefix(prop->name, "SYSREG_")) { + continue; + } + value = object_property_get_qobject(obj, prop->name, &error_abort); + qdict_put_obj(qdict_out, prop->name, value); + } + } + if (!qdict_size(qdict_out)) { qobject_unref(qdict_out); } else { -- 2.47.0