Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46A4139B for ; Fri, 3 Jan 2025 00:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735863098; cv=none; b=QpEmOQdzPzfhuiqXu7lqfZagXqe8INlOnVpHZ+A4NhZO0vSnlCyS/UMYw0RvOA6RexKAgF81dc6iNGI3jZUGamUsr5l5G1qO+zAVXlUHbuBd0CatGXkRXVxH881UFBuzKoynLKSvfpTlMk6cp8TiqDTEsZJj9OtKMquQfEQruXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735863098; c=relaxed/simple; bh=wMqAwK0nq45Hp4HF78nF6evAYeaw+Zn1gwTDuPGpsJ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ThcBuXa8gHLwEYMIJDySEzSsrwFl98k/x6eyp5X3kBy9QunnrSMUePhPr9Simz6yYMGGtgSP8OSaSuw1bVdZ3eHtjmznSQRlRwYUHd93V/mhaiwKr0xiykF1kaI+WDxCa4tYuwGe5++KrIiCdB4DRM6YSG2ZKGx3pxKPTtGmac0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PBw+kl6p; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PBw+kl6p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735863097; x=1767399097; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wMqAwK0nq45Hp4HF78nF6evAYeaw+Zn1gwTDuPGpsJ4=; b=PBw+kl6pucROJcBBZx1V2uKmwp/+Vla4EHYHFw0d53L12D+57Rg8vuqN rDE03Uhrzo2xSJWVUTXiwHKeSOJ0WNVlwvL+gcAQTZyjsFppHyp13WFDW zQZJcCRT984TS0m1pZLnoNNmmQuaMmDYC1v0mW+cuQ0Uep1MhodAJ5IZw jSFL3okkhZaZR6ZFMv7HVjl3Z3tbYFwt5OsTEPG+RaGl9QI9rCd602k23 1bxt7blpxtwQe7hPIqc7SrJd9uM6kB6Wtw1mxoo233X+Ptv+iYxHH/OMg wDcoipykBs3neuKn5b2B9fAqjT5dGvGMsH99rgsv6nqIgdpdSIhKaMyJ4 A==; X-CSE-ConnectionGUID: bjuertDDSQyc+FwnLFSxLw== X-CSE-MsgGUID: +QejpIZzRCm3rq3+wO1pmQ== X-IronPort-AV: E=McAfee;i="6700,10204,11303"; a="39880786" X-IronPort-AV: E=Sophos;i="6.12,286,1728975600"; d="scan'208";a="39880786" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2025 16:11:36 -0800 X-CSE-ConnectionGUID: r0a2gy3GSuGghQa6Uv0AWQ== X-CSE-MsgGUID: RoX/KFJbR42VPzN+hxbaPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,286,1728975600"; d="scan'208";a="106620328" Received: from lkp-server01.sh.intel.com (HELO d63d4d77d921) ([10.239.97.150]) by orviesa004.jf.intel.com with ESMTP; 02 Jan 2025 16:11:35 -0800 Received: from kbuild by d63d4d77d921 with local (Exim 4.96) (envelope-from ) id 1tTVHo-0008z1-31; Fri, 03 Jan 2025 00:11:32 +0000 Date: Fri, 3 Jan 2025 08:10:56 +0800 From: kernel test robot To: Atharva Tiwari Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH] i2c: amd756: Fix endianness handling for word data Message-ID: <202501030846.g3CT2W73-lkp@intel.com> References: <20250101103422.30523-1-evepolonium@gmail.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250101103422.30523-1-evepolonium@gmail.com> Hi Atharva, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.13-rc5] [also build test WARNING on linus/master next-20241220] [cannot apply to andi-shyti/i2c/i2c-host] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Atharva-Tiwari/i2c-amd756-Fix-endianness-handling-for-word-data/20250101-183620 base: v6.13-rc5 patch link: https://lore.kernel.org/r/20250101103422.30523-1-evepolonium%40gmail.com patch subject: [PATCH] i2c: amd756: Fix endianness handling for word data config: sparc64-randconfig-r132-20250103 (https://download.01.org/0day-ci/archive/20250103/202501030846.g3CT2W73-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 14.2.0 reproduce: (https://download.01.org/0day-ci/archive/20250103/202501030846.g3CT2W73-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202501030846.g3CT2W73-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/i2c/busses/i2c-amd756.c:215:25: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] w @@ got restricted __le16 [usertype] @@ drivers/i2c/busses/i2c-amd756.c:215:25: sparse: expected unsigned short [usertype] w drivers/i2c/busses/i2c-amd756.c:215:25: sparse: got restricted __le16 [usertype] drivers/i2c/busses/i2c-amd756.c:260:35: sparse: sparse: cast to restricted __le16 drivers/i2c/busses/i2c-amd756.c:260:35: sparse: sparse: cast to restricted __le16 drivers/i2c/busses/i2c-amd756.c:260:35: sparse: sparse: cast to restricted __le16 drivers/i2c/busses/i2c-amd756.c:260:35: sparse: sparse: cast to restricted __le16 vim +215 drivers/i2c/busses/i2c-amd756.c 180 181 /* Return negative errno on error. */ 182 static s32 amd756_access(struct i2c_adapter * adap, u16 addr, 183 unsigned short flags, char read_write, 184 u8 command, int size, union i2c_smbus_data * data) 185 { 186 int i, len; 187 int status; 188 189 switch (size) { 190 case I2C_SMBUS_QUICK: 191 outw_p(((addr & 0x7f) << 1) | (read_write & 0x01), 192 SMB_HOST_ADDRESS); 193 size = AMD756_QUICK; 194 break; 195 case I2C_SMBUS_BYTE: 196 outw_p(((addr & 0x7f) << 1) | (read_write & 0x01), 197 SMB_HOST_ADDRESS); 198 if (read_write == I2C_SMBUS_WRITE) 199 outb_p(command, SMB_HOST_DATA); 200 size = AMD756_BYTE; 201 break; 202 case I2C_SMBUS_BYTE_DATA: 203 outw_p(((addr & 0x7f) << 1) | (read_write & 0x01), 204 SMB_HOST_ADDRESS); 205 outb_p(command, SMB_HOST_COMMAND); 206 if (read_write == I2C_SMBUS_WRITE) 207 outw_p(data->byte, SMB_HOST_DATA); 208 size = AMD756_BYTE_DATA; 209 break; 210 case I2C_SMBUS_WORD_DATA: 211 outw_p(((addr & 0x7f) << 1) | (read_write & 0x01), 212 SMB_HOST_ADDRESS); 213 outb_p(command, SMB_HOST_COMMAND); 214 if (read_write == I2C_SMBUS_WRITE) > 215 outw_p(cpu_to_le16((u16)data->word), SMB_HOST_DATA); 216 size = AMD756_WORD_DATA; 217 break; 218 case I2C_SMBUS_BLOCK_DATA: 219 outw_p(((addr & 0x7f) << 1) | (read_write & 0x01), 220 SMB_HOST_ADDRESS); 221 outb_p(command, SMB_HOST_COMMAND); 222 if (read_write == I2C_SMBUS_WRITE) { 223 len = data->block[0]; 224 if (len < 0) 225 len = 0; 226 if (len > 32) 227 len = 32; 228 outw_p(len, SMB_HOST_DATA); 229 /* i = inw_p(SMBHSTCNT); Reset SMBBLKDAT */ 230 for (i = 1; i <= len; i++) 231 outb_p(data->block[i], 232 SMB_HOST_BLOCK_DATA); 233 } 234 size = AMD756_BLOCK_DATA; 235 break; 236 default: 237 dev_warn(&adap->dev, "Unsupported transaction %d\n", size); 238 return -EOPNOTSUPP; 239 } 240 241 /* How about enabling interrupts... */ 242 outw_p(size & GE_CYC_TYPE_MASK, SMB_GLOBAL_ENABLE); 243 244 status = amd756_transaction(adap); 245 if (status) 246 return status; 247 248 if ((read_write == I2C_SMBUS_WRITE) || (size == AMD756_QUICK)) 249 return 0; 250 251 252 switch (size) { 253 case AMD756_BYTE: 254 data->byte = inw_p(SMB_HOST_DATA); 255 break; 256 case AMD756_BYTE_DATA: 257 data->byte = inw_p(SMB_HOST_DATA); 258 break; 259 case AMD756_WORD_DATA: 260 data->word = (u16)le16_to_cpu(inw_p(SMB_HOST_DATA)); 261 break; 262 case AMD756_BLOCK_DATA: 263 data->block[0] = inw_p(SMB_HOST_DATA) & 0x3f; 264 if(data->block[0] > 32) 265 data->block[0] = 32; 266 /* i = inw_p(SMBHSTCNT); Reset SMBBLKDAT */ 267 for (i = 1; i <= data->block[0]; i++) 268 data->block[i] = inb_p(SMB_HOST_BLOCK_DATA); 269 break; 270 } 271 272 return 0; 273 } 274 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki