Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53F03E7719A for ; Fri, 10 Jan 2025 03:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:content-type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z7mGlKvKy5SqZStSpEOrC66l/cJcotrJit7imygcRDE=; b=G/HbuV1OiQwb1cBYm3nEgcFQeP +jpcdB2KMgAkmkB/nvx4X6ocwfZBixc81zA0n8+rDe2YfGYqRjSJDrH//iOlcp3pQb/GuIr+pDtIE +4oxaIOZohRCpntE36b63nqt7YD5aRgt2CrZ9yUgVLj4fM+GvaMjOrFdWTmB1OPclE3xIYQyZG/0x AgRwkxYcatOSqjLXKte01w469OFiBkx3Tk19jbeVgapigvUWuMvUAIjxnOKr/7OCk2pZnfqYj5Dcu nb5wvcogzjMv1hHFt8OpbHa16KOKi+5a99p30kerIJiXcdOCogofb/8PYltpww3IKDMsYagBxpa3p GyH83Ojw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tW5HD-0000000DsjO-0LxL; Fri, 10 Jan 2025 03:01:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tW5HA-0000000Dshn-1K1O for kexec@lists.infradead.org; Fri, 10 Jan 2025 03:01:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736478091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7mGlKvKy5SqZStSpEOrC66l/cJcotrJit7imygcRDE=; b=KpLqZRGfOoBryFLF9aSVbcPo89isdiKmx+g2kMudHrj2xfn3Sybzfq5Ylrppy/BXLrqVVy Rdj7MlRqiKflMaUFQJK/o0m7TP86eMjJ9b16pThgtWybAh2tsjVZTiTquOdUVAWdyef2QL zHNshBetOznEpfEreouQYBLIQkg9R9M= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-0UOncpVLOW6PaiQLCvU0wQ-1; Thu, 09 Jan 2025 22:01:30 -0500 X-MC-Unique: 0UOncpVLOW6PaiQLCvU0wQ-1 X-Mimecast-MFC-AGG-ID: 0UOncpVLOW6PaiQLCvU0wQ Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1834619560A3; Fri, 10 Jan 2025 03:01:29 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.88.21]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 303631955BE3; Fri, 10 Jan 2025 03:01:26 +0000 (UTC) From: Seiji Nishikawa To: yamazaki-msmt@nec.com, k-hagio-ab@nec.com Cc: kexec@lists.infradead.org, snishika@redhat.com Subject: [PATCH] Improve message readability and fix typos Date: Fri, 10 Jan 2025 12:00:47 +0900 Message-ID: <20250110030047.73538-2-snishika@redhat.com> In-Reply-To: <20250110030047.73538-1-snishika@redhat.com> References: <20250110030047.73538-1-snishika@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: P3-nnOESeJaSptTeu0Pm1JgVHfNizcD1zvg_0g0hNuc_1736478089 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250109_190132_414395_0CFC3AEF X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org This patch enhances the readability of several messages printed by adding a space after a comma that is not followed by a newline. These changes ensure that messages are easier to read and understand. For example: Before: "The kernel doesn't support mmap(),read() will be used instead." After: "The kernel doesn't support mmap(), read() will be used instead." Additionally, this patch fixes minor typos in the messages, further improving clarity and correctness. Signed-off-by: Seiji Nishikawa --- makedumpfile.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/makedumpfile.c b/makedumpfile.c index bad3c48..2d3b08b 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -4444,7 +4444,7 @@ initial(void) #endif if (info->flag_exclude_xen_dom && !is_xen_memory()) { - MSG("'-X' option is disable,"); + MSG("'-X' option is disabled, "); MSG("because %s is not Xen's memory core image.\n", info->name_memory); MSG("Commandline parameter is invalid.\n"); MSG("Try `makedumpfile --help' for more information.\n"); @@ -4527,7 +4527,7 @@ initial(void) if (info->flag_refiltering) { if (info->flag_elf_dumpfile) { - MSG("'-E' option is disable, "); + MSG("'-E' option is disabled, "); MSG("because %s is kdump compressed format.\n", info->name_memory); return FALSE; @@ -4541,7 +4541,7 @@ initial(void) } else if (info->flag_sadump) { if (info->flag_elf_dumpfile) { - MSG("'-E' option is disable, "); + MSG("'-E' option is disabled, "); MSG("because %s is sadump %s format.\n", info->name_memory, sadump_format_type_name()); return FALSE; @@ -4635,14 +4635,14 @@ out: if (info->num_threads) { if (is_xen_memory()) { - MSG("'--num-threads' option is disable,\n"); + MSG("'--num-threads' option is disabled,\n"); MSG("because %s is Xen's memory core image.\n", info->name_memory); return FALSE; } if (info->flag_sadump) { - MSG("'--num-threads' option is disable,\n"); + MSG("'--num-threads' option is disabled,\n"); MSG("because %s is sadump %s format.\n", info->name_memory, sadump_format_type_name()); return FALSE; @@ -4721,7 +4721,7 @@ out: DEBUG_MSG("mmap() is available on the kernel.\n"); info->flag_usemmap = MMAP_ENABLE; } else { - DEBUG_MSG("The kernel doesn't support mmap(),"); + DEBUG_MSG("The kernel doesn't support mmap(), "); DEBUG_MSG("read() will be used instead.\n"); info->flag_usemmap = MMAP_DISABLE; } -- 2.47.1