Date: Fri, 24 Jan 2025 14:44:03 +0100 (CET) Message-Id: <202501241344.50ODi3JS023059@...2054...> From: Gert Doering In-Reply-To: <20250124115849.14638-1-gert@...1296...> References: <20250124115849.14638-1-gert@...1296...> Subject: [Openvpn-devel] [PATCH applied] Re: multiproto: move generic event handling code in dedicated files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Gianmarco De Gregori Cc: openvpn-devel@lists.sourceforge.net Basically this patch is just "moving code around" and renaming things with "_tcp_" in them to "_io_", generalizing the "store things" structure to be used for TCP and UDP now. I argued the "_protocol_" part of earlier versions away ("HTTPS is also a 'protocol'") and I think the current version is good enough to move forward. I've stared a lot at the code, and ran various versions on the client/server testbed - and they all passed all tests. "git show --color-moved=zebra" is only half-helpful due to all the renaming - but it does help to feel reasonably secure that this is still doing the same thing. Your patch has been applied to the master branch. commit cbb0440ee884ba3c052066d915d6fd7ce86befd2 Author: Gianmarco De Gregori Date: Fri Jan 24 12:58:48 2025 +0100 multiproto: move generic event handling code in dedicated files Signed-off-by: Gianmarco De Gregori Acked-by: Gert Doering Message-Id: <20250124115849.14638-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30561.html Signed-off-by: Gert Doering -- kind regards, Gert Doering