Date: Mon, 27 Jan 2025 12:39:55 +0100 (CET) Message-Id: <202501271139.50RBdtBS054717@...2054...> From: Gert Doering In-Reply-To: <20250121161247.37883-1-frank@...2641...> References: <20250121161247.37883-1-frank@...2641...> Subject: [Openvpn-devel] [PATCH applied] Re: Remove comparing username to NULL in tls_lock_username List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Arne Schwabe Cc: openvpn-devel@lists.sourceforge.net JFTR, v2 in gerrit is "the same as v1, just rebased", so taking what is already on the list here. And indeed, in the only call chain to this, we have string_mod_remap_name(up->username); .. so this should better be non-NULL :-) (ASSERT(str) in string_mod()). Your patch has been applied to the master branch. commit d9af13e8c222cba41000202908663a6d1e2cd028 Author: Arne Schwabe Date: Tue Jan 21 17:12:47 2025 +0100 Remove comparing username to NULL in tls_lock_username Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20250121161247.37883-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30520.html Signed-off-by: Gert Doering -- kind regards, Gert Doering