Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8AD24E4D3 for ; Mon, 10 Feb 2025 19:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739216338; cv=none; b=iwjhNpnI/gBlUMWlQqHYsiOCehRkuwM6Ty/LmsUQpLJepI2y0KtgJBckaP39QOKsdISxtEWWwjOSoarHDCKmxmRZ5hKAsobmt0FC2PKRlmdtXwMCsM4jMF+thk066ZbYvX6BcUCA+4L1vyqONNGhrHqe5aAm1qVYqw7lwN9Ut08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739216338; c=relaxed/simple; bh=OGZL6ZsQM7FmXrtZCcJrdgAs8xmw1WSnlW2HAWblnM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=mRODUeBChGAHroN2n9ivHuJYhiZTHKWYZ8VOqiyu+gjIa2UhSLH5r/fw+uDAUQW4LnUzW3NYPpU+9PdzD4E16kxBF21ZWVLVfUsgSZXep3htyExN3be3b7SHUpEwA5c2NK682Awk0flLZzmAPIwPowukNdmH/fJ2I+8O4xAuj2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CZkQNQrR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CZkQNQrR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739216336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mwHnciP+OvnJG9alUSG9/jEypyVF3ZPTXQLV9dVcfyg=; b=CZkQNQrRfqD+5YnQBoBIPYgyEVsYSEbck7n4/ustTgOVVyqS59yTP5+qY5RuvKkbRJz06x 0crT+MLBWzzvyfQtc8kP29e8XMwUVKgdEOXde93lQEoeXHyCWmTNuw7FZ4R5RWskTIH8N1 z2hRcLYthURePD6/jWXU2l7NXBd6FsQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-nNTPsTXHMfWt2rd7aGYENA-1; Mon, 10 Feb 2025 14:38:55 -0500 X-MC-Unique: nNTPsTXHMfWt2rd7aGYENA-1 X-Mimecast-MFC-AGG-ID: nNTPsTXHMfWt2rd7aGYENA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38dc709f938so1785913f8f.0 for ; Mon, 10 Feb 2025 11:38:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739216334; x=1739821134; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mwHnciP+OvnJG9alUSG9/jEypyVF3ZPTXQLV9dVcfyg=; b=HOo9lWeYgTH+R7sRnyVmsbGJdK5H8T5pbWWoephX0rEbrlzBbDOltnle6BKqMgK5tJ s0uYCdEba7S4AAxNI4l6ccRCj8EpYAiZhN7C1pn5s/SFs07H81iw7sWqafcgyKKGYb0g zJfEy45p+0aoyGrpb4UVRjH4Puv2cxDsNEY0ePIvJ9qtHPPT/tCNb0kVgSrgqb30UGGk HCjBBmJ1klc6jgjWBvjwZIs31g3H1tIHYV0CB09iVUbYRT5UAZpyGH5OR9az+bXSrFPl 4m7Y7l2pp3XdzMUMH5jomIOBxiIxTbhrzWCcDSZyWaYi+Zr95rRfgpFQ0JvxQfUNX19k 4FDg== X-Forwarded-Encrypted: i=1; AJvYcCUmQltxt7FxHOwOW7GF4B2YryhvL6/oTPMc2+Aa8l4/I92cSfD60n+MoUX6IbrYEBJt/uDIjQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yz88nrFTLriHj//Frne5S6RJpnGbPSLQ08Vy1E7qRyI+6vbKc+F KQD06rlJU1ShJBg9aU/vKRP6pshmuN2029x3e0ZTFu2rQgQlRMSf2noo1D9aWpNIpxVXb0IRxej JUrsHB6fQvfZNhO0yoMxaC7tjrtVLzkSEJcaBsjjyjPva+5dsOZc7 X-Gm-Gg: ASbGncu6R9lvcRBiWNOCZzCkuzzpE/MDH+DiYo81JFoKfHdswLx+G75JZiselxUqix/ +D7LXaOyxQvJ2IdyFbMYsDut7fOsDj0726R8VFNKlj1IW0QHnQ8Hd/BKFWILGeUJtyvKu/1RCzq 4wVudGcF5R3KzmDDjN2ice/HpLBKH3Z8gmsPzXnUetn3Jov1YXRygQvQCBVEnFoYNNGDzoacFnb FMZ1B1Tv4Z2LvtF4MWudnGH0aBCyYRl3lG07sLQAWiJ/lnd2kHX1S2rAh+Q5P55i/MKUFOEKFNU Dn/bpP43SSzx0/hUvsSnrtzCdNYY7Mf8RwnieRjmsJ4mkD2U+j4WiWcJ6lv/1vHHZw== X-Received: by 2002:a5d:5f42:0:b0:38d:df15:2770 with SMTP id ffacd0b85a97d-38de432d90fmr568598f8f.0.1739216333886; Mon, 10 Feb 2025 11:38:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQ8jI3Pr0PhgIrX5XFi88nBpwoaMc1TLFqexlyUt/iDFsCN9k6Hzlrlovdfu0/+3mYproMTQ== X-Received: by 2002:a5d:5f42:0:b0:38d:df15:2770 with SMTP id ffacd0b85a97d-38de432d90fmr568579f8f.0.1739216333460; Mon, 10 Feb 2025 11:38:53 -0800 (PST) Received: from localhost (p200300cbc734b80012c465cd348aaee6.dip0.t-ipconnect.de. [2003:cb:c734:b800:12c4:65cd:348a:aee6]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4390db11200sm187831345e9.38.2025.02.10.11.38.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 11:38:52 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev, David Hildenbrand , Andrew Morton , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , SeongJae Park , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe Subject: [PATCH v2 13/17] mm/page_idle: handle device-exclusive entries correctly in page_idle_clear_pte_refs_one() Date: Mon, 10 Feb 2025 20:37:55 +0100 Message-ID: <20250210193801.781278-14-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250210193801.781278-1-david@redhat.com> References: <20250210193801.781278-1-david@redhat.com> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8oNizvBtXpHJ9vdI-5PUzMulMvFuzFUMawEApXNNbFQ_1739216334 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") we can return with a device-exclusive entry from page_vma_mapped_walk(). page_idle_clear_pte_refs_one() is not prepared for that, so let's teach it what to do with these PFN swap PTEs. Note that device-private entries are so far not applicable on that path, as page_idle_get_folio() filters out non-lru folios. Should we just skip PFN swap PTEs completely? Possible, but it seems straight forward to just handle them correctly. Note that we could currently only run into this case with device-exclusive entries on THPs. We still adjust the mapcount on conversion to device-exclusive; this makes the rmap walk abort early for small folios, because we'll always have !folio_mapped() with a single device-exclusive entry. We'll adjust the mapcount logic once all page_vma_mapped_walk() users can properly handle device-exclusive entries. Fixes: b756a3b5e7ea ("mm: device exclusive memory access") Signed-off-by: David Hildenbrand --- mm/page_idle.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mm/page_idle.c b/mm/page_idle.c index 947c7c7a37289..408aaf29a3ea6 100644 --- a/mm/page_idle.c +++ b/mm/page_idle.c @@ -62,9 +62,14 @@ static bool page_idle_clear_pte_refs_one(struct folio *folio, /* * For PTE-mapped THP, one sub page is referenced, * the whole THP is referenced. + * + * PFN swap PTEs, such as device-exclusive ones, that + * actually map pages are "old" from a CPU perspective. + * The MMU notifier takes care of any device aspects. */ - if (ptep_clear_young_notify(vma, addr, pvmw.pte)) - referenced = true; + if (likely(pte_present(ptep_get(pvmw.pte)))) + referenced |= ptep_test_and_clear_young(vma, addr, pvmw.pte); + referenced |= mmu_notifier_clear_young(vma->vm_mm, addr, addr + PAGE_SIZE); } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { if (pmdp_clear_young_notify(vma, addr, pvmw.pmd)) referenced = true; -- 2.48.1