Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEE7618C33B for ; Fri, 7 Mar 2025 02:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741315159; cv=none; b=CRPWGhwtheWyR5L1Bz/B4FiDW1JuUtklX2QPHJil7ndq2ROgEAog8k+sg9VNeMVYsC4CdCHpcWgoi0f/Miw308GVz0TQ9p4ycBEzJn0h9c6U0FET98gjYivHKQB3Wxmxcv0tujUrTmGW+GrHDX1ReBztlFncxizjtRMbYaS/rfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741315159; c=relaxed/simple; bh=iqG3XkWRBPttmCCbkNtgJ25Z4WythQO6E5K24EXEX3w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=iw6zO4DZpvBjjuIUNWsOX7Dxbcn5pnwSXCvcJhicnkm6Y7yov+ZOObaUWtx0RRLSTmXHai9feH9zh3618gZXbquoeKKmbzQi2oPhDSi+IJrI9os5QmDYaXcaoBfcza5nsO1VnAANkdhI+WY53XuIFiG0jPInLfk1DF8OB5Vg2L0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1a9Nwdp3; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1a9Nwdp3" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2ff68033070so2268128a91.2 for ; Thu, 06 Mar 2025 18:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741315157; x=1741919957; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=KPBN3yXUjkpdSLG1dni/WGsuJHBEZ19aO4r2Wk7bmj0=; b=1a9Nwdp3RNDeMa1v8lI8a0TLMDHGfbh75kulSknTlRuVllvBylQSJH46EzQkII9JGj jjIv68m6QtEy1/dI54woUZfLEhLrK75P+Y6DALGzJS7oAbgFuara9YAl/U5j3r1OMWai 6TR5Mj/CMgJ5mtaH/AU7Hb1/jd7kJt6fZ/Gd22uSGg+iLA5uc0hUoUwaF5RP/c+bxCkQ 1JgyKUCvgvoCnpQEMktjAN8Bf4M1fkCPn76MHydlfB5CneNt6Ye232SxVJBhRQFEANQ6 sstHDU/1OnvIVP6l+nz8WSdgcuqGAH4bXIt1uhPmTjbV46FBv9hqfTvSBp9TefPqAhLD wnxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741315157; x=1741919957; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KPBN3yXUjkpdSLG1dni/WGsuJHBEZ19aO4r2Wk7bmj0=; b=jm/qqf9BIXG/AqC3SzD+nLOse5pE5WxeSpbGeB8ava0NuCI4VYSCMaPgITCEwMS8LS 9a5Yq5uT1F0/4A5pE5HI3oqRGGaX/GW4vHWzJHtJp9x5sE6sRTLlYT77TBGbiiTb2GVX gFX+pegvBaRXED8or2gZl7atKup2UYJ0Br8abx5gqA8tet88AszoHDbPS7ATYu16pHhS XnfMnsi/iEwPqA/dd4Hmp06r4FpQCgJxPy5/8zSskgFtLnjPSqsqSU+u03BxN8l+uJpg rDZYOuJ4+I9nDu6NC9pJptypfVXrX6JsQrjQqBpsMHLjda7teREjGfrxKfBWdJLny1M3 flzw== X-Forwarded-Encrypted: i=1; AJvYcCUUy9bNxce09/32jEgHdKKkOKwX+iKtJ72uU2PDVinBmxJnJJzymSnfbBo82BWK1szdfqShDcvIOTNe7Lh//AJO@vger.kernel.org X-Gm-Message-State: AOJu0YxIkQrADvfVShILmW26ODLNBrtB3ydEobUGerE6grg8QibABt0C Kv7wqrsXPWyZmuhaLP0kRerYa6Qvn/pHo2VKnDBG8UvvAvp+uojegI2XsRvpAnr9PV1m5SPS/Dn SXrn8EQ== X-Google-Smtp-Source: AGHT+IG/b0hXfWY5ZRlwruhM4tAtMOk8s3jJ+EevpJ3fgIu+EuawoslSbZhkRzSkJ/I8qE89wS6GDaFWoThH X-Received: from pji13.prod.google.com ([2002:a17:90b:3fcd:b0:2ff:4ba2:f3a5]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4e86:b0:2fe:8f9f:e5f0 with SMTP id 98e67ed59e1d1-2ff7cea0212mr2324134a91.19.1741315157159; Thu, 06 Mar 2025 18:39:17 -0800 (PST) Date: Thu, 6 Mar 2025 18:39:05 -0800 In-Reply-To: <20250307023906.1135613-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250307023906.1135613-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.rc0.332.g42c0ae87b1-goog Message-ID: <20250307023906.1135613-4-irogers@google.com> Subject: [PATCH v2 4/5] perf x86 evlist: Update comments on topdown regrouping From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Dominique Martinet , Andi Kleen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Dapeng Mi , Thomas Falcon Content-Type: text/plain; charset="UTF-8" From: Dapeng Mi Update to remove comments about groupings not working and with the: ``` perf stat -e "{instructions,slots},{cycles,topdown-retiring}" ``` case that now works. Signed-off-by: Ian Rogers --- tools/perf/arch/x86/util/evlist.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/tools/perf/arch/x86/util/evlist.c b/tools/perf/arch/x86/util/evlist.c index ed205d1b207d..7905a28d7734 100644 --- a/tools/perf/arch/x86/util/evlist.c +++ b/tools/perf/arch/x86/util/evlist.c @@ -39,28 +39,13 @@ int arch_evlist__cmp(const struct evsel *lhs, const struct evsel *rhs) * 26,319,024 slots * 2,427,791 instructions * 2,683,508 topdown-retiring - * - * If slots event and topdown metrics events are not in same group, the - * topdown metrics events must be first event after the slots event group, - * otherwise topdown metrics events can't be regrouped correctly, e.g. - * - * a. perf stat -e "{instructions,slots},cycles,topdown-retiring" -C0 sleep 1 - * WARNING: events were regrouped to match PMUs - * Performance counter stats for 'CPU(s) 0': - * 17,923,134 slots - * 2,154,855 instructions - * 3,015,058 cycles - * topdown-retiring - * - * If slots event and topdown metrics events are in two groups, the group which - * has topdown metrics events must contain only the topdown metrics event, - * otherwise topdown metrics event can't be regrouped correctly as well, e.g. - * - * a. perf stat -e "{instructions,slots},{topdown-retiring,cycles}" -C0 sleep 1 + * e. slots event and metrics event are in a group and not adjacent + * perf stat -e "{instructions,slots},cycles,topdown-retiring" -C0 sleep 1 * WARNING: events were regrouped to match PMUs - * Error: - * The sys_perf_event_open() syscall returned with 22 (Invalid argument) for - * event (topdown-retiring) + * 68,433,522 slots + * 8,856,102 topdown-retiring + * 7,791,494 instructions + * 11,469,513 cycles */ if (topdown_sys_has_perf_metrics() && (arch_evsel__must_be_in_group(lhs) || arch_evsel__must_be_in_group(rhs))) { -- 2.49.0.rc0.332.g42c0ae87b1-goog