Date: Thu, 17 Apr 2025 16:04:30 +0200 (CEST) Message-Id: <202504171404.53HE4UNk051879@...2054...> From: Gert Doering In-Reply-To: <20250417134636.21279-1-gert@...1296...> References: <20250417134636.21279-1-gert@...1296...> Subject: [Openvpn-devel] [PATCH applied] Re: ssl_openssl.c: Prevent potential double-free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lev Stipakov Cc: openvpn-devel@lists.sourceforge.net Not tested, as the offending code flow is quite obvious "in hindsight", and making the pointer NULL after free() is a sufficient safeguard against double free(). A slightly more readable construction could have used to different "info" variables for the two different scopes, each with its own individual free(), exactly one per variable... but that's a larger change. Your patch has been applied to the master branch. Application to 2.6 and earlier is not needed, the offending code is new (e9ad1b3 or 3512e8d). commit f7aedca70e24e9a35f0cbd33d1aa708b4daf0055 Author: Lev Stipakov Date: Thu Apr 17 15:46:30 2025 +0200 ssl_openssl.c: Prevent potential double-free Signed-off-by: Lev Stipakov Acked-by: Antonio Quartulli Message-Id: <20250417134636.21279-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31478.html Signed-off-by: Gert Doering -- kind regards, Gert Doering