Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C532C369CA for ; Thu, 17 Apr 2025 19:52:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C6CB10E3AF; Thu, 17 Apr 2025 19:52:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="J6k4cIPz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFD7010E3B1; Thu, 17 Apr 2025 19:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744919536; x=1776455536; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1engxpWynEXcc0GDqbK3YjYUoGEIsPlDXB0ctjkemJ4=; b=J6k4cIPzmr8NsgHHG01uPhJW2Wnk7zxWNG1AkiXRumMz0SDTq7rMmINz v9L9cNirkrlFEwm6eWrS72lmvcFdSH20mW+uMs7qq1TAKX7RNWzX4b/Sl ikjUdkIlsG5TblWnf31Mo5xJkipl1VdN4aOJAW+8SAetZW2yzQml//wkQ yL4KtpLKQzupN9TgWJUhHJWeFvFxq//YIwSUWGxk5gGgTfCK5jLhLWIBt OWy4XyI4fbOhdthEX3b9mQKc5PGcrF4Aq6GGug8GuAxEVYOeN+ZyLkR9b p5RIxLdpDAWY5pV8gg/6LMvCRlUXCEIsnG4gpWtCg3xXPEJ3eUjjDtLS+ g==; X-CSE-ConnectionGUID: XD98HYplSOWCeB6FVytbsA== X-CSE-MsgGUID: 3uXHHc5TS+y+J5Jsfdr1og== X-IronPort-AV: E=McAfee;i="6700,10204,11406"; a="46456365" X-IronPort-AV: E=Sophos;i="6.15,220,1739865600"; d="scan'208";a="46456365" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2025 12:52:15 -0700 X-CSE-ConnectionGUID: yvCIvwZKQcKR0ccLcccucg== X-CSE-MsgGUID: pnqVbiSkScy860hJqCvefQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,220,1739865600"; d="scan'208";a="135765210" Received: from relo-linux-5.jf.intel.com ([10.165.21.152]) by orviesa003.jf.intel.com with ESMTP; 17 Apr 2025 12:52:15 -0700 From: John.C.Harrison@Intel.com To: Intel-Xe@Lists.FreeDesktop.Org Cc: John Harrison , Zhanjun Dong , Alan Previn , Matt Roper , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi , intel-xe@lists.freedesktop.org Subject: [PATCH 1/3] drm/xe/guc: Fix capture of steering registers Date: Thu, 17 Apr 2025 12:52:12 -0700 Message-ID: <20250417195215.3002210-2-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417195215.3002210-1-John.C.Harrison@Intel.com> References: <20250417195215.3002210-1-John.C.Harrison@Intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: John Harrison The list of registers to capture on a GPU hang includes some that require steering. Unfortunately, the flag to say this was being wiped to due a missing OR on the assignment of the next flag field. Fix that. Fixes: b170d696c1e2 ("drm/xe/guc: Add XE_LP steered register lists") Cc: Zhanjun Dong Cc: Alan Previn Cc: Matt Roper Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi Cc: intel-xe@lists.freedesktop.org Signed-off-by: John Harrison --- drivers/gpu/drm/xe/xe_guc_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c b/drivers/gpu/drm/xe/xe_guc_capture.c index f6d523e4c5fe..9095618648bc 100644 --- a/drivers/gpu/drm/xe/xe_guc_capture.c +++ b/drivers/gpu/drm/xe/xe_guc_capture.c @@ -359,7 +359,7 @@ static void __fill_ext_reg(struct __guc_mmio_reg_descr *ext, ext->reg = XE_REG(extlist->reg.__reg.addr); ext->flags = FIELD_PREP(GUC_REGSET_STEERING_NEEDED, 1); - ext->flags = FIELD_PREP(GUC_REGSET_STEERING_GROUP, slice_id); + ext->flags |= FIELD_PREP(GUC_REGSET_STEERING_GROUP, slice_id); ext->flags |= FIELD_PREP(GUC_REGSET_STEERING_INSTANCE, subslice_id); ext->regname = extlist->name; } -- 2.49.0