Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2E98C369D8 for ; Tue, 22 Apr 2025 16:56:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5001A10E5FC; Tue, 22 Apr 2025 16:56:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="T92Ju2VG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id A363410E5E6; Tue, 22 Apr 2025 16:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745340966; x=1776876966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=T93w+cPkH3K1lUEGNkGUUeIFYYg0Lkyf4gQpVt4LnHY=; b=T92Ju2VGpPCDtSvIDIgn6j5SmCG9cH94lFNr69XIN4hdSqJpJ7OA9y24 LbZYqn8oFe5YJUgitxZFlvZyXvNqtBSAKCYB7JmiGs7xBh7fygkSgPxy6 Kjjr8ANZm7T8onVW7aC8HvkPL8kRMPLfduir5xz5oIPbthtMvD2/VcDlT gwhh9GHx2aO6ipLIPbbiOTue1o0yRXJhpmjeo6p6W94k5+5+lSATpNOpH KLMJUecnKQ1EVwqZDvo1cQOJqkERkPpu/ZbXdYoS0tP6IIhgw1YvxR/0y NHWfmWLqq8Fk6Ddyb+cAQtamOX5tKvqW9o1aM6mXGmwvhe5YL0ZPI0qoy Q==; X-CSE-ConnectionGUID: 0KK5G1oXTqyMw14b7rbwHg== X-CSE-MsgGUID: bgsgzc+/SpO8FT3fzLnmTA== X-IronPort-AV: E=McAfee;i="6700,10204,11411"; a="46613171" X-IronPort-AV: E=Sophos;i="6.15,231,1739865600"; d="scan'208";a="46613171" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2025 09:56:05 -0700 X-CSE-ConnectionGUID: Ced9KFq7Q4+PDBl7eOXhLw== X-CSE-MsgGUID: H5ij1SiiTmWjif0DNCF1+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,231,1739865600"; d="scan'208";a="136855410" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2025 09:56:04 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, thomas.hellstrom@linux.intel.com, himal.prasad.ghimiray@intel.com Subject: [PATCH v3 4/5] drm/xe: Timeslice GPU on atomic SVM fault Date: Tue, 22 Apr 2025 09:57:22 -0700 Message-Id: <20250422165723.584286-5-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250422165723.584286-1-matthew.brost@intel.com> References: <20250422165723.584286-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Ensure GPU can make forward progress on an atomic SVM GPU fault by giving the GPU a timeslice of 5ms v2: - Reduce timeslice to 5ms - Double timeslice on retry - Split out GPU SVM changes into independent patch Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_svm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c index 7e4584855cc5..3c1dcb6a98e6 100644 --- a/drivers/gpu/drm/xe/xe_svm.c +++ b/drivers/gpu/drm/xe/xe_svm.c @@ -783,6 +783,8 @@ int xe_svm_handle_pagefault(struct xe_vm *vm, struct xe_vma *vma, IS_ENABLED(CONFIG_DRM_XE_DEVMEM_MIRROR) ? SZ_64K : 0, .devmem_only = atomic && IS_DGFX(vm->xe) && IS_ENABLED(CONFIG_DRM_XE_DEVMEM_MIRROR), + .timeslice_ms = atomic && IS_DGFX(vm->xe) && + IS_ENABLED(CONFIG_DRM_XE_DEVMEM_MIRROR) ? 5 : 0, }; struct xe_svm_range *range; struct drm_gpusvm_range *r; @@ -819,6 +821,7 @@ int xe_svm_handle_pagefault(struct xe_vm *vm, struct xe_vma *vma, if (--migrate_try_count >= 0 && xe_svm_range_needs_migrate_to_vram(range, vma)) { err = xe_svm_alloc_vram(vm, tile, range, &ctx); + ctx.timeslice_ms <<= 1; /* Double timeslice if we have to retry */ if (err) { if (migrate_try_count || !ctx.devmem_only) { drm_dbg(&vm->xe->drm, -- 2.34.1