Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97543219A70 for ; Tue, 6 May 2025 04:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746506442; cv=none; b=pjJHvam+Ep6ZPBiQl4lLmGu2S92Gsy64777t3ucH52Vu5eWfOahmod99VK8vBIGP8vTPBtp3J3I7xCmf4m5Mvo3XKDz/pZofSz3LOXuQbN59UD6Qt/rK95tU5bt6qDDG+cyKoAPx4WsIwIt+V5gBG47b/VIfSdLFjOWJLBUOz7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746506442; c=relaxed/simple; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZCzkEzPmFizgddjx1emRcF9xMvLrSr+u3oIGKexuPURm2xmEcR0SZk6/aBHakfO+xQC3YlVFwBE2aP7Xin1XnGUszq2qSFJ9y+uYOUxJQZ2W/9JVT0Bx2uqewejBzdn+GnPyrEhforhq/MFux/F1lJ38sF5r3HnnwEEvZhZCF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 8063D67373; Tue, 6 May 2025 06:40:36 +0200 (CEST) Date: Tue, 6 May 2025 06:40:36 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Nilay Shroff , Shinichiro Kawasaki , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Christoph Hellwig Subject: Re: [PATCH V5 07/25] block: add helper add_disk_final() Message-ID: <20250506044036.GB27061@lst.de> References: <20250505141805.2751237-1-ming.lei@redhat.com> <20250505141805.2751237-8-ming.lei@redhat.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250505141805.2751237-8-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Looks good: Reviewed-by: Christoph Hellwig