Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB4A1EB9FD for ; Tue, 13 May 2025 06:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747119228; cv=none; b=Iy/Ji9p5WkouxeB+xMpCKk7UDMkHNTb1JGxTSpNyfHKdglwBSzjAY0NWUgrbf5Gox42EiWoZ4lD6MF17cvj9rWy4TuoUM+4CYzMmsBw7d7DHAgbOKP485zYgigazaTZ/T0A24WIZm5Yb+5XTjOW8w8THFXTrhe2T0+8YDcIyXMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747119228; c=relaxed/simple; bh=JaHdrTF9xrWm2h1EBgPebwM/KUcBdSsxru0V0FD8Z6g=; h=Date:To:From:Subject:Message-Id; b=k78ei/v1YGANpbsb1HzgXXm50WFoQzdRqNmM3IKLhaLR5LBtko5ssslYA6EgUoFRcG2IrR0MnTuNlay+1fpWlOWuv+5SZ/iaMDMqVhwszAZ95YGmdchocoOepjtdQ5AuAtgMWQq5ge/0hXCEp6DeqCG/LmQEKyclNhnE3aFvJcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Q3Dqm1Va; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Q3Dqm1Va" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE566C4CEE4; Tue, 13 May 2025 06:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1747119228; bh=JaHdrTF9xrWm2h1EBgPebwM/KUcBdSsxru0V0FD8Z6g=; h=Date:To:From:Subject:From; b=Q3Dqm1Vagdfy4pYwq5OFirPytTIvQfkrk1espGNEX4WldUu07QXRSDvyuRhcvc69B NKlIlHGMQq0KKKE4v2L8pj3oVx5nUJcUtkinsY2P6TL4+jGSHylmDDtKWPQczrpUHF nLUIZVFqpyCwOvt8ByYjxyDWc91lftXGUHVnrHSE= Date: Mon, 12 May 2025 23:53:47 -0700 To: mm-commits@vger.kernel.org,willy@infradead.org,vbabka@suse.cz,urezki@gmail.com,shijie@os.amperecomputing.com,shakeel.butt@linux.dev,rrangel@chromium.org,roman.gushchin@linux.dev,pmladek@suse.com,paulmck@kernel.org,muchun.song@linux.dev,mhocko@kernel.org,linux@rasmusvillemoes.dk,kpsingh@kernel.org,hannes@cmpxchg.org,guoweikang.kernel@gmail.com,francesco@valla.it,link@vivo.com,akpm@linux-foundation.org From: Andrew Morton Subject: [merged mm-stable] mm-memcg-use-kmem_cache-when-alloc-memcg-pernode-info.patch removed from -mm tree Message-Id: <20250513065347.DE566C4CEE4@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The quilt patch titled Subject: mm/memcg: use kmem_cache when alloc memcg pernode info has been removed from the -mm tree. Its filename was mm-memcg-use-kmem_cache-when-alloc-memcg-pernode-info.patch This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Huan Yang Subject: mm/memcg: use kmem_cache when alloc memcg pernode info Date: Fri, 25 Apr 2025 11:19:25 +0800 When tracing mem_cgroup_per_node allocations with kmalloc ftrace: kmalloc: call_site=mem_cgroup_css_alloc+0x1d8/0x5b4 ptr=00000000d798700c bytes_req=2896 bytes_alloc=4096 gfp_flags=GFP_KERNEL|__GFP_ZERO node=0 accounted=false This reveals the slab allocator provides 4096B chunks for 2896B mem_cgroup_per_node due to: 1. The slab allocator predefines bucket sizes from 64B to 8096B 2. The mem_cgroup allocation size (2312B) falls between the 2KB and 4KB slabs 3. The allocator rounds up to the nearest larger slab (4KB), resulting in ~1KB wasted memory per memcg alloc - per node. This patch introduces a dedicated kmem_cache for mem_cgroup structs, achieving precise memory allocation. Post-patch ftrace verification shows: kmem_cache_alloc: call_site=mem_cgroup_css_alloc+0x1b8/0x5d4 ptr=000000002989e63a bytes_req=2896 bytes_alloc=2944 gfp_flags=GFP_KERNEL|__GFP_ZERO node=0 accounted=false Each mem_cgroup_per_node alloc 2944bytes(include hw cacheline align), compare to 4096, it avoid waste. Link: https://lkml.kernel.org/r/20250425031935.76411-4-link@vivo.com Signed-off-by: Huan Yang Acked-by: Shakeel Butt Acked-by: Johannes Weiner Cc: Francesco Valla Cc: guoweikang Cc: Huang Shijie Cc: KP Singh Cc: Michal Hocko Cc: Muchun Song Cc: "Paul E . McKenney" Cc: Petr Mladek Cc: Rasmus Villemoes Cc: Raul E Rangel Cc: Roman Gushchin Cc: "Uladzislau Rezki (Sony)" Cc: Vlastimil Babka Cc: Matthew Wilcox Signed-off-by: Andrew Morton --- mm/memcontrol.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/mm/memcontrol.c~mm-memcg-use-kmem_cache-when-alloc-memcg-pernode-info +++ a/mm/memcontrol.c @@ -97,6 +97,7 @@ static bool cgroup_memory_nokmem __ro_af static bool cgroup_memory_nobpf __ro_after_init; static struct kmem_cache *memcg_cachep; +static struct kmem_cache *memcg_pn_cachep; #ifdef CONFIG_CGROUP_WRITEBACK static DECLARE_WAIT_QUEUE_HEAD(memcg_cgwb_frn_waitq); @@ -3614,7 +3615,8 @@ static bool alloc_mem_cgroup_per_node_in { struct mem_cgroup_per_node *pn; - pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, node); + pn = kmem_cache_alloc_node(memcg_pn_cachep, GFP_KERNEL | __GFP_ZERO, + node); if (!pn) return false; @@ -5075,6 +5077,9 @@ int __init mem_cgroup_init(void) memcg_cachep = kmem_cache_create("mem_cgroup", memcg_size, 0, SLAB_PANIC | SLAB_HWCACHE_ALIGN, NULL); + memcg_pn_cachep = KMEM_CACHE(mem_cgroup_per_node, + SLAB_PANIC | SLAB_HWCACHE_ALIGN); + return 0; } _ Patches currently in -mm which might be from link@vivo.com are