Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC32725D1FC; Wed, 4 Jun 2025 01:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748998807; cv=none; b=UBtyYNUyknbnVFCOwpXXnqFecCj5Ibjoku4EVpPxJmY9XTQ/stqP7loEsnh6oyQLYop18MunphZRAQk762t4+uBncjpA/y/3gadqUpFHnU3QMQsg4WdQIfbUibB7P7kF49xWaxWjOjZlopoIxbePmMcHgvzZWrOKS2gSQuHi/ZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748998807; c=relaxed/simple; bh=igbIAgzbJeaVWB1w+eCLbYSXyOaEFQQHshxF8LaMAJA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X/2wA4pRIiQS0uDc14rHlsWnnUU85S4ZWqTlQ6PUAHfKhCqEIQR2agyVrep+zbsNUmvtOyGK2yc94DGKhlnHBIesoGU/VPcYRD8DE7/OGyAymgfKOHcVZcRNBur1hPY9yA0wIxCCmPtgEtX0qL2R1E16cJQA0ne9rpqmSfidrjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tzqXHka7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tzqXHka7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B995C4CEF1; Wed, 4 Jun 2025 01:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748998807; bh=igbIAgzbJeaVWB1w+eCLbYSXyOaEFQQHshxF8LaMAJA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tzqXHka7TA6yqrtA5C7EcfVD4W+sMt4NgHAxaDr0yXWrKVCCL1u9CaENyM+Q+9kSb fSAMx2bBBCpeZRrNbCse3VcT0n7gn62iRYAeKj315mr0nqHojA1wu3iM0wz4lHA4pf 1vF8Ayml4vvgaejIEOttYE9vmbk9TCDVIkW+AT0+2HWTKyWA/8PUmTfIV5MMlkmn0B MjAPFq766ope5G3VOHCjdVnflwRcMYrYm4UTEc96dBiZDFEpWbhrKsYEvt9AyxmIJj 6R10t3kzojqgVj5oxBJ7fwJZ27E8fTKpw3c7fi8k4l8jAHmmMKwIgmv8Y0uPRakZLO 55lBK68Y9yRFg== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Kang Yang , Vasanthakumar Thiagarajan , Jeff Johnson , Sasha Levin , jjohnson@kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org Subject: [PATCH AUTOSEL 6.12 23/93] wifi: ath12k: fix macro definition HAL_RX_MSDU_PKT_LENGTH_GET Date: Tue, 3 Jun 2025 20:58:09 -0400 Message-Id: <20250604005919.4191884-23-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250604005919.4191884-1-sashal@kernel.org> References: <20250604005919.4191884-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.31 Content-Transfer-Encoding: 8bit From: Kang Yang [ Upstream commit a69bbf89d751ba2d6da21d773c4e29c91c5e53c4 ] Currently, HAL_RX_MSDU_PKT_LENGTH_GET uses u32_get_bits to obtain the MSDU length from the MSDU description. This is not right. Because all halphy descriptions are little endian. So use le32_get_bits for HAL_RX_MSDU_PKT_LENGTH_GET. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Signed-off-by: Kang Yang Reviewed-by: Vasanthakumar Thiagarajan Link: https://patch.msgid.link/20250421023444.1778-9-kang.yang@oss.qualcomm.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees as it fixes a critical endianness bug that can cause data corruption and system crashes. ## Analysis ### Nature of the Bug This is a **critical endianness bug fix**, not a feature enhancement. The commit changes `HAL_RX_MSDU_PKT_LENGTH_GET` from using `u32_get_bits` to `le32_get_bits`. The issue is that the underlying data structure `rx_msdu_desc` has `info0` declared as `__le32` (little-endian), but the macro was treating it as native-endian. ### Critical Impact Areas **1. Memory Safety & Data Corruption:** - The macro extracts MSDU (MAC Service Data Unit) packet lengths from hardware descriptors - On big- endian systems, `u32_get_bits` vs `le32_get_bits` would extract completely wrong values - These incorrect lengths are used for buffer bounds checking and memory allocation operations - This could lead to buffer overflows, memory corruption, or kernel crashes **2. Cross- Architecture Compatibility:** - This bug would manifest on big-endian architectures (ARM BE, MIPS BE, PowerPC) - x86/x86_64 systems wouldn't notice the bug due to little-endian architecture - The ath12k driver supports multiple hardware variants that require correct endian handling **3. Hardware Descriptor Consistency:** - Analysis shows the ath12k driver predominantly uses `le32_get_bits` (287 instances vs 242 `u32_get_bits`) - All hardware-specific MSDU length extraction consistently uses little-endian operations - The `struct rx_msdu_desc` explicitly marks `info0` as `__le32`, confirming hardware uses little- endian format ### Comparison with Similar Commits All the reference commits marked "NO" were either: - Feature additions (A-MSDU indication improvements) - Structural definition updates - Hardware descriptor format corrections This commit differs fundamentally - it's fixing actual data corruption that could cause crashes. ### Backporting Justification - **Fixes user-affecting bug**: System crashes and data corruption on big-endian systems - **Small and contained**: Single line change with clear, targeted fix - **No architectural changes**: Only corrects endianness handling - **Minimal regression risk**: Aligns code with actual hardware behavior - **Critical subsystem**: Network packet processing is core functionality This endianness bug represents exactly the type of critical, low-risk fix that stable trees are designed to address. drivers/net/wireless/ath/ath12k/hal_desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/hal_desc.h b/drivers/net/wireless/ath/ath12k/hal_desc.h index 4f745cfd7d8e7..7e369732ad714 100644 --- a/drivers/net/wireless/ath/ath12k/hal_desc.h +++ b/drivers/net/wireless/ath/ath12k/hal_desc.h @@ -705,7 +705,7 @@ enum hal_rx_msdu_desc_reo_dest_ind { #define RX_MSDU_DESC_INFO0_DECAP_FORMAT GENMASK(30, 29) #define HAL_RX_MSDU_PKT_LENGTH_GET(val) \ - (u32_get_bits((val), RX_MSDU_DESC_INFO0_MSDU_LENGTH)) + (le32_get_bits((val), RX_MSDU_DESC_INFO0_MSDU_LENGTH)) struct rx_msdu_desc { __le32 info0; -- 2.39.5