Received: by 2002:a17:505:6015:b0:1be9:327d:8ee3 with SMTP id us21csp233722njc; Thu, 5 Jun 2025 06:12:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXEgqkMVRh3B43m2SL897L1sMbTB4lATvB7z4DV53in1qijwqkhHinF1V2inbYu72rFv3pOqq4GoCuGwg==@linaro.org X-Google-Smtp-Source: AGHT+IEOuoaeJvl+mnPDjbYJw+RvZbepnz9yQOU1ENrBAvS3qftos+xm/Z7U/MtBxQuMieshU9hO X-Received: by 2002:a05:6102:f09:b0:4df:8f03:12ca with SMTP id ada2fe7eead31-4e746e0f15emr5469228137.21.1749129119779; Thu, 05 Jun 2025 06:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749129119; cv=none; d=google.com; s=arc-20240605; b=j5RZH4Rx6xOIGm3LZIaATRpFDHWIU4tL5bb4BhwHdUstlmUa+IYgV6XFbBREAyyT0A wARPgwGBl8viH87aaYf3ZNd369f/0SuOMLimgFOoeHeqwXjB9RuA5JJQLbZrS/G7P1Yp J+JUyue/4g2BpT+iuo/9pmkNZ6HnhkGO5A4sO3RALVaiE9WGhioJIKniXtRg1YESDa+N ZG3vgWH52aKnJVh1ENyly4KqMRIRCIxM6X1q3ypLrZAO5bH1XIGxt8Df6ZP4Jh2RGL7h yk5N2pE1OTYBDHPHJdvbwrM0hrlf4MoGV8RV1zGTn+PLvop0IfQY+DhfUoXelpE5NBH9 8lbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=K75aSCyzs9q5zyzmveX5d6CIqDix0KE2if+KVjMGA+I=; fh=YU1cbT3qMDVX5SqeUI1a8IK8OiVGYfDJO93uZsIhlYI=; b=io5jVCT7QI9zmmx+HWpryMDhOE/WtFjlPOxq3tQXT4WavE4sVeqJcZoqG4vBbX4ZAk cJPbesBKSofOmb2NZ2cC0sXXuGkuBDaQDqBbo8qAzP3/dI68GOOhS5ttwZLbhGItSxMs QWqKpbqawOmOUBj00DdD7I5KtQHjMX8TwuLcMMSA4skEKoBZZ3l6k7uGjjnzOHkunZEw bl3AaqHHSjy3fg3nPaO9AHADOLaAflVuP8G1ZNVqGpWR22G+xbt/rD7AUMzGjiN+NnBe bavDLOpt+m1qFBCC0/MKrGdDRAg+5WBzoiU+3yOXHoXMWbFGD6Fw/eCoCIf4NfoTzqZ6 bX7w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=TBUG62Kg; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4e75a73b391si496950137.487.2025.06.05.06.11.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jun 2025 06:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=TBUG62Kg; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNANm-0002Ci-C5; Thu, 05 Jun 2025 09:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uN0Jh-00089x-62; Wed, 04 Jun 2025 22:26:53 -0400 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uN0Jf-0008MP-N6; Wed, 04 Jun 2025 22:26:52 -0400 Received: by mail-pl1-x643.google.com with SMTP id d9443c01a7336-235ea292956so4950065ad.1; Wed, 04 Jun 2025 19:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749090409; x=1749695209; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K75aSCyzs9q5zyzmveX5d6CIqDix0KE2if+KVjMGA+I=; b=TBUG62KgYIZAUk08SXzF3Y9ycrEZ+2mvnxRzv4Y3Si2L4M0RCCpD8XzzWSjHxZ0qRd fvya5iGFx4Fm85VJP3InDNA5lq1BRi5awN527L2BC/y4w6W30rh9CssQPybAyHJxVx7U y9Pz2k81AJlw8m8POsnzPIY1xWAy1/wDtkpsAMYzE2rw0eJgph8crtsqGVLOqoojNvWA pacNd10oSSEHm7ZVbKLpv4J0MAtKYEJuzH9gEPq5SnYU4f9M3IMROzSUXdRiuh4qxGBO AYrvVcOPvrDSUaaRVx/4XM3g9KV/YCP2eQ9vUyRVk1LURc3cgR53t7+uagj45JLXBIvL 7jdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749090409; x=1749695209; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K75aSCyzs9q5zyzmveX5d6CIqDix0KE2if+KVjMGA+I=; b=scIDbeNbQdAtQP2Kcd7O/INIOCkW9wL7/mqmSh+VFrJc0oN1mba5x+FvLeq/QqJKCa gMOXBYklK8YBHO00lZxGdBW48wx9Wdxb//2THjlD/hWinaB8s606DwFYI5L4aVBIah8g 1zO3ZHNb8KGfgPO0z//JsuPp3SoaXWd1R+m85YpzrQrGrIfvVZGegyhewdmjN8vmmlfh bBkTSijt6OzO/hFsoFmYDtNrLeuRrId3KNP0yARmRYvvrdAZnESp2/pyxPm3NBGodoZO 7VfCPAeMTzbtSCNB2l/tRppHPeYSV7FiPuX1qg/Y6fcR/EmkTzNPXy1m6fFtrSdGhO9g S7gA== X-Forwarded-Encrypted: i=1; AJvYcCWjDGtK7q8CNbOnz76IvIruULp3Trpqjzql7oAdxD6usac/o984rgD7P6sn1RDC2E87eqVi49QpbQ==@nongnu.org X-Gm-Message-State: AOJu0YwII+hrcO5RK3rsrrqVbnvYRTESqffoix1pxX+tvrlRUI+3kSz0 SNM9xCSLzu3k2CZG0xjUu1U7i7WVtqGZhehodfg9aH+M/t0iKYKpl/oDK3svuc/prpc1Bg== X-Gm-Gg: ASbGncsLIilEHkpQJCEl3X3J9FuJok+w0YNfstoWidQ1f9Fdsa+hJy/yy2v3s5PkTCq MX/ISvMQv17YUmB4+xQSF5JgyBF9/K0qpBpTFtp6J9P4JEpsX9G00KqzT8K2JKXUE92flDQLhWu ZE2xD9KblIFv7hPnDxLCm/HnwtJVYIZHFEoQV9YiOWcYs6urIIwPMLtahqXiQxCJT1nlT1RQmF2 Fz/FW8V91Yd8hHUDnE/J722LDZWyjr7dvjm9gCtqBGE5q94VYqZGeiyp//eeSFnddD3KyZPNEmG D6TB4Q3BEob8JJJ/xxt6lUkQGBOFt6ysOG9+jBFRmQcI0+lljH4z2L2gr/A= X-Received: by 2002:a17:902:c94d:b0:234:9cdd:ffd5 with SMTP id d9443c01a7336-235e11e5c3amr65613585ad.25.1749090409026; Wed, 04 Jun 2025 19:26:49 -0700 (PDT) Received: from huawei.. ([218.76.62.144]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506cd3506sm110296125ad.156.2025.06.04.19.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 19:26:48 -0700 (PDT) From: taotang2025@gmail.com To: qemu-devel@nongnu.org Cc: eric.auger@redhat.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, Tao Tang Subject: [PATCH] hw/arm/smmuv3: Fix incorrect reserved mask for SMMU CR0 register Date: Thu, 5 Jun 2025 10:26:40 +0800 Message-Id: <20250605022640.598308-1-taotang2025@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::643; envelope-from=taotang2025@gmail.com; helo=mail-pl1-x643.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 05 Jun 2025 09:11:44 -0400 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: zyy0dza3/4Zq From: Tao Tang The current definition of the SMMU_CR0_RESERVED mask is incorrect. It mistakenly treats bit 10 (DPT_WALK_EN) as a reserved bit while treating bit 9 (RES0) as an implemented bit. According to the SMMU architecture specification, the layout for CR0 is: | 31:11| RES0 | | 10 | DPT_WALK_EN | | 9 | RES0 | | 8:6 | VMW | | 5 | RES0 | | 4 | ATSCHK | | 3 | CMDQEN | | 2 | EVENTQEN | | 1 | PRIQEN | | 0 | SMMUEN | Signed-off-by: Tao Tang --- hw/arm/smmuv3-internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h index b6b7399347..42ac77e654 100644 --- a/hw/arm/smmuv3-internal.h +++ b/hw/arm/smmuv3-internal.h @@ -120,7 +120,7 @@ REG32(CR0, 0x20) FIELD(CR0, EVENTQEN, 2, 1) FIELD(CR0, CMDQEN, 3, 1) -#define SMMU_CR0_RESERVED 0xFFFFFC20 +#define SMMU_CR0_RESERVED 0xFFFFFA20 REG32(CR0ACK, 0x24) REG32(CR1, 0x28) -- 2.34.1