Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72004C7115D for ; Thu, 19 Jun 2025 16:17:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSHw6-0001TE-Dt; Thu, 19 Jun 2025 12:16:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSHvk-0001Ly-6f for qemu-devel@nongnu.org; Thu, 19 Jun 2025 12:16:01 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSHve-0003fC-4c for qemu-devel@nongnu.org; Thu, 19 Jun 2025 12:15:57 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-748f54dfa5fso647839b3a.2 for ; Thu, 19 Jun 2025 09:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750349751; x=1750954551; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DkzAOT9KPhbXdwiYkwrjtSXHJRVHCh65cjh/wF+xrzM=; b=EywmehJNO78IOKRiqcuHFNqd0UiowlJ0igRkyR8hT8Ocv/lp+iSqwas+FL6gZ2UpXG TIs8Kl96Gh28F3AT7CXeW/NwijSD6v1NH0aUPT+Gy80OdmfpEW6wu70v94iT9s7Nql7J qrKvW22aoxZPZmomLeymyy2OoWtOVSGsBGHT96TUtk+4AOXz9vShsu3sQLTF6NpQqtqd MJX9Ixc+bo9BU/H0ErNaTYGbvd7QFSTcxtCB8BoKsi3K7PbuVKMM1UL7vf7ce66ZJjlL qC/N8uSR/jeBsS4qMDuP8D837ZV7oE1YM0xtHRuAVDiK+/MZ7i47qmD+ym2joZmbGG42 +09A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750349751; x=1750954551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DkzAOT9KPhbXdwiYkwrjtSXHJRVHCh65cjh/wF+xrzM=; b=YjYTZeOmJ99f4s/UFg3RCyKkmyKb3QU1W+Lhvx3SHhMNTiReqic8zcMbTVNr66s0ZS t8GcoN5MRwErfaGJiRNEjBvNvNqw8kw0n2ieS8T41H/h8M+vQmw2sYq+Z7d2QOsxjK3P whPnFSkgutjG0yUfHbxe/P3lPe21SGJGPs3E4oE4orsd40mb2Vtyt32LM7hw8ZDNI4k2 grgun1JQeLTDH0MOIEuFUV5o7l1fCiD3H6dB7uflVbPkBg1ocOm7bB8ueTt28FfcpsAN B3bkSxIlGtcV/Ihhx6xbQBft/Uc+lDThHXNt5VynjvMXt6/DpCWoq4nQrGDVlZ+CEx5I xLNw== X-Gm-Message-State: AOJu0YyCOIVzxL9AwgWpAnrfoTAN+is5FS+jsV6ZxqaKU1LvKTbZN3LZ BYf6UVal64L/u12pcxO0s3HNqswZKf8wkK3j+DPGPCHfHpFaKs4R32kfoJjljfKE X-Gm-Gg: ASbGncvEYMGFolgPB4/eP2r10MRH5zemJuIqwqnfLBRGVBD1qO903USs/5V5xPuGBvB p2C44JNYPJY0wmUJchk3o02CfZTT5rBk8SmKiGjGGxkuSWoidz+bwwEj57NjRwK1b1tjepDEqZd tyvapC4mARjY7cI76g/yp7JdIUMCMIJJ3vp7Nvf0h5/l7b5oMQnZTD50ndrsW6T9n+OQEJ/OJ1c M9EU1HZ3cowrD0k3086JWKimkL3BYPt20Gt5Y4otrMLN8ZOCz3oRN4TMkwJQF517coAoC6Xadsw Z+dnDTry+V8IWXBKV02YHJ/ZeLV33gHqbi9oiUIjOHB+RSwyAc0x01CW6ykhTA== X-Google-Smtp-Source: AGHT+IGfmKRAcxgMCCrjJjYIiwGt1ZCbh3Xw5MIbPZyzpwKdYuhN4VDcdttnTo5zI/54yeFv4rIurA== X-Received: by 2002:a05:6a21:48b:b0:1f5:6c94:2cd7 with SMTP id adf61e73a8af0-21fbd6927e2mr33394430637.42.1750349751017; Thu, 19 Jun 2025 09:15:51 -0700 (PDT) Received: from shemhazi.lan ([50.46.174.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2fe168a0f8sm13168683a12.53.2025.06.19.09.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 09:15:50 -0700 (PDT) From: Rowan Hart To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Marcel Apfelbaum , Zhao Liu , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alexandre Iooss , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Eduardo Habkost , Mahmoud Mandour , Paolo Bonzini , novafacing Subject: [PATCH v13 2/7] plugins: Add register write API Date: Thu, 19 Jun 2025 09:15:42 -0700 Message-ID: <20250619161547.1401448-3-rowanbhart@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250619161547.1401448-1-rowanbhart@gmail.com> References: <20250619161547.1401448-1-rowanbhart@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=rowanbhart@gmail.com; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: novafacing This patch adds a function to the plugins API to allow plugins to write register contents. It also moves the qemu_plugin_read_register function so all the register-related functions are grouped together in the file. Reviewed-by: Pierrick Bouvier Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 54 ++++++++++++++++++++++++++------------ plugins/api.c | 26 +++++++++++++----- 2 files changed, 56 insertions(+), 24 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 3a850aa216..cfe1692ecb 100644 --- a/include/qemu/qemu-plugin.h +++ b/include/qemu/qemu-plugin.h @@ -871,7 +871,8 @@ struct qemu_plugin_register; /** * typedef qemu_plugin_reg_descriptor - register descriptions * - * @handle: opaque handle for retrieving value with qemu_plugin_read_register + * @handle: opaque handle for retrieving value with qemu_plugin_read_register or + * writing value with qemu_plugin_write_register * @name: register name * @feature: optional feature descriptor, can be NULL */ @@ -893,6 +894,41 @@ typedef struct { QEMU_PLUGIN_API GArray *qemu_plugin_get_registers(void); +/** + * qemu_plugin_read_register() - read register for current vCPU + * + * @handle: a @qemu_plugin_reg_handle handle + * @buf: A GByteArray for the data owned by the plugin + * + * This function is only available in a context that register read access is + * explicitly requested via the QEMU_PLUGIN_CB_R_REGS flag. + * + * Returns the size of the read register. The content of @buf is in target byte + * order. On failure returns -1. + */ +QEMU_PLUGIN_API +int qemu_plugin_read_register(struct qemu_plugin_register *handle, + GByteArray *buf); + +/** + * qemu_plugin_write_register() - write register for current vCPU + * + * @handle: a @qemu_plugin_reg_handle handle + * @buf: A GByteArray for the data owned by the plugin + * + * This function is only available in a context that register write access is + * explicitly requested via the QEMU_PLUGIN_CB_RW_REGS flag. + * + * The size of @buf must be at least the size of the requested register. + * Attempting to write a register with @buf smaller than the register size + * will result in a crash or other undesired behavior. + * + * Returns the number of bytes written. On failure returns 0. + */ +QEMU_PLUGIN_API +int qemu_plugin_write_register(struct qemu_plugin_register *handle, + GByteArray *buf); + /** * qemu_plugin_read_memory_vaddr() - read from memory using a virtual address * @@ -915,22 +951,6 @@ QEMU_PLUGIN_API bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByteArray *data, size_t len); -/** - * qemu_plugin_read_register() - read register for current vCPU - * - * @handle: a @qemu_plugin_reg_handle handle - * @buf: A GByteArray for the data owned by the plugin - * - * This function is only available in a context that register read access is - * explicitly requested via the QEMU_PLUGIN_CB_R_REGS flag. - * - * Returns the size of the read register. The content of @buf is in target byte - * order. On failure returns -1. - */ -QEMU_PLUGIN_API -int qemu_plugin_read_register(struct qemu_plugin_register *handle, - GByteArray *buf); - /** * qemu_plugin_scoreboard_new() - alloc a new scoreboard * diff --git a/plugins/api.c b/plugins/api.c index 3c9d4832e9..6514f2c76a 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -433,6 +433,25 @@ GArray *qemu_plugin_get_registers(void) return create_register_handles(regs); } +int qemu_plugin_read_register(struct qemu_plugin_register *reg, GByteArray *buf) +{ + g_assert(current_cpu); + + return gdb_read_register(current_cpu, buf, GPOINTER_TO_INT(reg) - 1); +} + +int qemu_plugin_write_register(struct qemu_plugin_register *reg, + GByteArray *buf) +{ + g_assert(current_cpu); + + if (buf->len == 0 || qemu_plugin_get_cb_flags() != QEMU_PLUGIN_CB_RW_REGS) { + return -1; + } + + return gdb_write_register(current_cpu, buf->data, GPOINTER_TO_INT(reg) - 1); +} + bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByteArray *data, size_t len) { g_assert(current_cpu); @@ -453,13 +472,6 @@ bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByteArray *data, size_t len) return true; } -int qemu_plugin_read_register(struct qemu_plugin_register *reg, GByteArray *buf) -{ - g_assert(current_cpu); - - return gdb_read_register(current_cpu, buf, GPOINTER_TO_INT(reg) - 1); -} - struct qemu_plugin_scoreboard *qemu_plugin_scoreboard_new(size_t element_size) { return plugin_scoreboard_new(element_size); -- 2.49.0