Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECACF1DC075 for ; Fri, 20 Jun 2025 17:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750442134; cv=none; b=c7AyESVMqbY9Fpon8cuUAOeIhOIfFfTzY7bM/UlV9+saDrHEbmUMhvRe1Y21rEN5HVXk62+TW57HvXUf/szHN79+b/t+u5+Asu3NJXHyf8ga558BJ7nJbODRBLFeAUxj2t6lQzghXYa85VAoeMAG3QiSfb1UqdVJNd9O1xv0d/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750442134; c=relaxed/simple; bh=jbboWeoJ2FzLoPAGPxUQuM1kKfg7SRnEiKAgwnUNpFQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=udRqn26bEFOsKSh18rHeyNi5puFz4pdhy2aktjLiEoGD5Svk2i6yzm5+1hSiTXjq6h930j/LVpZlvnSAOFxMFEyU923oqvHekqXx65Mh5LyU2GB69fux83aP5a8prZ1EDg2tppLnzJhMU/5XDm06eGBFTVcsBQYL8Z0NDaYmArA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CbOdX+Az; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CbOdX+Az" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750442132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Y3t3RH+mqSxESBqyl764lJaiT5KQpsa5femZih4ewic=; b=CbOdX+Az/Yn9CiLLqPCpOwa2elUYSoTZiJD0QaXVlQRO7dZ4bMmtJLIMegY2yPlZRN2edH ysvYjX6FDRfpx5e2xKPdFLIgKMhj9bLL9T5D+PMUr9d5/3hAlN6MQeLolZg6BeXRqP2Pb3 5UGDgFBsXs1wqko5DB7XmYcN4iPdfbc= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-aFdj6ByXNYaFLgenFhqpaQ-1; Fri, 20 Jun 2025 13:55:28 -0400 X-MC-Unique: aFdj6ByXNYaFLgenFhqpaQ-1 X-Mimecast-MFC-AGG-ID: aFdj6ByXNYaFLgenFhqpaQ_1750442126 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A624195608B; Fri, 20 Jun 2025 17:55:25 +0000 (UTC) Received: from bgurney-thinkpadp1gen5.remote.csb (unknown [10.22.80.187]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20CFF18003FC; Fri, 20 Jun 2025 17:55:21 +0000 (UTC) From: Bryan Gurney To: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@kernel.dk Cc: james.smart@broadcom.com, dick.kennedy@broadcom.com, njavali@marvell.com, linux-scsi@vger.kernel.org, hare@suse.de, bgurney@redhat.com, jmeneghi@redhat.com Subject: [PATCH v6 0/6] nvme-fc: FPIN link integrity handling Date: Fri, 20 Jun 2025 13:55:05 -0400 Message-ID: <20250620175505.34573-1-bgurney@redhat.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 FPIN LI (link integrity) messages are received when the attached fabric detects hardware errors. In response to these messages I/O should be directed away from the affected ports, and only used if the 'optimized' paths are unavailable. Upon port reset the paths should be put back in service as the affected hardware might have been replaced. This patch adds a new controller flag 'NVME_CTRL_MARGINAL' which will be checked during multipath path selection, causing the path to be skipped when checking for 'optimized' paths. If no optimized paths are available the 'marginal' paths are considered for path selection alongside the 'non-optimized' paths. It also introduces a new nvme-fc callback 'nvme_fc_fpin_rcv()' to evaluate the FPIN LI TLV payload and set the 'marginal' state on all affected rports. The testing for this patch set was performed by Bryan Gurney, using the process outlined by John Meneghini's presentation at LSFMM 2024, where the fibre channel switch sends an FPIN notification on a specific switch port, and the following is checked on the initiator: 1. The controllers corresponding to the paths on the port that has received the notification are showing a set NVME_CTRL_MARGINAL flag. \ +- nvme4 fc traddr=c,host_traddr=e live optimized +- nvme5 fc traddr=8,host_traddr=e live non-optimized +- nvme8 fc traddr=e,host_traddr=f marginal optimized +- nvme9 fc traddr=a,host_traddr=f marginal non-optimized 2. The I/O statistics of the test namespace show no I/O activity on the controllers with NVME_CTRL_MARGINAL set. Device tps MB_read/s MB_wrtn/s MB_dscd/s nvme4c4n1 0.00 0.00 0.00 0.00 nvme4c5n1 25001.00 0.00 97.66 0.00 nvme4c9n1 25000.00 0.00 97.66 0.00 nvme4n1 50011.00 0.00 195.36 0.00 Device tps MB_read/s MB_wrtn/s MB_dscd/s nvme4c4n1 0.00 0.00 0.00 0.00 nvme4c5n1 48360.00 0.00 188.91 0.00 nvme4c9n1 1642.00 0.00 6.41 0.00 nvme4n1 49981.00 0.00 195.24 0.00 Device tps MB_read/s MB_wrtn/s MB_dscd/s nvme4c4n1 0.00 0.00 0.00 0.00 nvme4c5n1 50001.00 0.00 195.32 0.00 nvme4c9n1 0.00 0.00 0.00 0.00 nvme4n1 50016.00 0.00 195.38 0.00 Link: https://people.redhat.com/jmeneghi/LSFMM_2024/LSFMM_2024_NVMe_Cancel_and_FPIN.pdf Changes to the original submission: - Changed flag name to 'marginal' - Do not block marginal path; influence path selection instead to de-prioritize marginal paths Changes to v2: - Split off driver-specific modifications - Introduce 'union fc_tlv_desc' to avoid casts Changes to v3: - Include reviews from Justin Tee - Split marginal path handling patch Changes to v4: - Change 'u8' to '__u8' on fc_tlv_desc to fix a failure to build - Print 'marginal' instead of 'live' in the state of controllers when they are marginal Changes to v5: - Minor spelling corrections to patch descriptions Hannes Reinecke (5): fc_els: use 'union fc_tlv_desc' nvme-fc: marginal path handling nvme-fc: nvme_fc_fpin_rcv() callback lpfc: enable FPIN notification for NVMe qla2xxx: enable FPIN notification for NVMe Bryan Gurney (1): nvme: sysfs: emit the marginal path state in show_state() drivers/nvme/host/core.c | 1 + drivers/nvme/host/fc.c | 99 +++++++++++++++++++ drivers/nvme/host/multipath.c | 17 ++-- drivers/nvme/host/nvme.h | 6 ++ drivers/nvme/host/sysfs.c | 4 +- drivers/scsi/lpfc/lpfc_els.c | 84 ++++++++-------- drivers/scsi/qla2xxx/qla_isr.c | 3 + drivers/scsi/scsi_transport_fc.c | 27 +++-- include/linux/nvme-fc-driver.h | 3 + include/uapi/scsi/fc/fc_els.h | 165 +++++++++++++++++-------------- 10 files changed, 269 insertions(+), 140 deletions(-) -- 2.49.0