Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D95D628C03B; Mon, 30 Jun 2025 21:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751317343; cv=none; b=iwuYL5FJRIkAW/eJ0WTsLn5rKG3QDp8Vq4qARjQsSbrPTwJWE/WvyrxzzeSAP2T2GAcnMvdeKcNc+F/MZX8G/VBLBJ117RdfZ7oIlotrZSwO72Rk+GO4FlYNmyaFohloO7UbZjDBmPZQuyLlzSQ32oGNqVxFHSLdYCenjdBV4dY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751317343; c=relaxed/simple; bh=N707Jm9KMXuR2ET8ChZeusW3PSWze/rOruIVE22ldDI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=T1+78Sf4EYbYT6M5HP527xgtNhVJb/Q+WClkj57BLKv4TqGKFba5fPYqLM/xIzfL7OXQM0zl02/GorvXrzNtrHGGhp8mR+QWPQINw1kF54v7Vvpg2WKgmDP3tXt3POyLgzX+950biuGOXa86HEMKnjAFa+88fOYnbycFaCQ+NXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bQWN92t6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bQWN92t6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DD9FC4CEEB; Mon, 30 Jun 2025 21:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751317342; bh=N707Jm9KMXuR2ET8ChZeusW3PSWze/rOruIVE22ldDI=; h=From:To:Cc:Subject:Date:From; b=bQWN92t67dJnXoxood9fu3iG9wFO9bKtL56wQxFtVGqKzpXzD9oXRKC+rwgZHJ960 rN/UaJm5k6ml6x8VnJJaJmTL39cMS6RK438xXIHnkLfHFDWKCHMZNKJlfzWh/6LVg9 nKzshnV0j88snOoonRA1yYKhFsp3RN51HhAL4D7Qw6Pdu+iUnW6ur4C5zrMYSyu63O xQffPDOn+cPKY5XE+YqRHmB3gMjvoTYZOQxL5uv2440WxhKFJdycClJPvXdwPM65we YAls/rDvwbqr1p1DJjORgeQWG6rp+nSn+TLjeJC4uClW0siV5q4WlKI4TMCqiv39ll 5C0hSltqTO6jQ== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Fourier , Simon Horman , Jakub Kicinski , Sasha Levin , 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 1/5] atm: idt77252: Add missing `dma_map_error()` Date: Mon, 30 Jun 2025 17:02:15 -0400 Message-Id: <20250630210219.1359777-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.295 Content-Transfer-Encoding: 8bit From: Thomas Fourier [ Upstream commit c4890963350dcf4e9a909bae23665921fba4ad27 ] The DMA map functions can fail and should be tested for errors. Signed-off-by: Thomas Fourier Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250624064148.12815-3-fourier.thomas@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees. ## Detailed Analysis: **Nature of the fix:** The commit adds missing error checking for `dma_map_single()` calls in two locations within the idt77252 ATM driver: 1. **In `queue_skb()` function (line 853-854):** ```c IDT77252_PRV_PADDR(skb) = dma_map_single(&card->pcidev->dev, skb->data, skb->len, DMA_TO_DEVICE); +if (dma_mapping_error(&card->pcidev->dev, IDT77252_PRV_PADDR(skb))) + return -ENOMEM; ``` This correctly returns -ENOMEM before reaching the errout label, avoiding any cleanup issues since the DMA mapping never succeeded. 2. **In `add_rx_skb()` function (line 1857-1860):** ```c paddr = dma_map_single(&card->pcidev->dev, skb->data, skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE); +if (dma_mapping_error(&card->pcidev->dev, paddr)) + goto outpoolrm; ``` This properly jumps to the new `outpoolrm` label which removes the SKB from the pool before freeing it, maintaining correct cleanup order. **Why this qualifies for stable backporting:** 1. **Fixes a real bug**: Missing DMA mapping error checks can cause system crashes or data corruption, especially on systems with IOMMU or SWIOTLB where DMA mapping failures are more likely. 2. **Simple and contained**: The fix adds only 5 lines of error checking code with no architectural changes. 3. **Similar to approved backports**: This follows the exact same pattern as Similar Commits #1 (eni driver) and #2 (aic94xx driver) which were both marked "YES" for backporting. 4. **Long-standing issue**: The driver has existed since at least 2005 (Linux 2.6.12-rc2), meaning this bug has been present for nearly 20 years. 5. **Minimal regression risk**: The changes only add error checking; they don't modify any existing logic paths. 6. **Proper error handling**: Both error paths are correctly implemented with appropriate cleanup sequences. The commit clearly meets all stable tree criteria as an important bug fix with minimal risk and should be backported to protect users from potential DMA-related crashes. drivers/atm/idt77252.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 06e2fea1ffa92..03b3b9c7c8b5c 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -849,6 +849,8 @@ queue_skb(struct idt77252_dev *card, struct vc_map *vc, IDT77252_PRV_PADDR(skb) = dma_map_single(&card->pcidev->dev, skb->data, skb->len, DMA_TO_DEVICE); + if (dma_mapping_error(&card->pcidev->dev, IDT77252_PRV_PADDR(skb))) + return -ENOMEM; error = -EINVAL; @@ -1862,6 +1864,8 @@ add_rx_skb(struct idt77252_dev *card, int queue, paddr = dma_map_single(&card->pcidev->dev, skb->data, skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE); + if (dma_mapping_error(&card->pcidev->dev, paddr)) + goto outpoolrm; IDT77252_PRV_PADDR(skb) = paddr; if (push_rx_skb(card, skb, queue)) { @@ -1876,6 +1880,7 @@ add_rx_skb(struct idt77252_dev *card, int queue, dma_unmap_single(&card->pcidev->dev, IDT77252_PRV_PADDR(skb), skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE); +outpoolrm: handle = IDT77252_PRV_POOL(skb); card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL; -- 2.39.5