Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B3FD2EB5BA; Mon, 30 Jun 2025 21:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751317348; cv=none; b=nj4woTW1orgVjQfj0e4CHPgXhc2tVgQtZXImq6R9PnmvnvRyZ1E1J9cywLkTre3DD5lNBrNxVEz1rp+G0HM58RSOLlk8cPuBTV4Tog8rQA7HYPRSfVZ2UoBQF6EsYvv6XPol/kpm0DOJrLhAfLH4/CNQtCn0hO70/cOeHqKxRwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751317348; c=relaxed/simple; bh=J+CLqBRz7PmPkDY3/OLN4ATqpTo8cHjISzDzX0ljUek=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ivJQtGVbYUycAu+OPzVfScpU3My+eog1L0tszax42HZn3y2YL8vYE/BOpOUh/KgbsYagfOeTtaAYtFtDy4mI+g7sGwxU6nQ2z0qJuGq64Kvpae3A+AYbT5pEy9iN5vl1TtXfwfBvMwEnO3zd5fZwzLSlnOXhcvJ8AiVy8ReyIoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SZ11tipd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SZ11tipd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1E02C4CEF4; Mon, 30 Jun 2025 21:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751317348; bh=J+CLqBRz7PmPkDY3/OLN4ATqpTo8cHjISzDzX0ljUek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SZ11tipdYP0oKl0jskjB/tqx1nuXCV5W30v3iTeuQO1mEhkakAEViMT2Sr5srtI/+ L4u5dCC7xKz2S5E6fOb5gBjhqekef/XNH21qCTGmd69D0OXNQNmSdaUMZzUu43IaTP OtrFTHQ/XemLc/ep8tdiCurBV90Tq5rfq/5oz9eAv7zrom49oNBQVCvF5B22gPAYRD JmM/JKFaI7gD7qmaM5Mat7gddRXZW/i1QAUyH2d7BUaniMp6k6mus89Aan9MRxVztY M0ZusGrFls+jhtlecnSAHAxH27v+CkfBJuniT2rcaEOrRoeydX1xwhubCLo7PVSxL1 8/D76g6z7CMSw== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Nicolas Pitre , Greg Kroah-Hartman , Sasha Levin , mingo@kernel.org, tglx@linutronix.de, gnoack@google.com, kees@kernel.org, aha310510@gmail.com Subject: [PATCH AUTOSEL 5.4 3/5] vt: add missing notification when switching back to text mode Date: Mon, 30 Jun 2025 17:02:17 -0400 Message-Id: <20250630210219.1359777-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250630210219.1359777-1-sashal@kernel.org> References: <20250630210219.1359777-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.295 Content-Transfer-Encoding: 8bit From: Nicolas Pitre [ Upstream commit ff78538e07fa284ce08cbbcb0730daa91ed16722 ] Programs using poll() on /dev/vcsa to be notified when VT changes occur were missing one case: the switch from gfx to text mode. Signed-off-by: Nicolas Pitre Link: https://lore.kernel.org/r/9o5ro928-0pp4-05rq-70p4-ro385n21n723@onlyvoer.pbz Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees for the following reasons: 1. **It fixes a real bug affecting userspace programs**: The commit addresses a missing notification that prevents programs using `poll()` on `/dev/vcsa` from being properly notified when the VT switches from graphics mode back to text mode. This is a functional regression that breaks userspace applications monitoring VT state changes. 2. **The fix is minimal and low-risk**: The change adds only a single line - `notify_update(vc);` - in the `do_unblank_screen()` function. This follows an established pattern where `notify_update()` is called after VT state changes to notify userspace watchers. 3. **Consistent with existing code patterns**: Looking at the codebase, `notify_update()` is already called in similar contexts throughout vt.c. For example, in `vc_do_resize()`, we see: ```c vt_event_post(VT_EVENT_RESIZE, vc->vc_num, vc->vc_num); notify_update(vc); ``` The same pattern should apply when unblanking the screen. 4. **Similar commits were backported**: The historical commits provided show that previous fixes adding or correcting `notify_update()` calls were marked for stable backporting (all three YES examples had `Cc: stable@vger.kernel.org`). These commits fixed similar issues where userspace poll() notifications were missing. 5. **Clear symptom and fix**: The bug has a clear symptom (missing notifications when switching from graphics to text mode) and a straightforward fix that directly addresses the root cause. The `leaving_gfx` parameter in `do_unblank_screen()` specifically indicates this transition scenario. 6. **No architectural changes**: This is purely a bug fix that restores expected behavior without introducing new features or changing the architecture of the VT subsystem. The commit meets all the criteria for stable backporting: it fixes an important bug affecting userspace, the fix is minimal and contained, and it follows established patterns for similar fixes that were previously backported. drivers/tty/vt/vt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index e58dceaf7ff0e..3db8efd58747d 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -4368,6 +4368,7 @@ void do_unblank_screen(int leaving_gfx) set_palette(vc); set_cursor(vc); vt_event_post(VT_EVENT_UNBLANK, vc->vc_num, vc->vc_num); + notify_update(vc); } EXPORT_SYMBOL(do_unblank_screen); -- 2.39.5