Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A180228C03B; Mon, 30 Jun 2025 21:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751317351; cv=none; b=lS0QYCrV/igaRTl3ungTvoykPR2L8b1O/HqbOi1AmAUSf2h9IdVUKwsp7fJ2Lry7T5ynU0EC/lokOsUZyCVS9DaaPovTd3pnNHxOGp/SUWnSiBoxEfcB8Wn7DnuBTO3/ajvUHh+TUVNDFhH4VZQ08UzYEjMAZorgT2ADdTubzuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751317351; c=relaxed/simple; bh=Lano50Slb9UzN+8YFUNef/QSxixfXdRu5+gxbR5B1Ao=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UM1PsWu0twUuXdibWHruIsFenfKvWZaYYKVMvFuZXQzWro/2HGHRH6POXCrP5nAJgo+5bnVripAlcNWsYSj4NyCSmDwvHTn9MF5ADFqBdPXDVv7joHc3QIv97VbJBmovqNr0qMPezp+Djw81jPxMMZeyY9feBHtOpDeQyo73uZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EqquFVPf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EqquFVPf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 758E9C4CEEF; Mon, 30 Jun 2025 21:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751317351; bh=Lano50Slb9UzN+8YFUNef/QSxixfXdRu5+gxbR5B1Ao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EqquFVPfvILSMMnKgT29ElKeF989M+nrwXPRazqqM9a2uOqrzRzUUiRlJjh4UG7Yg 8QhowIJ/Kg71QFrkAuXF2V3sNO2A2mhYZ9u5bOZqCy4iFHBEytAdrXKhyyi2I9BQ3g ITLtbv2htF79lCctx0OxNI03AynE6y0TnPOok9/7kTnDFbo5adusgbGbFa4vLrvRDs hCGwUoJ8ktFyUYxsKxW+9Lj813y72qqSO37PnefpzZ5k6jawc53jRjJPm5rJyY2emY OXYlSprqQFPcNgtO7jpQHpBUfLpU1PYn1NN9++wZu7sHeWjLQNpK3wNw7cwMUgU4Sg c9cD/EMvEmOOQ== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: "Chia-Lin Kao (AceLan)" , Jiri Kosina , Sasha Levin , jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 5/5] HID: quirks: Add quirk for 2 Chicony Electronics HP 5MP Cameras Date: Mon, 30 Jun 2025 17:02:19 -0400 Message-Id: <20250630210219.1359777-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250630210219.1359777-1-sashal@kernel.org> References: <20250630210219.1359777-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.295 Content-Transfer-Encoding: 8bit From: "Chia-Lin Kao (AceLan)" [ Upstream commit 54bae4c17c11688339eb73a04fd24203bb6e7494 ] The Chicony Electronics HP 5MP Cameras (USB ID 04F2:B824 & 04F2:B82C) report a HID sensor interface that is not actually implemented. Attempting to access this non-functional sensor via iio_info causes system hangs as runtime PM tries to wake up an unresponsive sensor. Add these 2 devices to the HID ignore list since the sensor interface is non-functional by design and should not be exposed to userspace. Signed-off-by: Chia-Lin Kao (AceLan) Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees. Here's my extensive analysis: ## Key Characteristics of This Commit: 1. **Fixes a Critical User-Facing Bug**: The commit addresses system hangs that occur when userspace attempts to access non-functional HID sensor interfaces through iio_info. This is a serious usability issue that can make the system unresponsive. 2. **Minimal and Contained Changes**: The patch only adds two device IDs to existing infrastructure: - In `drivers/hid/hid-ids.h`: Added `USB_DEVICE_ID_CHICONY_HP_5MP_CAMERA` (0xb824) and `USB_DEVICE_ID_CHICONY_HP_5MP_CAMERA2` (0xb82c) - In `drivers/hid/hid-quirks.c`: Added these two devices to the `hid_ignore_list[]` array 3. **Zero Risk of Regression**: The changes only affect the specific USB devices (04F2:B824 and 04F2:B82C). No existing functionality is modified, and no code logic is changed. ## Comparison with Similar Commits: This commit is nearly identical to **Similar Commit #1** (which was backported), where a QUANTA HP 5MP Camera (0408:5473) was added to the ignore list for the exact same reason - non-functional sensor causing system hangs. Both commits: - Target HP 5MP cameras with non-functional sensors - Use the same fix approach (adding to HID ignore list) - Prevent system hangs when accessing the sensor ## Alignment with Stable Kernel Rules: The commit perfectly aligns with stable tree criteria: - **Fixes a real bug**: System hangs are critical issues - **Already in Linus' tree**: Signed-off by Jiri Kosina (HID maintainer) - **Small change**: Only 4 lines of actual code changes - **Obviously correct**: Simply adding device IDs to an ignore list - **No new features**: Pure bugfix - **Hardware-specific**: Only affects users with these specific cameras ## Historical Precedent: Looking at the provided similar commits: - 4 out of 5 hardware quirk commits were backported (80% backport rate) - All commits fixing system hangs or device disconnections were backported - The only non-backported commit (#4) involved architectural changes to enum handling This commit follows the exact pattern of successfully backported hardware quirks, making it an excellent candidate for stable inclusion. drivers/hid/hid-ids.h | 2 ++ drivers/hid/hid-quirks.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 3787bd508b616..d2e355a9744a0 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -280,6 +280,8 @@ #define USB_DEVICE_ID_ASUS_AK1D 0x1125 #define USB_DEVICE_ID_CHICONY_TOSHIBA_WT10A 0x1408 #define USB_DEVICE_ID_CHICONY_ACER_SWITCH12 0x1421 +#define USB_DEVICE_ID_CHICONY_HP_5MP_CAMERA 0xb824 +#define USB_DEVICE_ID_CHICONY_HP_5MP_CAMERA2 0xb82c #define USB_VENDOR_ID_CHUNGHWAT 0x2247 #define USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH 0x0001 diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 2cf58e3016e7b..d1cfd45f2585a 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -732,6 +732,8 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE(USB_VENDOR_ID_AVERMEDIA, USB_DEVICE_ID_AVER_FM_MR800) }, { HID_USB_DEVICE(USB_VENDOR_ID_AXENTIA, USB_DEVICE_ID_AXENTIA_FM_RADIO) }, { HID_USB_DEVICE(USB_VENDOR_ID_BERKSHIRE, USB_DEVICE_ID_BERKSHIRE_PCWD) }, + { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_HP_5MP_CAMERA) }, + { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_HP_5MP_CAMERA2) }, { HID_USB_DEVICE(USB_VENDOR_ID_CIDC, 0x0103) }, { HID_USB_DEVICE(USB_VENDOR_ID_CYGNAL, USB_DEVICE_ID_CYGNAL_RADIO_SI470X) }, { HID_USB_DEVICE(USB_VENDOR_ID_CYGNAL, USB_DEVICE_ID_CYGNAL_RADIO_SI4713) }, -- 2.39.5