Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EBF12EF653 for ; Fri, 4 Jul 2025 10:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751624736; cv=none; b=aJKtj6M6jdw7cU/T3uHnjnQSuGS/3BJngpD4r4EZ1otSTrfesRByspwla6K0NRzLay20QIGBM1cMombtsoW2OnmG62A3p9mHtzb3HqJUlszPggvTgD9sKtYYYOoAonFp1VjvOlU3VAr7Nm00LQCSPEhrQXEddtQo/4YZujayADk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751624736; c=relaxed/simple; bh=N0i0mDmhVdZqrTyFYSoYTge/lbt5vfjL3ApU/H749m0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DfDVLGVqdjFmadBVmo/nSIOgHXURXpa3CdjV7NT1IkPNY2TK9CtGo/inFItc4gYbz+a/E5tP1rdsRcnOk9FSv6okWfpC2aIyS2fcnvcAmSrOx/f3OQiqjN4HrdyoI1N9OQfYI4djjjrcU7WEceKrqW5V7ONJbRgRyA0s+VOopvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Dv4e5rzU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dv4e5rzU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cQQqBmPuJGjYXvvpwjiHFMj2XowEg2vBjzCyliDZdkg=; b=Dv4e5rzUQuJCJ7ENSuydkFd18om1f8WJUMM3YG8INvtYAmiObPBojwsb943cyS9gzH0Un3 NRufT3WHp88ntXe/muVCv3syPsZ1/IoDnnEQYnZGE1rEfILbM6eCHVu4VQ6jeiY1JN+y4w OuqG7S9UlZWH2cRKBaZ8BAvOblK/4Tc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-N1E1T-kuMsygUEx2Ps3Mbg-1; Fri, 04 Jul 2025 06:25:32 -0400 X-MC-Unique: N1E1T-kuMsygUEx2Ps3Mbg-1 X-Mimecast-MFC-AGG-ID: N1E1T-kuMsygUEx2Ps3Mbg_1751624731 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451d2037f1eso4652775e9.0 for ; Fri, 04 Jul 2025 03:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624731; x=1752229531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cQQqBmPuJGjYXvvpwjiHFMj2XowEg2vBjzCyliDZdkg=; b=gjL6ebcKcGNWSSL7Ff9lvW1RLC6LEFTLWlQfLHOvV96Xk6/H1SeHngOzzszuI2qxl9 tmTY3acLADC+ZOxK9FWseRjI28aJnQUpXSRHFPqs4Ygv8pg2Jv5eC0pxotrpTynO+v0h P4q6yzw1leenQGVVlUXunoYb9+Nx/By5oWl6Pm9fXDIV2W2SDIzAuKq6D6CIJuYvK8Vu 0dT5bsswSU9y38FeYzuVBmvNSLYA9GMGox4b6IN2e6M0sGLJfBd7zYGgnDFs6Kg1yvg7 7I2OauhxiWzG0Q2N01roTmUfihrMNwLCBf8L9fuqfLeJ5yCkk0tXiGOtWa3/KspXJUD9 JFyA== X-Forwarded-Encrypted: i=1; AJvYcCVk7DZ/X50rhf/pJZB2y706IYlD6bRpY1X4IcLfUQdrvpd4UIn7XYVWQ5ECXxxC9bowXUi2Z2m5uQA=@vger.kernel.org X-Gm-Message-State: AOJu0YxurSZtA97PQU7GpV5fZoSTTKIsdrc0jWvYyxHufMIAk/PvgZTe WPZ3RPZNN0s41m7VdzeFn2K3qeuG7dtUsdlt3DUWUXbFtmn7/9cgo1OpkVCxECaRHiJrZB2W8QH q+G1JNItWkqomu1dk1ROHa3eADyrxiO/CFiD1FRr7B60e6ChbzvojPOcuFjmIfg== X-Gm-Gg: ASbGncu8posqDFXQOSg+H5iVWRNbo9b7X6W1qEYZuYMKuR0Ew8pFmcm0BB/ktSoo6KW RoYZoBUaTCi+A/FoWVg2kjikRYF26rreNJ+7N6+r6d8/CJcfQ90DHFUILBKHmaWeVWZbFIEPz76 GmA49VBGRbakrDfKiVPNeBoiSg14f/ASMnhldpKZx3+0ouBfj+JVYDzvdRUKfiSFNNXFuDA+tie B3uoiIz6S4kAmqKXsO2PpTAkmK0bbmZAvPQKktsVPN897dSidHu2Wycr5gUlpGTI6vFle+b6qTV DjsxRLi2ATEcjxvII+rJhYcQ4ao0XzQchb6IS0+GsihEXJKvjpeCKqCSseBiCS43qgyQ8hXsx3Z uWAlnDQ== X-Received: by 2002:a05:600c:1c19:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-454b4e74ba9mr16507785e9.9.1751624730969; Fri, 04 Jul 2025 03:25:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2JCKcFSESlucn/AkzEEQU5f9yWEwz5OrnoWVnvSvIPUgrXnOXbfSZDcsxaTgozbAMtqKAdQ== X-Received: by 2002:a05:600c:1c19:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-454b4e74ba9mr16507075e9.9.1751624730349; Fri, 04 Jul 2025 03:25:30 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-454a9989fcesm51185055e9.16.2025.07.04.03.25.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:25:29 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 01/29] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Fri, 4 Jul 2025 12:24:55 +0200 Message-ID: <20250704102524.326966-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Acked-by: Zi Yan Reviewed-by: Lorenzo Stoakes Signed-off-by: David Hildenbrand --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index d3e00731e2628..fcb60233aa35d 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -94,12 +94,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, if (!trylock_page(page)) continue; - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); -- 2.49.0