Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 260A329A30A for ; Mon, 7 Jul 2025 14:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751900338; cv=none; b=fmfXvZ3RyQ2TodWQFxCpY5F+VF3jQX75NmkAyho7kARVcT89j0fWGL5ruMXwBRhT8gTz/EaTfnSD8vfH2es4v1qtjCUceMW3I9vSDP/j7kq4f2vvo9fF65b6OQvmgCkExLV2ciPruDxIBTJbgiLwYatzCzFmA9c9lVst7MKSKX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751900338; c=relaxed/simple; bh=KkfY6/i2TmUpBCFlrfNOFt/vqWBA3eLnS7GdcXg8YQ4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D5Itn2fs5U5NY2Q85GRdDoofeBHEibcybEG4y0NSUm0kbf1HFpRWCDoFpuYzKetaOjk04UKP4+7y0yN2l0ZwAUYYH4TnpFjA2SQqhihwMw/hfzStZjDVnel+ywbBbse5Vbeft8arVUpa03xzs1Kx7QukModxabCel8MGqXdPSeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from inp1wst013.omp.ru (81.22.207.138) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Mon, 7 Jul 2025 17:58:45 +0300 From: Ismagil Iskakov To: CC: Ismagil Iskakov Subject: [PATCH BlueZ 1/1] obexd/client: prevent double freeing Date: Mon, 7 Jul 2025 17:52:42 +0300 Message-ID: <20250707145242.2356210-2-i.iskakov@omp.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250707145242.2356210-1-i.iskakov@omp.ru> References: <20250707145242.2356210-1-i.iskakov@omp.ru> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.1, Database issued on: 07/07/2025 14:37:04 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 19 X-KSE-AntiSpam-Info: Lua profiles 194596 [Jul 07 2025] X-KSE-AntiSpam-Info: Version: 6.1.1.11 X-KSE-AntiSpam-Info: Envelope from: i.iskakov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 63 0.3.63 9cc2b4b18bf16653fda093d2c494e542ac094a39 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 81.22.207.138 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 81.22.207.138 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;81.22.207.138:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;inp1wst013.omp.ru:7.1.1 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 81.22.207.138 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 19 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 07/07/2025 14:38:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 7/7/2025 1:07:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit image_properties_complete_cb frees 'contents' after a failure. However obc_transfer_get_contents does it beforehand. --- obexd/client/transfer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/obexd/client/transfer.c b/obexd/client/transfer.c index 668cefa40..a7d00896f 100644 --- a/obexd/client/transfer.c +++ b/obexd/client/transfer.c @@ -971,6 +971,7 @@ int obc_transfer_get_contents(struct obc_transfer *transfer, char **contents, if (ret < 0) { error("read(): %s(%d)", strerror(errno), errno); g_free(*contents); + *contents = NULL; return -errno; } -- 2.34.1