Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAC9EC8303C for ; Mon, 7 Jul 2025 17:23:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uYpXz-0003V3-0T; Mon, 07 Jul 2025 13:22:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYpWV-0000o1-Mt for qemu-arm@nongnu.org; Mon, 07 Jul 2025 13:20:59 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uYpWP-00058D-Ot for qemu-arm@nongnu.org; Mon, 07 Jul 2025 13:20:56 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4537edf2c3cso37140155e9.3 for ; Mon, 07 Jul 2025 10:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751908847; x=1752513647; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RFonhSB51r1m9DRDPq3gxW3IKaSRsXZYDkC267ansE0=; b=tX5jj3y6GzOlWOO/ey+MQQQDZWQeuOK7XpbtwCtlOQoxxs76dz884cYpP/0bltCmZB oqVX5nJhP6SfaqfNCMLZ27pYjgSJ6W85nibSfS2/rAO4bEA//DrykmlcQ6aaXsgW849R dkJpuVl22zxEuLSfxPiHNYq71e0von0zZagxgl7V7cl9gUPuqlheENGZ+AWmzV72Er9o 0hNLElbsFX3kkvVi1UaMg/+0aONG+dT/Nqi6O4W6nP4OE5OCe6Kr+hWU9EJDRp/O1ktO so1weJGw8GgWUpi7ViNX2ePS1kskk0kmRIhDzQKxlZ6rTLhnNQ89sw7U+/GY4aEMwcSx 6PEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751908847; x=1752513647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RFonhSB51r1m9DRDPq3gxW3IKaSRsXZYDkC267ansE0=; b=X9rIVJo80fFkGTa897Htx/SlqkvkGBeSiDuF158cuZwqHCvpFlL+bxj8yDNN/7D07r OD/tuN8F3LC/92ycvbZEsd8HvjDf1nbkIFSdgWKHlpgoiRk235qR8xybqskNZFoM4pFL Fdbc033JSfHiskFWuh33LJXcIdQ/FJe1SStyMcKdYdr7JnMtmiEIrgDBa3V476pm16vt ubK/K/rGN8+9TgByGX1s70HMkX+iDHd4OiOpOcDYlSjXKH+fQcgWfogkJY3ki25pSxV3 GltVjmgoVtWV8jB6C4bDYXrAmglvtR1zG0tTuJwtTs7wiBsR9TGg4Kltm5RONKW+AYSv z1Mg== X-Forwarded-Encrypted: i=1; AJvYcCVBzHY0DJJeefjqI+KjDiCt0V6vHLKsrZhWw3BAfSSkuj9h8YKn7KiD4/Goe22PpCU81+q9uzxlWg==@nongnu.org X-Gm-Message-State: AOJu0Yy2+a4OH9bdrK4P3yKJ1lN7nYHjvVVpMXIxQPGyE/qUKywyXTUB CEiKkMqBe4au04BlvDOtZotJr8XOtjmF9v96hYh7xwqUGkEVR/0f7E56uUNSkD8fKZo= X-Gm-Gg: ASbGncvG1KarSCt9MuTU1WZNACHqgZD1XUQJHG2+qQP8kK51AjDnO+YcG8AGbapXgd4 3+wMAlWCVbPe4VQOX6d6NaDj62sqhHOCBv8R6bGM7ArRAY+A3+nljcjyWOIBrlldkFQPl47VF4p KuhnqiiJbHgb2RePZEFnRox9bb2VOCQ30RdEG+y4qfGWrBHS5usmwL5DGkBAbgLljkmx32oJQU/ 5vthHvuYCtWTcDSmp8aaOwcuk79R7NlIpnOQgFHhLvTM4F00n5gLpDxfJF+umXu1QH1bs3Ub/Nj PKi0/vsE5tbuXAdrlKkX5tFFKv8l11yrbUROXouOdlJopEOz4rnARLua1NfUtkEudnkhkSCc+Ea 6GiHR4NnBMX6h5Ca+W4HI3S7liOtZL7oWoaEq X-Google-Smtp-Source: AGHT+IGhI82KjTmq2GBYUFjCnNZWFDyft3wJhBMSIY8cUy9DDxHlM8oqhAuXnW0mZvX6TO7CAfhsVw== X-Received: by 2002:a05:600c:818c:b0:43c:efed:733e with SMTP id 5b1f17b1804b1-454ccc799d0mr4855545e9.14.1751908846639; Mon, 07 Jul 2025 10:20:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bcf35csm147172605e9.20.2025.07.07.10.20.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Jul 2025 10:20:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , qemu-block@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, Paolo Bonzini , qemu-riscv@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v6 07/14] gdbstub/helpers: Replace TARGET_BIG_ENDIAN -> target_big_endian() Date: Mon, 7 Jul 2025 19:20:01 +0200 Message-ID: <20250707172009.3884-8-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707172009.3884-1-philmd@linaro.org> References: <20250707172009.3884-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Check endianness at runtime to remove the target-specific TARGET_BIG_ENDIAN definition. Signed-off-by: Philippe Mathieu-Daudé --- include/gdbstub/helpers.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h index 6f7cc48adcb..1411b136d5c 100644 --- a/include/gdbstub/helpers.h +++ b/include/gdbstub/helpers.h @@ -16,6 +16,7 @@ #error "gdbstub helpers should only be included by target specific code" #endif +#include "qemu/target-info.h" #include "exec/tswap.h" #include "cpu-param.h" @@ -55,18 +56,14 @@ static inline int gdb_get_reg64(GByteArray *buf, uint64_t val) static inline int gdb_get_reg128(GByteArray *buf, uint64_t val_hi, uint64_t val_lo) { + bool be = target_big_endian(); uint64_t to_quad; -#if TARGET_BIG_ENDIAN - to_quad = tswap64(val_hi); + + to_quad = tswap64(be ? val_hi : val_lo); g_byte_array_append(buf, (uint8_t *) &to_quad, 8); - to_quad = tswap64(val_lo); + to_quad = tswap64(be ? val_lo : val_hi); g_byte_array_append(buf, (uint8_t *) &to_quad, 8); -#else - to_quad = tswap64(val_lo); - g_byte_array_append(buf, (uint8_t *) &to_quad, 8); - to_quad = tswap64(val_hi); - g_byte_array_append(buf, (uint8_t *) &to_quad, 8); -#endif + return 16; } -- 2.49.0