Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A9A8C83F1B for ; Thu, 10 Jul 2025 14:37:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A675710E8E6; Thu, 10 Jul 2025 14:37:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.b="fT2rnsEK"; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by gabe.freedesktop.org (Postfix) with ESMTPS id A383910E8E8 for ; Thu, 10 Jul 2025 14:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l/VowybUVqfBfJLENTNbFHp0kWze8NXY/smu/Q+m5Vc=; b=fT2rnsEKw3ORydq38vuGxhbBJs 8E3Qn8Z7TCGVBWaHW+32Ia9tegauI9oonq2liG7d7BOoFTB/mvKxhkxoTdK69WGEz21m2JUHYCHBA VGo5bFyuaCpvdymX3geHkeBUZbUE30fm3ezwDl9/Tcac0YSAQtpS6O47bm886Amw9bgnT4t401jQV CazUDxCgRxKb1Kk0u5JJ+IJzGaRkpuaOPBr2173ClXyt1I95GAc/VM6BXhmXyPgZ5F8nKo9jynkeZ 2hj5DedthD0vNmvJhtKC/u7nYB4T3C24vSXDq2OjVibi4fhf4mpS0teODSGO13OyViwlderJSAFWr iaZA6F6A==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZsOw-00000009FLo-16vX; Thu, 10 Jul 2025 14:37:30 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 64209300158; Thu, 10 Jul 2025 16:37:29 +0200 (CEST) Date: Thu, 10 Jul 2025 16:37:29 +0200 From: Peter Zijlstra To: Borislav Petkov Cc: Sean Christopherson , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Paolo Bonzini , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, Kevin Loughlin , Tom Lendacky , Kai Huang , Ingo Molnar , Zheyun Shen , Mingwei Zhang , Francesco Lavra Subject: Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions Message-ID: <20250710143729.GL1613200@noisy.programming.kicks-ass.net> References: <20250522233733.3176144-1-seanjc@google.com> <20250522233733.3176144-4-seanjc@google.com> <20250710112902.GCaG-j_l-K6LYRzZsb@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250710112902.GCaG-j_l-K6LYRzZsb@fat_crate.local> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jul 10, 2025 at 01:29:02PM +0200, Borislav Petkov wrote: > On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > > index 079c3f3cd32c..1789db5d8825 100644 > > --- a/arch/x86/lib/cache-smp.c > > +++ b/arch/x86/lib/cache-smp.c > > @@ -19,3 +19,14 @@ void wbinvd_on_all_cpus(void) > > on_each_cpu(__wbinvd, NULL, 1); > > } > > EXPORT_SYMBOL(wbinvd_on_all_cpus); > > + > > +static void __wbnoinvd(void *dummy) > > +{ > > + wbnoinvd(); > > +} > > + > > +void wbnoinvd_on_all_cpus(void) > > +{ > > + on_each_cpu(__wbnoinvd, NULL, 1); > > +} > > +EXPORT_SYMBOL(wbnoinvd_on_all_cpus); > > If there's no particular reason for the non-GPL export besides being > consistent with the rest - yes, I did the change for wbinvd_on_all_cpus() but > that was loooong time ago - I'd simply make this export _GPL. Uhhhh, how about we use this fancy export to known modules only thing for this? These are typical things we do *NOT* want people to actually use.