Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D460F286D5D for ; Wed, 16 Jul 2025 03:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752635176; cv=none; b=D+lihUb1baUyIbxvk7OVO/+UoxPD1xukvl3h6dXiJ0QMUoeKm7KoUMKRr8rIvskWu1YrjnDyxnF8XTJcPwByicC81Fsvd/gmuomz0RjrjEzZjixQh0y3Gr3XGRyEnhImqznMwfJkoNE5EYPayMBWtFU/2VSn4z38vUsjbPvQHS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752635176; c=relaxed/simple; bh=yvEdgs2nXUWjdMl9gW7ScSBLyyxJCqlOM9mBp2BycIg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ry6/qCkpAYUwqWo59fWiCuocmXSxp8vOogHumzy4Ox2GQXUs3lzmUbGrcZlBfUCf41TNmWQJxaR+wtLmal1YjjoMjVxMeqbT40UKK/cHYO/6zns1IqpxW6gD3rXZ7Tg9DkvEtr9BVBPDJAnTyOyK6sOjQxw+b5rPcUvQIVsMx7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=P+6l719B; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="P+6l719B" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3121cffd7e8so4809666a91.0 for ; Tue, 15 Jul 2025 20:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752635173; x=1753239973; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=JJyiXrcxEaOrLnExvfxF4iaGO8N7lUzqsD5ouhDVNBI=; b=P+6l719BHTkQKALHa9oefQGZyU70dYLR0NIgwJzdpVf+dR/f1xEoAP1/9fkm9+uQNH AjAxSZIh3vqEAPa221rbuTgbf7Dpmt82q4UcNcOG/QmXynirBSevD0pTY2W8F1UvepZO ajJTEmhxAPL59aKZYZCfAi9OVQ+rJ1kD0udEOIfaDDsKuStDf2obYqoPTTQz5loz8oys ZT+L7fQDiyHAT2D08T5GvA9Yw/TSGLTjG55n3/hnUoNT6FHlrs1DDP9Op7AAWKdzOLJ8 sfK8mo94+ikN6d38Jd1TLD/QXAGFMEb8ouxiu34BYf1s5zG4KY/Q/Dlvl3PI/3XuV4X/ 9Rxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752635173; x=1753239973; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JJyiXrcxEaOrLnExvfxF4iaGO8N7lUzqsD5ouhDVNBI=; b=gbaN38Winu4lmws/phGt9PYoY90Dr+w/V18fQgfWSUqu0+KVwx04lHU+bUVvxdeAQI e9X9og6Wd/aZnBk+HS01nZpZwLN6Cvs5F/IZZTknuxTHPFdTsmMYB469mUGUCFQa0ake 1n7pw0Zacpo298YtqbZIfpBTCmoSg/zBSeGtptRWNKIo2iNeZqk177yhrCl5YXKnaIUy ag+CpuVn4kXWtINs1bVANTkeySKIjvXlZELafbg/AiLI5vsEVVixoKNJg7CNQSfUPFfl lIQjNQtCvKAsiTbSW2c2YaJBJKMUkIA0h9m6N7GXXLwjvIpB/ea/RjMYFzlHy8RzhnrP uhAw== X-Forwarded-Encrypted: i=1; AJvYcCUgDnHgFoX/h2FEOo0fhSKOqwmc78teA22xoCORuM5F2ivIhb3alwn87jkUqb2oIiORPsJPxpkS6tH/rJG7@vger.kernel.org X-Gm-Message-State: AOJu0YzMWu5Z4mvOzK1gqmSSBvYkBgtTSB4P4ZCUdhxOVzLtC90EdZqM ZOHUISfRPcLi9HJjAdvMsVRpK5j5hqVlHn4lgqBn8t8XL23EySyjJLLgZYrSB0z8BzsOa05XhJl ti0gUSQ== X-Google-Smtp-Source: AGHT+IFDGwwmBom5R3AeCsNrmsJsGaDmKZ6nwxto47OpXfv54XBWKzi5o3ZDO8E9HG9YurznkyjmKbtvlxI= X-Received: from pjg12.prod.google.com ([2002:a17:90b:3f4c:b0:312:df0e:5f09]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1fc3:b0:30c:540b:9ba with SMTP id 98e67ed59e1d1-31c9f44bc2dmr1486650a91.10.1752635173229; Tue, 15 Jul 2025 20:06:13 -0700 (PDT) Date: Tue, 15 Jul 2025 20:05:55 -0700 In-Reply-To: <20250716030557.1547501-1-surenb@google.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250716030557.1547501-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250716030557.1547501-7-surenb@google.com> Subject: [PATCH v7 6/7] fs/proc/task_mmu: remove conversion of seq_file position to unsigned From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" Back in 2.6 era, last_addr used to be stored in seq_file->version variable, which was unsigned long. As a result, sentinels to represent gate vma and end of all vmas used unsigned values. In more recent kernels we don't used seq_file->version anymore and therefore conversion from loff_t into unsigned type is not needed. Similarly, sentinel values don't need to be unsigned. Remove type conversion for set_file position and change sentinel values to signed. Signed-off-by: Suren Baghdasaryan Reviewed-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka --- fs/proc/task_mmu.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 751479eb128f..b8bc06d05a72 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -135,7 +135,7 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, if (vma) { *ppos = vma->vm_start; } else { - *ppos = -2UL; + *ppos = -2; vma = get_gate_vma(priv->mm); } @@ -145,11 +145,11 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, static void *m_start(struct seq_file *m, loff_t *ppos) { struct proc_maps_private *priv = m->private; - unsigned long last_addr = *ppos; + loff_t last_addr = *ppos; struct mm_struct *mm; /* See m_next(). Zero at the start or after lseek. */ - if (last_addr == -1UL) + if (last_addr == -1) return NULL; priv->task = get_proc_task(priv->inode); @@ -170,9 +170,9 @@ static void *m_start(struct seq_file *m, loff_t *ppos) return ERR_PTR(-EINTR); } - vma_iter_init(&priv->iter, mm, last_addr); + vma_iter_init(&priv->iter, mm, (unsigned long)last_addr); hold_task_mempolicy(priv); - if (last_addr == -2UL) + if (last_addr == -2) return get_gate_vma(mm); return proc_get_vma(priv, ppos); @@ -180,8 +180,8 @@ static void *m_start(struct seq_file *m, loff_t *ppos) static void *m_next(struct seq_file *m, void *v, loff_t *ppos) { - if (*ppos == -2UL) { - *ppos = -1UL; + if (*ppos == -2) { + *ppos = -1; return NULL; } return proc_get_vma(m->private, ppos); -- 2.50.0.727.gbf7dc18ff4-goog