Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F498347B4 for ; Tue, 22 Jul 2025 01:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753149201; cv=none; b=gnvzlqvOSEiSqjscQw5VLr3yW3FKJ7Fiz9d246ZDt+87kgE7BOBnwLPgPz/HqfrRQKVAB/Ih64K6ZmeM8RurDeifaa0sizv5ar/wEi6CSrP56af7xrMXY6ww5b6GnXSrihl4dMQA4ooBgKNOWc59hTDgVSN/mbEYAmHT7QSkcfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753149201; c=relaxed/simple; bh=PIlerTwii7wKspt/l05RAiot54ciwnajfn64bgA8Nkc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=H76gKZ5EmRETm/odA4S7GuwzEyETpJv6Q/q5c7TNd7/JxCk9K1N+3j5WRuk+yhuXNy3aKsinCcthay2+8HWHYe/nUSCyugLKyPHB0gPPeJdbc51oqEFKAejlmP0A11pkPZQG5Ua8rwjTIVn3GoVSbSw3dzuOUqBAlu7OnT4gGyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com; spf=pass smtp.mailfrom=brighamcampbell.com; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b=afOOiuKD; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=brighamcampbell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brighamcampbell.com header.i=@brighamcampbell.com header.b="afOOiuKD" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-235f9ea8d08so41325205ad.1 for ; Mon, 21 Jul 2025 18:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brighamcampbell.com; s=google; t=1753149199; x=1753753999; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=02hyzrs3C6jwWph1NhtzQUl897VWViCvH01In3YsMDc=; b=afOOiuKDXTSM++Kl17PMq06d9UygNhdITO2xU8b3Hg63eo18r2unWP7ypkJRxEro+A H2WoEGx9ATfrC0BG1kouraZy2bVp7WIOYtKwBSea1KGHHxguzZHzKYz6aZi8IsUbV+tL WRbWUOzvVXoadAXq+YQPc/yj7vKPc3mhYOVe4mFZwuZfvRpgCo5epg+DL0OqvY95hF/w Lq5QSb8Kh4TMiKPKOD0IYIJZ1RqYDUdAH4QTHOtWtKqisLVqhrbrGWv/A9DPlFyg7Q9i q2FOnnuVg/LMeWpJAKTYTjDZjE0nR/tX9wXCwANOKS4TweAnTPkBPgLsdf7+VZt9ifcr LyKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753149199; x=1753753999; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=02hyzrs3C6jwWph1NhtzQUl897VWViCvH01In3YsMDc=; b=PiZJBNE3CnSCSFTPEEtnQvQy/4uucdM7wVe2nUrmYpXCWKIDE3tRAI1sDbul0+6ZR4 Xxiqc9q044PVxdlEpimTh95MSorD0CPrc/fhj1zXeKjwwxqBu2fsrQ/RFwe39WT0ZkqL jcdCRmHrsWkzsQtLIOGrUQ/k2Z79Fe7hh3btcdSEBSa8DJT53PuEOW/3y2lhPcot2+gx HEurlOND34VtIJNF8LNSnXS4DDED9DRKpGk8cKJx0r6zpIZSES6XsNPSJV58NW0HU95O l5SMfxDmjvnOgdJpQS5F7eBbtrNqZqm84X5Ga6vik/qpI7Ka7sBlyJa5WRER3Dbtd00f T0HA== X-Forwarded-Encrypted: i=1; AJvYcCWwLfaplH8Js/CmWTIYu40VBvtLHLuwdBHmN496YphiEPKB5HTeUwRAhIkYXjpyWGG02B5eKxd3lvg=@vger.kernel.org X-Gm-Message-State: AOJu0YwiES+dniC5ESuS+jyZYEgvI+6NvKAm8zhJlShQNe6z+h9G8hcV LotfT35+1C7poCBMPADLY1iQaSG+AL5G8KzaVX5HUy+nwpBdspUYLuIDE9prmcbvKGM= X-Gm-Gg: ASbGncv+dNzYuYUITaxYkt7nUuSVvWWDAtzxJpKMVx5ci9I4rp4kBDRKUorwDLoc1iH M3E2TYSs3153hgS8rr1aBIKnTdtfvRLx9MV0lClHz3v67RGfPoKPL5aR1VV34KCmlCYFPELifY1 PI2WvpZo8NYNVB0vFDxhjjAAvXWMuY3AKmNkYAHm7JZd1FMMGJsqbhStaE2Rifsm36VSKquszpR 1mvWLQ4oPf2P3KYPASN3nhb7xkFIJT4nX1j/EFwcA9lLZOwRZnPFK7djvKuo5IW6enlVmosY5U7 xpaa77+pm8qbuDvwUmwUMD8JDmQ1esuD1KciyFQmt7w7B+sAZVBKYpCn7dYaeRPlMt8gH1UftHt GAA7UQuJ4S46jc4RFIUN87O1D0JxxClvaM09ly37KJjv1p8vDfw== X-Google-Smtp-Source: AGHT+IG+irLWOD78xwoAvbuOvZHdyLGDUiKL9Lg3uosSOKZjL28JHUt4/xMQ/877nSZppjATq3CYSA== X-Received: by 2002:a17:902:f78a:b0:234:c549:da13 with SMTP id d9443c01a7336-23e24edaf41mr361519995ad.17.1753149198840; Mon, 21 Jul 2025 18:53:18 -0700 (PDT) Received: from mystery-machine.tail542cf.ts.net ([64.71.154.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b3f2fe62d9fsm6017441a12.1.2025.07.21.18.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 18:53:18 -0700 (PDT) From: Brigham Campbell To: dianders@chromium.org, tejasvipin76@gmail.com, diogo.ivo@tecnico.ulisboa.pt, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Brigham Campbell Subject: [PATCH v6 0/4] drm: Fix bug in panel driver, update MIPI support macros Date: Mon, 21 Jul 2025 19:53:07 -0600 Message-ID: <20250722015313.561966-1-me@brighamcampbell.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series removes the unintuitive mipi_dsi_generic_write_seq() macro and related mipi_dsi_generic_write_chatty() method from the drm subsystem. This is in accordance with a TODO item from Douglas Anderson in the drm subsystem documentation. Tejas Vipin (among others) has largely spearheaded this effort up until now, converting MIPI panel drivers one at a time. The second patch of the series removes the last remaining references to mipi_dsi_generic_write_seq() in the jdi-lpm102a188a driver and updates the driver to use the undeprecated _multi variants of MIPI functions. It fixes a bug in the driver's unprepare function and cleans up duplicated code using the new mipi_dsi_dual* macros introduced in the first patch. changes to v6: - Fix various style and kerneldoc issues in patch 1/4 - Fix typo mpi_dsi_dual... -> mipi_dsi_dual... - Fix incorrectly named "data" and "len" variables - Make _seq argument of mipi_dsi_dual_dcs_write_seq_multi macro variadic - Remove duplicate definition of mipi_dsi_dual_dcs_write_seq_multi macro from novatek display driver changes to v5: - Rework mipi_dsi_dual to explicitly not support passing macros into _func and add "dual" variants of the generic and dcs write macros. - Make jdi-lpm102a188a use the new mipi_dsi_dual_generic_write_seq_multi macro. - Make local struct variable in jdi-lpm102a188a conform to reverse christmas tree order. changes to v4: - Fix whitespace (I forgot to run checkpatch. Thanks for your patience as I familiarize myself with the kernel development process) - Initialize mipi_dsi_multi_context struct changes to v3: - Define new mipi_dsi_dual macro in drm_mipi_dsi.h to reduce code duplication. - Fix bug in lpm102a188a panel driver's unprepare function which causes it to return a nonsensical value. - Make lpm102a188a panel driver's unprepare function send "display off" and "enter sleep mode" commands to both serial interfaces regardless of whether an error occurred when sending the last command. changes to v2: - Remove all usages of deprecated MIPI functions from jdi-lpm102a188a driver instead of just mipi_dsi_generic_write_seq(). - Update TODO item in drm documentation instead of removing it entirely. Brigham Campbell (4): drm: Create mipi_dsi_dual* macros drm/panel: jdi-lpm102a188a: Fix bug and clean up driver drm: Remove unused MIPI write seq and chatty functions drm: docs: Update task from drm TODO list Documentation/gpu/todo.rst | 22 +- drivers/gpu/drm/drm_mipi_dsi.c | 82 +- drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 196 ++--- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 804 +++++++++--------- include/drm/drm_mipi_dsi.h | 118 ++- 5 files changed, 614 insertions(+), 608 deletions(-) base-commit: ca2a6abdaee43808034cdb218428d2ed85fd3db8 -- 2.50.1