Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787D8E56A for ; Tue, 22 Jul 2025 07:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753168552; cv=none; b=kLk1yydQwCHe9KtoqY/4IfY0lKzCi5uEcpdvzBYop/MqK80EOA/SEJx5mAItFaogF/o8cWvki+O0BwcilByjOPt+Ob3B0afYsDRMKzcaKul9qi81T+eVnqk0JqquI+X7ScLhcTrFgVp+v0b4zcprAWbXm4M0KdUXAigQY8YF2f0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753168552; c=relaxed/simple; bh=j3SEh17yKJdtaTA6jlli22VQ1COpA7yRszYPMxwE5ZA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZQQ9oeqYu9Cv01Sc5qWgNL320uPt+ykeNCk8yNhrBxwzZJ83+dQAwrg2W04e0lj6pzrKe/cpnO8noq/HHL8KTTMxY40ZAJW187wFjk9TLcPT3+JwVynMz5KpIZ92tCeMzycnbOByXq6oacIFIJJJEF+RTxm6b+Yl4aHsTeTqIGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=GmLsYwfE; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="GmLsYwfE" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a6e8b1fa37so3584475f8f.2 for ; Tue, 22 Jul 2025 00:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1753168549; x=1753773349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yQ3vEmjwKiSfWo9bCKh2Tpilewzv/3IegJxtxqqielQ=; b=GmLsYwfEZt2DxPLbUbEpaM+uBrXlN3zh4WmYZS8AdHX/DOEAaZUTYpyXoawmqGjg9b UsOnA/k0djcWLvz/BibjV8yHSqlxv2xcPDz+MRWyyvb846obFzPMHXLhGqC30rpz1nMS kitUX3FhbD4Ec+FJ0NI98wlkAjr8HShYdsaZ4ueRmOolVE/IjPciwdiOpt0fy9xi8USu Bt2icd2yIj7gonF7Z93qNkdeeIJSFEmX6uE8Rjqwz950XMjNxR0h3BMAbDUa3y3NDzrg +MTStH7bfn1H1Y+/Ws7EsGm5C9l4fb77kH+B8nBBXtedKTvEkq6KL4ZI7smHpph4So4k F55w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753168549; x=1753773349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yQ3vEmjwKiSfWo9bCKh2Tpilewzv/3IegJxtxqqielQ=; b=JVMzSfDyTXA8mxeaDw6Izh722xRqxtbJMcKW9Ckz1F0KGVJWQ6Q8BWSQebr213uXtx HTsFsFGukSu+VNNvTqqqPML8ERDRp28d751Pku6L1ntsDpSlueA8nwk/cz55QlfGjr8O erMYgHUKJl7vPrVzSLevENjLjvOeZjTqJBxFsyquuEXJbdBdRy+ygScPe4YkpGD899hd OIwkQBbDzN3vFoG10I7AmZyK/RQiHcuJEs8ZxYn/N6SPyxnsxVgnBUcEoIYkCs71mmSq f4SkcxNziIaCmRLm9VTNRyM0uxwpjUJj6rVSKkHV3RpJCiizEP53Er+kRIv5suhIo3Hw Rc4Q== X-Forwarded-Encrypted: i=1; AJvYcCXRTkXNWDqeNYdOcUkNfOTwHAbk/99DJroLY2N6msUppXi/zIie26LtpE232w4QzZMgZhBG7NQ990s9@vger.kernel.org X-Gm-Message-State: AOJu0YwrleOWG3jJNYKnpDAM2NbUL4auIW+R9NoSNijMq5/OiExnC++f GYxmyB4PCvna3prYxwAjR2oBKEGZMcx7dQyWctPcr3rBw8G45EoHhXRyddbW8rbKadY= X-Gm-Gg: ASbGncskMKMkr53BJb41c4DbZ5wSJsOF5bhvJNMtjCC9xotQFNI6aHb7nCuzgmLQ3mV CGhyw4eQW5BGJGGn6z2B4zWocCrBx6invLx8xyt5sLLiPQ+f4Pn4kxjK+lggYLAX/PO+oSaHllA oq/jusXwu9t/euNTGOFJoh+FovYPW9ZR+w5TlQptDNEbT4XFohL0m6hNeWf9ioMfakkj5lL9RL9 BvVo0sVzYk7LSuxWwIqHkNhqopR9VqvvbaIaN4WcfmKcf82adbuzOm7860dUrOjYhYqhg14yKn0 JYXs3gsA/rqP9+SvFKOspPrKXn+T3P5VVe68h2TR9PVsgqfD6LtuGXN581yOy1mdBwgL9UrqWAq 1e2m5eakFyT7J6OPe/NqLsSVdRIzekYjk X-Google-Smtp-Source: AGHT+IHYIREMnXqJzvIrKSlpu72TKoCe2oI41qKi1zUISJbrlyCEP1q0OUDLmdmVYJabSs5VX3PelA== X-Received: by 2002:a5d:64c3:0:b0:3a3:71cb:f0bd with SMTP id ffacd0b85a97d-3b60e4d2b7amr16271092f8f.23.1753168548308; Tue, 22 Jul 2025 00:15:48 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:dc:7e00:2548:4ac:d051:6197]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca5c632sm12725706f8f.80.2025.07.22.00.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 00:15:47 -0700 (PDT) From: Bartosz Golaszewski To: Arnd Bergmann , Russell King , Linus Walleij , Thomas Gleixner , Jiri Slaby Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] ARM: sa110/gpio: convert set_multiple() to returning an integer Date: Tue, 22 Jul 2025 09:15:42 +0200 Message-ID: <20250722071542.19030-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bartosz Golaszewski The conversion to using the new GPIO line setter callbacks missed the set_multiple() in this file. Convert it to using the new callback. Fixes: 9c3782118a57 ("ARM: sa1100/gpio: use new line value setter callbacks") Signed-off-by: Bartosz Golaszewski --- arch/arm/common/sa1111.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 86b271cc29e1..d7e2ea27ce59 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -578,8 +578,8 @@ static int sa1111_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) return 0; } -static void sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, - unsigned long *bits) +static int sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, + unsigned long *bits) { struct sa1111 *sachip = gc_to_sa1111(gc); unsigned long flags; @@ -597,6 +597,8 @@ static void sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, sa1111_gpio_modify(reg + SA1111_GPIO_PCDWR, (msk >> 12) & 255, val >> 12); sa1111_gpio_modify(reg + SA1111_GPIO_PCSSR, (msk >> 12) & 255, val >> 12); spin_unlock_irqrestore(&sachip->lock, flags); + + return 0; } static int sa1111_gpio_to_irq(struct gpio_chip *gc, unsigned offset) @@ -616,7 +618,7 @@ static int sa1111_setup_gpios(struct sa1111 *sachip) sachip->gc.direction_output = sa1111_gpio_direction_output; sachip->gc.get = sa1111_gpio_get; sachip->gc.set_rv = sa1111_gpio_set; - sachip->gc.set_multiple = sa1111_gpio_set_multiple; + sachip->gc.set_multiple_rv = sa1111_gpio_set_multiple; sachip->gc.to_irq = sa1111_gpio_to_irq; sachip->gc.base = -1; sachip->gc.ngpio = 18; -- 2.48.1