Date: Wed, 23 Jul 2025 10:34:49 +0200 (CEST) Message-Id: <202507230834.56N8YnXp017769@...2054...> From: Gert Doering In-Reply-To: <20250723060747.19524-1-gert@...1296...> References: <20250723060747.19524-1-gert@...1296...> Subject: [Openvpn-devel] [PATCH applied] Re: dco_linux: rearrange functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Antonio Quartulli Cc: openvpn-devel@lists.sourceforge.net As mentioned every now and then, I'm not a big fan of patches that move code around - we frequently use "git blame" to figure out why certain code pieces came to be, and this gets more annoying if code gets moved. This said, *if* code needs to move, I do prefer a patch that has "no other changes" so "--color-moved=zebra" can visually prove that "nothing has changed". In this case, one "static" appeared, but nothing else :-) Test compiled, as usual. Your patch has been applied to the master branch. commit 7bcafb316ecea68b1acda9e137df9dce18afcc8c Author: Antonio Quartulli Date: Wed Jul 23 08:07:41 2025 +0200 dco_linux: rearrange functions Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20250723060747.19524-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32263.html Signed-off-by: Gert Doering -- kind regards, Gert Doering