Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC06418EB0 for ; Thu, 24 Jul 2025 02:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753324271; cv=none; b=kA1zF/ELy4EG+xqHv3Hymlf+Te1ANsma5nDRy6BGCGDdeTM4KZBDSylo9lH0/QqpuKJ4qftzlFh7Vb5lCYMapc02ububibLvV8smuwlzxVS/upPTYVfxFhpc7WTRy9F/HCOQZlPIOyF/YjbQeNLpj2a5zYfFbHUOYQLQfMX8/Gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753324271; c=relaxed/simple; bh=9FdP2FdmGwSu8KSQyWxCnN91gYqJ+8+kQiV+9HRZPr0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LWaVbEODbG667myUwtCdmG4NTOjlpZkDvCensVL1jmkmJy6QjW+idzJXjH9q16j6RdI2e3A0S6ttDx8uv0XPy+CQ4GkZQFDjcH4/NDKB3XBem6bfrJk76YQo2tJXZeO+yZ4xBmXV68JD1CK/tBzGZk6cQQQQg4k7cLlq+cZgnJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FW7nt43O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FW7nt43O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 345DEC4CEEF; Thu, 24 Jul 2025 02:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753324271; bh=9FdP2FdmGwSu8KSQyWxCnN91gYqJ+8+kQiV+9HRZPr0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FW7nt43OZmjpFQqkYz5zzvNQQ2VspWU2u5iLn1ylwo+jSdwBiSj2ULM80UsKmWD9q /9DEXj+2migYvU5dQU3Ql3v+HVeRvuOXqBXYiW3I3m++oWyKPjVybDxoWjfDZeZsD7 CZjP20THR602VYoka2yM/XKHKvuObal3OwdrVTtziblpY4drWxWb0OY2AY39yBRNfT 4s75X7QBuaQvf58yE+4u37w47iv+ATdujRA09AQYenG/8CEyr/byfeCsQ2f9bTm/s7 hKmTrhuoD9GtpW1nndKLAY1CHgrxleVk5Byz0tpRNNJyG0bS7RtbT52jGafTjBWL7U wdXH6B0fwqn6Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Md Sadre Alam , Manivannan Sadhasivam , Lakshmi Sowjanya D , Miquel Raynal , Sasha Levin Subject: [PATCH 6.6.y] mtd: rawnand: qcom: Fix last codeword read in qcom_param_page_type_exec() Date: Wed, 23 Jul 2025 22:31:05 -0400 Message-Id: <20250724023105.1267926-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <2025062000-manhunt-treachery-4c42@gregkh> References: <2025062000-manhunt-treachery-4c42@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Md Sadre Alam [ Upstream commit 47bddabbf69da50999ec68be92b58356c687e1d6 ] For QPIC V2 onwards there is a separate register to read last code word "QPIC_NAND_READ_LOCATION_LAST_CW_n". qcom_param_page_type_exec() is used to read only one code word If it configures the number of code words to 1 in QPIC_NAND_DEV0_CFG0 register then QPIC controller thinks its reading the last code word, since we are having separate register to read the last code word, we have to configure "QPIC_NAND_READ_LOCATION_LAST_CW_n" register to fetch data from QPIC buffer to system memory. Without this change page read was failing with timeout error / # hexdump -C /dev/mtd1 [ 129.206113] qcom-nandc 1cc8000.nand-controller: failure to read page/oob hexdump: /dev/mtd1: Connection timed out This issue only seen on SDX targets since SDX target used QPICv2. But same working on IPQ targets since IPQ used QPICv1. Cc: stable@vger.kernel.org Fixes: 89550beb098e ("mtd: rawnand: qcom: Implement exec_op()") Reviewed-by: Manivannan Sadhasivam Tested-by: Lakshmi Sowjanya D Signed-off-by: Md Sadre Alam Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/qcom_nandc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index beafca6ba0df4..275d34119acdc 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -2858,7 +2858,12 @@ static int qcom_param_page_type_exec(struct nand_chip *chip, const struct nand_ const struct nand_op_instr *instr = NULL; unsigned int op_id = 0; unsigned int len = 0; - int ret; + int ret, reg_base; + + reg_base = NAND_READ_LOCATION_0; + + if (nandc->props->qpic_v2) + reg_base = NAND_READ_LOCATION_LAST_CW_0; ret = qcom_parse_instructions(chip, subop, &q_op); if (ret) @@ -2910,7 +2915,10 @@ static int qcom_param_page_type_exec(struct nand_chip *chip, const struct nand_ op_id = q_op.data_instr_idx; len = nand_subop_get_data_len(subop, op_id); - nandc_set_read_loc(chip, 0, 0, 0, len, 1); + if (nandc->props->qpic_v2) + nandc_set_read_loc_last(chip, reg_base, 0, len, 1); + else + nandc_set_read_loc_first(chip, reg_base, 0, len, 1); if (!nandc->props->qpic_v2) { write_reg_dma(nandc, NAND_DEV_CMD_VLD, 1, 0); -- 2.39.5