Date: Wed, 30 Jul 2025 15:04:28 +0800
From: kernel test robot <lkp@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH] gpio: remove legacy GPIO line value setter callbacks
Message-ID: <202507301446.52ufgnWr-lkp@intel.com>
References: <20250725074651.14002-1-brgl@bgdev.pl>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250725074651.14002-1-brgl@bgdev.pl>

Hi Bartosz,

kernel test robot noticed the following build errors:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linus/master v6.16 next-20250729]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/gpio-remove-legacy-GPIO-line-value-setter-callbacks/20250725-154843
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20250725074651.14002-1-brgl%40bgdev.pl
patch subject: [PATCH] gpio: remove legacy GPIO line value setter callbacks
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20250730/202507301446.52ufgnWr-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250730/202507301446.52ufgnWr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507301446.52ufgnWr-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/arm/mach-s3c/gpio-samsung.c: In function 'samsung_gpiolib_add':
>> arch/arm/mach-s3c/gpio-samsung.c:519:18: error: 'struct gpio_chip' has no member named 'set'; did you mean 'get'?
     519 |         if (!gc->set)
         |                  ^~~
         |                  get


vim +519 arch/arm/mach-s3c/gpio-samsung.c

1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  493  
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  494  /*
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  495   * samsung_gpiolib_add() - add the Samsung gpio_chip.
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  496   * @chip: The chip to register
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  497   *
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  498   * This is a wrapper to gpiochip_add() that takes our specific gpio chip
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  499   * information and makes the necessary alterations for the platform and
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  500   * notes the information for use with the configuration systems and any
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  501   * other parts of the system.
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  502   */
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  503  
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  504  static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip)
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  505  {
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  506  	struct gpio_chip *gc = &chip->chip;
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  507  	int ret;
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  508  
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  509  	BUG_ON(!chip->base);
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  510  	BUG_ON(!gc->label);
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  511  	BUG_ON(!gc->ngpio);
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  512  
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  513  	spin_lock_init(&chip->lock);
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  514  
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  515  	if (!gc->direction_input)
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  516  		gc->direction_input = samsung_gpiolib_2bit_input;
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  517  	if (!gc->direction_output)
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  518  		gc->direction_output = samsung_gpiolib_2bit_output;
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30 @519  	if (!gc->set)
fb52f3226cab41 arch/arm/mach-s3c/gpio-samsung.c Bartosz Golaszewski 2025-04-07  520  		gc->set_rv = samsung_gpiolib_set;
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  521  	if (!gc->get)
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  522  		gc->get = samsung_gpiolib_get;
1b39d5f2cc5c28 drivers/gpio/gpio-samsung.c      Kukjin Kim          2011-08-30  523  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki