Date: Wed, 30 Jul 2025 20:15:13 +0200 (CEST) Message-Id: <202507301815.56UIFDWV057507@...2054...> From: Gert Doering In-Reply-To: <20250730180527.25339-1-gert@...1296...> References: <20250730180527.25339-1-gert@...1296...> Subject: [Openvpn-devel] [PATCH applied] Re: Fix broken DHCP options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lev Stipakov Cc: openvpn-devel@lists.sourceforge.net Thanks. I've ran into this myself with 2.7_alpha2 and a setup that ended up doing DHCP on TAP, so thanks for the fix :-) I have not tested it beyond "does it compile", but looking at the code flow and finding tt->options.dhcp_options in tun.c, this is "obviously correct". The dance with the helper variable is unavoidable due to the platform-dependent nature of the options.c code here... ("or you get 3 extra #ifdefs"). Your patch has been applied to the master branch. commit 040e0d1c308a587ae9a26295eeaa070561befa0d Author: Lev Stipakov Date: Wed Jul 30 20:04:26 2025 +0200 Fix broken DHCP options Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250730180527.25339-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32427.html Signed-off-by: Gert Doering -- kind regards, Gert Doering