Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10C7279915; Tue, 12 Aug 2025 17:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020925; cv=none; b=pIUcecq6c/eHx1YPyMdHM6eNiC4KxzxIYXYS0jZXz1zK7PSzeNVcnB6HHmRX1aBX0DwUV+ls6LoAUhqvpVYIzfYHVD2iknAPtQ9nqXbTWLGGUh7CAxwzRTkN2rGVcgbLu6IIcgb0M6itTp0FBLBlAq9jl6O/4qPevxH+1vSsKIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020925; c=relaxed/simple; bh=kObonQ8jr/vVVHLx7qvHCVxOsKzafBfbvVK9QrPnUdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dErOzqjaiJbVYbtoiWeyQb0uK2P/DwzfeOZ7Sk6tG7NiYGnHqDhv1/e44yzqIwcLxoNrYfKCmYJsUCvZ470O/UoTChiWn9hW4iRRDjjblrNgHkgSXV73uvwHUOIwps4Pcl8F5wKs0M+UX5fTgjfVb0a+lvMBQu54k+PEoRPzPnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mWcJ8ajS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mWcJ8ajS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 550E0C4CEF0; Tue, 12 Aug 2025 17:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755020924; bh=kObonQ8jr/vVVHLx7qvHCVxOsKzafBfbvVK9QrPnUdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mWcJ8ajSuz5jKfKhPMHQi1vDUcJL+F+JlQZpGzDEHWP/H8ZTdI+kgmxDEw0+llNxc HrvxtYt7wVMz0N/325mQBubkRiWX0zurxhSyCGsbsenMfajL7G0hYx4gif6TSx+vZ3 AMKc2C+E+SvpiI0kYOsC0eFUj9Y6E0qgxMLrWxJs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brian Masney , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.1 187/253] rtc: hym8563: fix incorrect maximum clock rate handling Date: Tue, 12 Aug 2025 19:29:35 +0200 Message-ID: <20250812172956.745610667@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812172948.675299901@linuxfoundation.org> References: <20250812172948.675299901@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brian Masney [ Upstream commit d0a518eb0a692a2ab8357e844970660c5ea37720 ] When hym8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: dcaf038493525 ("rtc: add hym8563 rtc-driver") Signed-off-by: Brian Masney Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-2-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index cc710d682121..2f52aabd129a 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -294,7 +294,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate, if (clkout_rates[i] <= rate) return clkout_rates[i]; - return 0; + return clkout_rates[0]; } static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.39.5