Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1477332778D for ; Wed, 20 Aug 2025 13:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755696831; cv=none; b=eenxerb3VGbGDg5ilXrq8LTdHQXgOPxEqIJeNSgNNcy74YpwV3YxjM96F3pzRIdz7ZTLgaeWZgOviRYgfVZs2v+mnV2Rtb48bI8UJATnSkRJ87KknmTEeWe/3o0kv5NYEjOO2Vl/tKdvhcbTh1nU7e7S5nz8v/StjnPzQwQQyAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755696831; c=relaxed/simple; bh=RGMChPLRzycxntLqPnVxxFNL6eGesI8TLoJEyr4B7os=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=anf1AbalWQGRPmp5OKVx0e4QC67GKvaNXR1kAlVvH7JtHt5bpX02W3fwO6n9RamjqQGY59uJrcwKvhrdxvlLXApBNZBXuEjEaZg9zk61mQ48eO8MCnbQb8Ddn8Y5NtuSvVyqpBl/Phplf1q/gfLo/el5B6elRjT4ejVVLWxUxUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=k4vczdnx; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="k4vczdnx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1755696828; bh=RGMChPLRzycxntLqPnVxxFNL6eGesI8TLoJEyr4B7os=; h=From:To:Subject:Date:In-Reply-To:References:From; b=k4vczdnxQCHGuaPqSoTQ78AF3MdAymfyzvyihudkw8+g5kw6Luc5edaKqWZbAhhIU CXj0LrKpTUHrl167/6pV32yzM3Qlf56TU6hmhAaQs+g2lWkWsuLe7QWnjC0Z7k2GLx 55wABYWzYlpTkQRh8zZdz9lOvJ2pECBdTtC93JZK0tXexRFjjlxqbrRGd6/TcTla80 qVg1pVwss18ARsC1KNiqN9YUe+83+Lus0P0Xv9j0tN03g5DhX8HGdj5VMkGbHYj9QT +ClV3vbbfnqMJjONJE/0KkSS2IUoMEn2n1mEJJpgA/MvtTUzHmgeOQFkBhIU6pfAVT WdGfFqHEbL/xg== Received: from fdanis-ThinkPad-X1.. (2A02-8428-af44-1001-e86C-1c83-BFB8-e1aE.rev.sfr.net [IPv6:2a02:8428:af44:1001:e86c:1c83:bfb8:e1ae]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: fdanis) by bali.collaboradmins.com (Postfix) with ESMTPSA id 38ED017E02B0 for ; Wed, 20 Aug 2025 15:33:48 +0200 (CEST) From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ v2 2/4] unit/test-hfp: Add SLC connection test Date: Wed, 20 Aug 2025 15:33:36 +0200 Message-ID: <20250820133338.1158203-2-frederic.danis@collabora.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820133338.1158203-1-frederic.danis@collabora.com> References: <20250820133338.1158203-1-frederic.danis@collabora.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit This adds minimal packet exchange to test the SLC establishment. --- v1->v2: Fix ERROR:unit/test-hfp.c:734:hf_update_indicator: assertion failed (val == 1): (0 == 1) unit/test-hfp.c | 117 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 117 insertions(+) diff --git a/unit/test-hfp.c b/unit/test-hfp.c index b4af99d53..b79034642 100644 --- a/unit/test-hfp.c +++ b/unit/test-hfp.c @@ -104,6 +104,14 @@ struct test_data { data.test_handler = test_hf_handler; \ } while (0) +static void print_debug(const char *str, void *user_data) +{ + const char *prefix = user_data; + + if (tester_use_debug()) + tester_debug("%s%s", prefix, str); +} + static void test_free(gconstpointer user_data) { const struct test_data *data = user_data; @@ -680,6 +688,110 @@ static void test_hf_robustness(gconstpointer data) context_quit(context); } +#define MINIMAL_SLC_SESSION \ + raw_pdu('\r', '\n', '+', 'B', 'R', 'S', 'F', ':', \ + ' ', '0', '\r', '\n'), \ + frg_pdu('\r', '\n', 'O', 'K', '\r', '\n'), \ + raw_pdu('\r', '\n', '+', 'C', 'I', 'N', 'D', ':', ' '), \ + frg_pdu('(', '\"', 's', 'e', 'r', 'v', 'i', 'c', 'e'), \ + frg_pdu('\"', '(', '0', ',', '1', ')', ')', ','), \ + frg_pdu('(', '\"', 'c', 'a', 'l', 'l', '\"'), \ + frg_pdu('(', '0', ',', '1', ')', ')', ','), \ + frg_pdu('(', '\"', 'c', 'a', 'l', 'l', 's', 'e', 't'), \ + frg_pdu('u', 'p', '\"', ',', '(', '0', '-', '3', ')'), \ + frg_pdu(')', ','), \ + frg_pdu('(', '\"', 'c', 'a', 'l', 'l', 'h', 'e', 'l'), \ + frg_pdu('d', '\"', ',', '(', '0', '-', '2', ')', ')'), \ + frg_pdu(',', '(', '\"', 's', 'i', 'g', 'n', 'a', 'l'), \ + frg_pdu('\"', '(', '0', '-', '5', ')', ')', ','), \ + frg_pdu('(', '\"', 'r', 'o', 'a', 'm', '\"', ',', '('), \ + frg_pdu('0', ',', '1', ')', ')', ','), \ + frg_pdu('(', '\"', 'b', 'a', 't', 't', 'c', 'h', 'g'), \ + frg_pdu('\"', '(', '0', '-', '5', ')', ')', ','), \ + frg_pdu('\r', '\n'), \ + frg_pdu('\r', '\n', 'O', 'K', '\r', '\n'), \ + raw_pdu('\r', '\n', '+', 'C', 'I', 'N', 'D', ':', ' '), \ + frg_pdu('0', ',', '0', ',', '0', ',', '0', ',', '5'), \ + frg_pdu(',', '0', ',', '5', '\r', '\n'), \ + frg_pdu('\r', '\n', 'O', 'K', '\r', '\n'), \ + raw_pdu('\r', '\n', 'O', 'K', '\r', '\n') + +static void hf_session_ready_cb(enum hfp_result res, enum hfp_error cme_err, + void *user_data) +{ + struct context *context = user_data; + + g_assert_cmpint(res, ==, HFP_RESULT_OK); + + context->data->response_func(res, cme_err, context); +} + +static void hf_update_indicator(enum hfp_indicator indicator, uint32_t val, + void *user_data) +{ + switch (indicator) { + case HFP_INDICATOR_SERVICE: + g_assert_cmpint(val, ==, 0); + break; + case HFP_INDICATOR_CALL: + g_assert_cmpint(val, ==, 0); + break; + case HFP_INDICATOR_CALLSETUP: + g_assert_cmpint(val, ==, 0); + break; + case HFP_INDICATOR_CALLHELD: + g_assert_cmpint(val, ==, 0); + break; + case HFP_INDICATOR_SIGNAL: + g_assert_cmpint(val, ==, 5); + break; + case HFP_INDICATOR_ROAM: + g_assert_cmpint(val, ==, 0); + break; + case HFP_INDICATOR_BATTCHG: + g_assert_cmpint(val, ==, 5); + break; + case HFP_INDICATOR_LAST: + default: + tester_test_failed(); + } +} + +static struct hfp_hf_callbacks hf_session_callbacks = { + .session_ready = hf_session_ready_cb, + .update_indicator = hf_update_indicator, +}; + +static void test_hf_session_done(enum hfp_result res, enum hfp_error cme_err, + void *user_data) +{ + struct context *context = user_data; + + hfp_hf_disconnect(context->hfp_hf); +} + +static void test_hf_session(gconstpointer data) +{ + struct context *context = create_context(data); + bool ret; + + context->hfp_hf = hfp_hf_new(context->fd_client); + g_assert(context->hfp_hf); + + ret = hfp_hf_set_debug(context->hfp_hf, print_debug, "hfp-hf:", NULL); + g_assert(ret); + + ret = hfp_hf_set_close_on_unref(context->hfp_hf, true); + g_assert(ret); + + ret = hfp_hf_session_register(context->hfp_hf, &hf_session_callbacks, + context); + g_assert(ret); + + ret = hfp_hf_session(context->hfp_hf); + g_assert(ret); +} + int main(int argc, char *argv[]) { tester_init(&argc, &argv); @@ -850,5 +962,10 @@ int main(int argc, char *argv[]) frg_pdu('1', ',', '2', 'x', '\r', '\n'), data_end()); + define_hf_test("/hfp_hf/test_session_minimal", test_hf_session, + NULL, test_hf_session_done, + MINIMAL_SLC_SESSION, + data_end()); + return tester_run(); } -- 2.43.0