Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11848311591 for ; Thu, 21 Aug 2025 11:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755774944; cv=none; b=Ay/2ulnJ3icFqrOR2mEh/G0ot0lcpTDA4GmUlXbnPGeupjEoOyT+HJmYi1Ywny4fdoaz0qoKsrkI3sRQMmkzhqbpxGHtjsuK4gXBZynAZoUhXGS0pgMVJyGP2apq7kFcCssj5r6RQKsKKj6V4uwL9ZTm2RqSaTMLuUvmtH8p4cA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755774944; c=relaxed/simple; bh=VsXOc1S4ap0B42nAyjWEeWqOQ+Gec9oY/uBK21jhEz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HGsKPfR3jv/Wd4T1a+ZB0tDC2LujRqYOerUjoC+sWVu+NwaSVI9UQAwildpr5SW/x6igidfDfQf5/Aw1eXnuHSSO/hTYq4TIgZB9Zo7xmmy+igw7c89XVR80sFCRUyke3ZHLOOAjY7HA8rqS8tAgub9d1b5V+Z05WHYNOH8ZJYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MQtsGxe+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MQtsGxe+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755774942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6jKrMmmjaF5f4Ut7LCPyvP+C7XbkD8LpIfSPKWAXHuY=; b=MQtsGxe+VOdcXwsJl6Y7LnW1XSPrTli7tkwkRNYBTkU0HmYZtqNapKBrO47ut2Ug9JO+vN RqlLKgBhIiMryUBrRcxXOXowz7u/ms4yRYxcTVVTBMLC8WXVca3+EDfBIDosEhmD7y+VYN i76kYCc5jDgVqBAhTbLUjWLlk3uAjSo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-cV2KJnnUPHmApk1gQlZsmA-1; Thu, 21 Aug 2025 07:15:40 -0400 X-MC-Unique: cV2KJnnUPHmApk1gQlZsmA-1 X-Mimecast-MFC-AGG-ID: cV2KJnnUPHmApk1gQlZsmA_1755774939 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 345B8180888A; Thu, 21 Aug 2025 11:15:36 +0000 (UTC) Received: from dobby.home.dicksonnet.net (unknown [10.22.80.72]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 574B01977689; Thu, 21 Aug 2025 11:15:35 +0000 (UTC) From: Steve Dickson To: Libtirpc-devel Mailing List Cc: Linux NFS Mailing list Subject: [PATCH 08/12] Convert old-style function definitions into modern-style definitions Date: Thu, 21 Aug 2025 07:15:19 -0400 Message-ID: <20250821111524.1379577-9-steved@redhat.com> In-Reply-To: <20250821111524.1379577-1-steved@redhat.com> References: <20250821111524.1379577-1-steved@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 With newer compilers (gcc 15.1.1) -Wold-style-definition flag is set by default which causes warnings for most of the functions in these files. warning: old-style function definition [-Wold-style-definition] The warnings are remove by converting the old-style function definitions into modern-style definitions Signed-off-by: Steve Dickson --- src/key_call.c | 58 +++++++++++++++++++++++--------------------------- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/src/key_call.c b/src/key_call.c index 43f990e..e33e444 100644 --- a/src/key_call.c +++ b/src/key_call.c @@ -79,8 +79,7 @@ des_block *(*__key_gendes_LOCAL)(uid_t, char *) = 0; static int key_call( u_long, xdrproc_t, void *, xdrproc_t, void *); int -key_setsecret(secretkey) - const char *secretkey; +key_setsecret(const char *secretkey) { keystatus status; @@ -122,10 +121,10 @@ key_secretkey_is_set(void) } int -key_encryptsession_pk(remotename, remotekey, deskey) - char *remotename; - netobj *remotekey; - des_block *deskey; +key_encryptsession_pk( + char *remotename, + netobj *remotekey, + des_block *deskey) { cryptkeyarg2 arg; cryptkeyres res; @@ -146,10 +145,10 @@ key_encryptsession_pk(remotename, remotekey, deskey) } int -key_decryptsession_pk(remotename, remotekey, deskey) - char *remotename; - netobj *remotekey; - des_block *deskey; +key_decryptsession_pk( + char *remotename, + netobj *remotekey, + des_block *deskey) { cryptkeyarg2 arg; cryptkeyres res; @@ -170,9 +169,9 @@ key_decryptsession_pk(remotename, remotekey, deskey) } int -key_encryptsession(remotename, deskey) - const char *remotename; - des_block *deskey; +key_encryptsession( + const char *remotename, + des_block *deskey) { cryptkeyarg arg; cryptkeyres res; @@ -192,9 +191,9 @@ key_encryptsession(remotename, deskey) } int -key_decryptsession(remotename, deskey) - const char *remotename; - des_block *deskey; +key_decryptsession( + const char *remotename, + des_block *deskey) { cryptkeyarg arg; cryptkeyres res; @@ -214,8 +213,7 @@ key_decryptsession(remotename, deskey) } int -key_gendes(key) - des_block *key; +key_gendes(des_block *key) { if (!key_call((u_long)KEY_GEN, (xdrproc_t)xdr_void, NULL, (xdrproc_t)xdr_des_block, key)) { @@ -225,8 +223,7 @@ key_gendes(key) } int -key_setnet(arg) -struct key_netstarg *arg; +key_setnet(struct key_netstarg *arg) { keystatus status; @@ -245,9 +242,9 @@ struct key_netstarg *arg; int -key_get_conv(pkey, deskey) - char *pkey; - des_block *deskey; +key_get_conv( + char *pkey, + des_block *deskey) { cryptkeyres res; @@ -286,8 +283,7 @@ key_call_destroy(void *vp) * Keep the handle cached. This call may be made quite often. */ static CLIENT * -getkeyserv_handle(vers) -int vers; +getkeyserv_handle(int vers) { void *localhandle; struct netconfig *nconf; @@ -396,12 +392,12 @@ int vers; /* returns 0 on failure, 1 on success */ static int -key_call(proc, xdr_arg, arg, xdr_rslt, rslt) - u_long proc; - xdrproc_t xdr_arg; - void *arg; - xdrproc_t xdr_rslt; - void *rslt; +key_call( + u_long proc, + xdrproc_t xdr_arg, + void *arg, + xdrproc_t xdr_rslt, + void *rslt) { CLIENT *clnt; struct timeval wait_time; -- 2.50.1