Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 439B4CA0EEB for ; Fri, 22 Aug 2025 13:55:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upSD6-0005iV-6z; Fri, 22 Aug 2025 09:53:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upO1o-0005wd-43 for qemu-arm@nongnu.org; Fri, 22 Aug 2025 05:25:44 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1upO1l-0007F0-Qq for qemu-arm@nongnu.org; Fri, 22 Aug 2025 05:25:43 -0400 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2445806d44fso15713595ad.1 for ; Fri, 22 Aug 2025 02:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20230601.gappssmtp.com; s=20230601; t=1755854740; x=1756459540; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zXgebig47wIeXfp8dqO8PzqCbna3KM2O0dfho6ysf2U=; b=s/Cgb1xvvuIYGLC7pCYhMY1IUYSqPoaLPxBvg4u4rNHfKsRQKbiANocmZSTH9+78Xe b6GkLk6qgRgPSRstzJstnsCaniqmPZuu8C7uyh6Cbick9HorvmEu5H0GqvsxWx71BVVf R6/Nu94ZLOmcaptn1S3+pRScE+FGCjLiAl638PKqe5KS1ZCkjWSImLNnQeP4luk/hvXb ESo0JPJ2HtDkmwBMkjXPCfZ4bVbRKYEzQuNbHsZfbSlnnXBYmKmjmEVCKFuoXOH0E3/+ n9FdAPAFsqVDJ4/x+LWLfT+ENb0458VJ76PqAwFXa+iO+dvwMDeeYI2cb6jR3CX2fM1O /JLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755854740; x=1756459540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zXgebig47wIeXfp8dqO8PzqCbna3KM2O0dfho6ysf2U=; b=W9GMb7o6az1KJXrF4WzzxC1jOTd09cQUOL01p/SDXFL3zGf1TqgYx4LeGuU6BmU9rC h8zUlISfbZSyFkhsWchwJhcV9F/uELjYkoX8/UMzZjYduchH8VBvieM7uN+Bh1B8TCmJ BOFlc8uUMfDhTBYwXWF3i/+6GzSbPMrX/udwLjPV+4hRB7yhsFS/IGWyeiE6K2IZfyMC uhkjGZuY2VnVUUjC3roLBjQ7B9kTfs+ogkEW8jXUsErs4U234ZQNw2e7BCbcvkj1n/j8 t2n95iLpgfncGPf9MDyEXOs0znyEkIpahLm4Wk3ToVG5sC3LZn9EvPa65qHZ1Zt6Fso1 08Ow== X-Forwarded-Encrypted: i=1; AJvYcCVeDMXRiS8mst8mTeGH3XvTVKsAoPM0OrddFpuzi+axrZ9Zb3290+GkPc0ej2ffyFj/tOyYWdDI9A==@nongnu.org X-Gm-Message-State: AOJu0Yz08AYNj1twBGl7KL+77hl9I2t+PC8C2dExp2rTGzBOm/BMXgGV tmqFw9WHWA4Y8fODMay5S9f6oolAQAvQuyZT2pZ2Oh94gMC7KHs3gog2YoJRCBA7gTo= X-Gm-Gg: ASbGncuydRewjoNG4J4iAFC9F12PNg6tMtU1m1EBdtNgTNKUsou5Z8jU1lJjOP+ORBE DMc2QSVG3RWQK61aeL6L3HVd5DsKMaPABQp4g/dTG2ZkpffaRLV2S6FFuUuP88oKVoly4BOzlwb bqKJEx9mPQmaH5SblCfkY2PjInPw2ScVmAOTIh7kw3k8CG2cIxGmsq1oG8JJedu6E4u4790fATq aMyxlrZu6r7j1U1Svo+KJEQzxN7yvuLmWmh8yXPsP7KJeI87C+S+pfFKNfPOpBW2THdGrP6Lwzg wkFNa2/ufMoElPd8wrAywxhIUg9uQokxTFELDUmHqgVFAuMSlp/LyFaE0xL7M8rrWZNY296+Z8y mG6GvfxViJj5s19sJalBRaWpgSJyL5l+ASWL3ngzejA== X-Google-Smtp-Source: AGHT+IH8pYTJbnXf7rKnNIsoHQG2QKG2X9mf+U2mWDZhwdN/zTCzSXTLAS1lHezYzzhePUW/JC2CJA== X-Received: by 2002:a17:902:f70c:b0:246:1c53:6739 with SMTP id d9443c01a7336-2462edfad58mr35900195ad.21.1755854740220; Fri, 22 Aug 2025 02:25:40 -0700 (PDT) Received: from warg.hq.igel.co.jp (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4c6fb7sm78560215ad.89.2025.08.22.02.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 02:25:39 -0700 (PDT) From: CJ Chen To: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org Cc: Paolo Bonzini , Keith Busch , Klaus Jensen , Jesper Devantier , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Tyrone Ting , Hao Wu , Max Filippov , Peter Xu , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Tomoyuki Hirose , Peter Maydell , CJ Chen Subject: [RFC PATCH v2 6/9] hw/usb/hcd-xhci: allow unaligned access to Capability Registers Date: Fri, 22 Aug 2025 18:24:07 +0900 Message-Id: <20250822092410.25833-7-cjchen@igel.co.jp> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250822092410.25833-1-cjchen@igel.co.jp> References: <20250822092410.25833-1-cjchen@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=cjchen@igel.co.jp; helo=mail-pl1-x62b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 22 Aug 2025 09:53:38 -0400 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Tomoyuki Hirose According to xHCI spec rev 1.2, unaligned access to xHCI Host Controller Capability Registers is not prohibited. In addition, the limit of access size is also unspecified. Actually, some real devices allow unaligned access and 8-byte access to these registers. This commit makes it possible to unaligned access and 8-byte access to Host Controller Capability Registers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/143 Based-on-a-patch-by: Tomoyuki Hirose Signed-off-by: CJ Chen Tested-by: CJ Chen Reported-by: Tomoyuki Hirose --- hw/usb/hcd-xhci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 292c378bfc..81e91e6ffb 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3190,9 +3190,11 @@ static const MemoryRegionOps xhci_cap_ops = { .read = xhci_cap_read, .write = xhci_cap_write, .valid.min_access_size = 1, - .valid.max_access_size = 4, + .valid.max_access_size = 8, + .valid.unaligned = true, .impl.min_access_size = 4, .impl.max_access_size = 4, + .impl.unaligned = false, .endianness = DEVICE_LITTLE_ENDIAN, }; -- 2.25.1