Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678F62D7382 for ; Sun, 24 Aug 2025 13:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756042747; cv=none; b=TNLxqZ3EHv0+6fnKpjZknsJk91ZfnqAChI+OcFgunh6bZLWK1LeIbSf3rBOY7h9YyM496C+NpY4/obRZyPc4rD9AjkpFehGXHUHgsDtSGy5MlUJL6EodvmAuiH7+gy12pQCCfkWQvUbHFX85g1+luraRslQw17VHHYEyw3Kl3PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756042747; c=relaxed/simple; bh=mv40MkudRH2UNRvQVcX+jQelIn4Xx94li68dq9HVrfY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CikG7B7MAj/O+nFt+SED9Jne8dU+1rdkIMH45JEyZKMyQcY6FM/J4BBygECr/EF0nxq+f06HuK2zegqaYiSUXEcvA0NNlKJOf/WDkt1jCXkwnPnRD/WPr+O4BhKi6x4AByROD426cJdCq6C/WBvwz19bplw9D5VMrCF7EkEM0R0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JXJaOnRP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JXJaOnRP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55DF3C116B1; Sun, 24 Aug 2025 13:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756042747; bh=mv40MkudRH2UNRvQVcX+jQelIn4Xx94li68dq9HVrfY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JXJaOnRPSJyf//8cx3WWjuoCmXCILeXDc6//FC1kmpxNqdP6gB+0gi80v2f/TUt8k U5Lkf6JhPHbKVZZm3ASXvQ29qd5ThtcZNIsfoOPPaLyiInoiWqN/BEqV7nfYPVOSl5 OEl3M4wgz3HOC8i20kaaZmoLug/fty5/wRndP0IA2WVTa5y8NGHAdP0tm4Efd3lUPz T60ac1sSBHjk0CcAr+us1FFWRMWve/AHpq9aUBIfckJNleIPtag4LyN4uvWWFhUYTJ TJKP7s8jECnVakL/C8Ko4gbyqQ8CO40pWCRxglogE+LZP90PO4HQ9n9Y5KBLjyKkmq nmaDhPd3+UhSg== From: Sasha Levin To: stable@vger.kernel.org Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Jonathan Cameron , Sasha Levin Subject: [PATCH 6.12.y 2/4] iio: imu: inv_icm42600: use = { } instead of memset() Date: Sun, 24 Aug 2025 09:39:01 -0400 Message-ID: <20250824133904.2896884-2-sashal@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250824133904.2896884-1-sashal@kernel.org> References: <2025082313-lubricant-traction-2a78@gregkh> <20250824133904.2896884-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: David Lechner [ Upstream commit 352112e2d9aab6a156c2803ae14eb89a9fd93b7d ] Use { } instead of memset() to zero-initialize stack memory to simplify the code. Signed-off-by: David Lechner Reviewed-by: Nuno Sá Reviewed-by: Andy Shevchenko Link: https://patch.msgid.link/20250611-iio-zero-init-stack-with-instead-of-memset-v1-16-ebb2d0a24302@baylibre.com Signed-off-by: Jonathan Cameron Stable-dep-of: dfdc31e7ccf3 ("iio: imu: inv_icm42600: change invalid data error to -EBUSY") Signed-off-by: Sasha Levin --- drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 5 ++--- drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c index 388520ec60b5..a803c806d6b9 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c @@ -905,7 +905,8 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev) const int8_t *temp; unsigned int odr; int64_t ts_val; - struct inv_icm42600_accel_buffer buffer; + /* buffer is copied to userspace, zeroing it to avoid any data leak */ + struct inv_icm42600_accel_buffer buffer = { }; /* parse all fifo packets */ for (i = 0, no = 0; i < st->fifo.count; i += size, ++no) { @@ -924,8 +925,6 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev) inv_sensors_timestamp_apply_odr(ts, st->fifo.period, st->fifo.nb.total, no); - /* buffer is copied to userspace, zeroing it to avoid any data leak */ - memset(&buffer, 0, sizeof(buffer)); memcpy(&buffer.accel, accel, sizeof(buffer.accel)); /* convert 8 bits FIFO temperature in high resolution format */ buffer.temp = temp ? (*temp * 64) : 0; diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c index 591ed78a55bb..34bb201613d9 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c @@ -809,7 +809,8 @@ int inv_icm42600_gyro_parse_fifo(struct iio_dev *indio_dev) const int8_t *temp; unsigned int odr; int64_t ts_val; - struct inv_icm42600_gyro_buffer buffer; + /* buffer is copied to userspace, zeroing it to avoid any data leak */ + struct inv_icm42600_gyro_buffer buffer = { }; /* parse all fifo packets */ for (i = 0, no = 0; i < st->fifo.count; i += size, ++no) { @@ -828,8 +829,6 @@ int inv_icm42600_gyro_parse_fifo(struct iio_dev *indio_dev) inv_sensors_timestamp_apply_odr(ts, st->fifo.period, st->fifo.nb.total, no); - /* buffer is copied to userspace, zeroing it to avoid any data leak */ - memset(&buffer, 0, sizeof(buffer)); memcpy(&buffer.gyro, gyro, sizeof(buffer.gyro)); /* convert 8 bits FIFO temperature in high resolution format */ buffer.temp = temp ? (*temp * 64) : 0; -- 2.50.1