Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3B42D12E4 for ; Tue, 26 Aug 2025 16:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226624; cv=none; b=YBSyR/TZ4r5afFy8csE7+JBN5iLgDRpgJildfbBjR9WvRuVjKsVsmrgQJVswZ2T8IzZd/rgUtzk92nzKf/m2uIPYMFexqiJU4hFIp1S6y2ccnCTxyatKzWdF6vBUrVP10oinyQjLOdAyY7FiLqKTZK1wlELaNJyvxF/1NIHJHKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226624; c=relaxed/simple; bh=MCOer+ksuLi7clca5Mdv+wXA/Dxgt7rsLw5MwHnahTY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SQrY3yVjD9lsmor/BD70xCtExFFqaSFgMumxQbpMCR8PdD+SOxR1YYIioGrbB67C/z49CCuhsbHeDme1fTooYCP3LkYWnlycJ0WDa8XXeZJFyxPfKsNcF0R3Zn7SV2LhxYBuAPU97Gv5koGd2kbX22uxLTQ5f0eo0aDgpoT2jMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QtMaNgAw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QtMaNgAw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756226622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z5jJAQ4bl/C1tP3vIQgdQ7NeY1XQOoOjZ8flFIdluW4=; b=QtMaNgAwoqgEU3YxjrdvBPBTpmsIPdaIzZORjlZGA/HGbZ0iDMuhFuXhAyf3u6/0YvXBk0 /qhQU6oQG8+JPFyAhPhplBvBn8oUzKazlstKHA2GZJNaZ7+HtOhn5FcTRRvwPovJco6dSR L8hnKsEbwqP+II+yUCs3e9tZzzC2jn8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-b_VB8Hc8Mwyp-OFH4XP3mw-1; Tue, 26 Aug 2025 12:43:40 -0400 X-MC-Unique: b_VB8Hc8Mwyp-OFH4XP3mw-1 X-Mimecast-MFC-AGG-ID: b_VB8Hc8Mwyp-OFH4XP3mw_1756226619 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9C92019560AE; Tue, 26 Aug 2025 16:43:38 +0000 (UTC) Received: from dba-icx.bos.redhat.com (prarit2023-dbaguest.khw.eng.bos2.dc.redhat.com [10.26.1.94]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 048C519560AB; Tue, 26 Aug 2025 16:43:35 +0000 (UTC) From: David Arcari To: platform-driver-x86@vger.kernel.org Cc: David Arcari , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Srinivas Pandruvada , Peter Zijlstra , Ingo Molnar , Dan Carpenter , Andy Shevchenko , Tero Kristo , linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86/intel: power-domains validate domain in tpmi_cpu_online() Date: Tue, 26 Aug 2025 12:43:28 -0400 Message-ID: <20250826164331.1372856-1-darcari@redhat.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Although tpmi_get_power_domain_mask() calls tpmi_domain_is_valid() prior to indexing tpmi_power_domain_mask[], tpmi_cpu_online() does not. In the case where a VM creates non-contiguous package ids the result can be memory corruption. This can be prevented by adding the same validation in tpmi_cpu_online(). Fixes: 17ca2780458c ("platform/x86/intel: TPMI domain id and CPU mapping") Cc: Hans de Goede Cc: "Ilpo Järvinen" Cc: Srinivas Pandruvada Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Dan Carpenter Cc: David Arcari Cc: Andy Shevchenko Cc: Tero Kristo Cc: linux-kernel@vger.kernel.org Signed-off-by: David Arcari --- drivers/platform/x86/intel/tpmi_power_domains.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c b/drivers/platform/x86/intel/tpmi_power_domains.c index 9d8247bb9cfa..ae5b58679e29 100644 --- a/drivers/platform/x86/intel/tpmi_power_domains.c +++ b/drivers/platform/x86/intel/tpmi_power_domains.c @@ -194,6 +194,9 @@ static int tpmi_cpu_online(unsigned int cpu) if (ret) return 0; + if (!tpmi_domain_is_valid(info)) + return 0; + index = info->pkg_id * MAX_POWER_DOMAINS + info->punit_domain_id; guard(mutex)(&tpmi_lock); -- 2.50.0