Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E37ECA0FED for ; Wed, 10 Sep 2025 10:25:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwHzd-0006bQ-VZ; Wed, 10 Sep 2025 06:24:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwHzc-0006bH-S7 for qemu-devel@nongnu.org; Wed, 10 Sep 2025 06:24:00 -0400 Received: from lichtman.org ([149.28.33.109]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwHzW-0005Qm-JO for qemu-devel@nongnu.org; Wed, 10 Sep 2025 06:24:00 -0400 Received: by lichtman.org (Postfix, from userid 1000) id 047AE176F04; Wed, 10 Sep 2025 10:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lichtman.org; s=mail; t=1757499832; bh=JRe97yUSnBZXUcaIzZp3EjbU8msDsVdFjpkz+LDGcx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r0cO63hv2wGlZIPUOo+eQ/f0Z1UQIUv2ErBBvQBoXXR4FSXJBvwWWDNB4jipmeH4L IQJ2mlZZ3nQ+ko5pJCBTHYvqGUNV7sd4Oze1O2wclKauoLrOlQyVF8hTDOGsyy5QZa OfhqqWdcQblirYBOjn2p7w6EvUPOGk8NKnUoIyQmoFVQ+eHAQtEcP8LDxh7ng04xZp 97SmrJnyJse//h5S0J1VY/k7nb+q/6n0l/Uu72v/9HyAlGSZN28Onsh+kl9UwJxSD8 PjvQR/VkR0GHmJyIJ4FNd99OmS+WMI97lmdfc82cHc4ap3JW7/LSRNJ5Y4Ug2aNRtv +3NkL0i+Kcxbw== Date: Wed, 10 Sep 2025 10:23:51 +0000 From: Nir Lichtman To: Gerd Hoffmann Cc: Thomas Huth , peter.maydell@linaro.org, qemu-devel@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Subject: Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding Message-ID: <20250910102351.GA1782682@lichtman.org> References: <20250815090025.GA1464436@lichtman.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=149.28.33.109; envelope-from=nir@lichtman.org; helo=lichtman.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Sep 10, 2025 at 10:38:43AM +0200, Gerd Hoffmann wrote: > On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote: > > On 15/08/2025 11.00, Nir Lichtman wrote: > > > Fix incorrect key binding for resetting the graphical frontends scaling > > > > > > Signed-off-by: Nir Lichtman > > > --- > > > docs/system/keys.rst.inc | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc > > > index c28ae1a..3b5307b 100644 > > > --- a/docs/system/keys.rst.inc > > > +++ b/docs/system/keys.rst.inc > > > @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key. > > > * - :kbd:`Ctrl+Alt+-` > > > - Shrink the screen > > > - * - :kbd:`Ctrl+Alt+u` > > > + * - :kbd:`Ctrl+Alt+0` > > > - Restore the screen's un-scaled dimensions > > > > Hi, > > > > this unfortunately seems to depend on the graphical front-end: For "-display > > gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u > > instead. > > > > Should we unify them? If so, which is the better key combination? > > Established convention in various apps is '+' for zoom in, '-' for zoom > out, and '0' for reset to 100% (each combined with the hotkey > modifier(s)). So when changing hotkeys we should follow that I think, > i.e. switch SDL to Ctrl+Alt+0. I'll send a patch fixing SDL to use CTRL+ALT+0 Nir