Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F0015E5BB for ; Sat, 13 Sep 2025 00:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757721695; cv=none; b=KoQ/ZJM/U5LS7H33M0PjKqZTfS0b9soQg1k5hYZDLJj54R/BezTsZDAMdlQFFB3f+IRTBKk6sqtB8hq2U6lURiMTaCp4kRdeezPJ5F94UJVmMENmhZMC9IiBixrbaKxDHMzwGqtqsJRa5TRtTknigsd8VcagtrdqOZ1Kn3Wn5wM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757721695; c=relaxed/simple; bh=hCsy/qb5fsV4U/ZfD33cto6EmCWWefY4GtL+u9D9szM=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=AWEc6la6SrfN2hw7oSRb9gq1B7f11b6hHIc8iWulDN1QqaKdGHTtfjWOjzTQHb3rhsaMV0XDcf1fyFXr2aKf2iV+a8fNW6mQv4X1KI3fhDNI34S/f+L+dWCBBqaT14Bt1lJN6hyswwkeM5HPdDR60+GMdnyJAJjEEnvs06k17NU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gP7WqKpj; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gP7WqKpj" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-32dd692614aso3476775a91.1 for ; Fri, 12 Sep 2025 17:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757721693; x=1758326493; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=PMhMwVUWtkQhQozvbkaye4gfec+Uus5/E0Yhl+qmRTo=; b=gP7WqKpjI1vLr8cB72GdxLrnHx1Spm04uAAuX0l1LLDghpUpY8k3VsG8NqIeF/9I4q wgf+eoM3YD8v3dwmXmkGdluAGj14fqLlsUZKPj93zyv5qOFDSXXoxs8/9npaeJ6Y1fa+ yEvOPpWRwgTDGwbgaSmZ5H8Jik6dSl6Xl59z79lf0mB5Her9VaPaLtjw1lZrat2Bgp/1 q0YDbK9KbYz9VR5ol0CppbRuMUURFBpXJ40wGfM400cUp5DWTgSr9kmYKEVycsPQtlMJ 8au5WZ4NFMj3hX/N39HRMqQaC4kYPGUsOkABHra1LJB4bIbZGKINKvVCLitP8xIL7r8n OtzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757721693; x=1758326493; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PMhMwVUWtkQhQozvbkaye4gfec+Uus5/E0Yhl+qmRTo=; b=vL5X/UZwuStddcg0y1eyDwgBvO0HVf7td3DFa4Fxtiz5BT6LT1Bsf/5L3vaz1aL2P0 gLlamDgkneasqYrSoqM/po93GBD2ZYdsOHSBQ7IdWAyxzlNLn7e2qvCYWL0qe2DbgFdJ t2LNzmN5+kIH/SDY7DfRRxf2ApavHhGCE5dwoLhSAuHXkLzaGm59y4xKKWxpR5AnzTXN 133wM67kAMbAAH7K34l3/9BvngCr/rfBocfwWypTBdZ80VWY5cCOLE9APEMm4cEgPacm YTnj8ApmC0oheACBkG4CsInQigbOe1jbVyqNuS9PWS+WQyJaQLUo1FgEprMqf8nzkM8c 0pLA== X-Forwarded-Encrypted: i=1; AJvYcCVcbDKy6NHls3Eshan5IJ5nex5NBM4utsAaZ7hNwP2y76uGGTdjtwwORlqlCcgMA4vLQcgNDYvHzZZCvPA0bEK7@vger.kernel.org X-Gm-Message-State: AOJu0YwH5v94ZYWnlqKjpGa2Y2bmM+CPUX056nqxn36S6Cpaok9/vqSY VgkHIsL/cRToDepOGon7vszZQvRKl+nTienfcjxF89ETqwVonxOh3SWvB0NL0oWGDyWYjMSUKNk 6BC9gO+sq+g== X-Google-Smtp-Source: AGHT+IFYXWG5c4pWx8SGKm+MYzC4up5S0kC5qWHuqEAb7gKco/PQlJGOcBTDF6ZQWJ2Jg2rbCpSXqG1lYr9B X-Received: from pjbqb3.prod.google.com ([2002:a17:90b:2803:b0:32b:8eda:24e8]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d40c:b0:329:f535:6e4b with SMTP id 98e67ed59e1d1-32de4fb9de0mr5671674a91.37.1757721693349; Fri, 12 Sep 2025 17:01:33 -0700 (PDT) Date: Fri, 12 Sep 2025 17:01:29 -0700 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.384.g4c02a37b29-goog Message-ID: <20250913000129.1306162-1-irogers@google.com> Subject: [PATCH v1] perf lock: Provide a host_env for session new From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" When "perf lock con" is run in a live mode, with no data file, a host environment must be provided. Testing missed this as a failing assert was creating the 1 line of expected stderr output. Signed-off-by: Ian Rogers --- Please consider this patch for v6.17 fixes. --- tools/perf/builtin-lock.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index fd49703021fd..078634461df2 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c @@ -2009,6 +2009,7 @@ static int __cmd_contention(int argc, const char **argv) .owner = show_lock_owner, .cgroups = RB_ROOT, }; + struct perf_env host_env; lockhash_table = calloc(LOCKHASH_SIZE, sizeof(*lockhash_table)); if (!lockhash_table) @@ -2024,7 +2025,10 @@ static int __cmd_contention(int argc, const char **argv) eops.mmap = perf_event__process_mmap; eops.tracing_data = perf_event__process_tracing_data; - session = perf_session__new(use_bpf ? NULL : &data, &eops); + perf_env__init(&host_env); + session = __perf_session__new(use_bpf ? NULL : &data, &eops, + /*trace_event_repipe=*/false, &host_env); + if (IS_ERR(session)) { pr_err("Initializing perf session failed\n"); err = PTR_ERR(session); @@ -2142,6 +2146,7 @@ static int __cmd_contention(int argc, const char **argv) evlist__delete(con.evlist); lock_contention_finish(&con); perf_session__delete(session); + perf_env__exit(&host_env); zfree(&lockhash_table); return err; } -- 2.51.0.384.g4c02a37b29-goog